fix Issue 3281 by merging stores after expression statements #151
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
xingweitian
reviewed
Jul 8, 2020
| public List<ReturnNode> getReturnNodes() { | ||
| return returnNodes; | ||
| } | ||
|
|
||
| /** | ||
| * Return the top-level nodes of all the expression statements encountered. |
There was a problem hiding this comment.
To be consistent, here maybe also use Returns?
wmdietl
reviewed
Jul 20, 2020
| @@ -3616,7 +3669,11 @@ public Node visitErroneous(ErroneousTree tree, Void p) { | |||
|
|
|||
| @Override | |||
| public Node visitExpressionStatement(ExpressionStatementTree tree, Void p) { | |||
| return scan(tree.getExpression(), p); | |||
| Node node = scan(tree.getExpression(), p); | |||
There was a problem hiding this comment.
Thanks for exploring this option.
Can you investigate the following alternative: Here, create a local variable and assign non-void expressions to that local variable.
I think that should also cause merging of the two branches and is far less invasive than adding expressionStatementRootNodes, for which I don't really see a good use case.
|
This PR tries to solve typetools#3281. However, the solution touches the dataflow framework infrastructure by handling special cases in method |
d367wang
pushed a commit
to d367wang/checker-framework
that referenced
this pull request
Jan 21, 2022
Co-authored-by: Suzanne Millstein <[email protected]> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> Co-authored-by: Michael Ernst <[email protected]> Co-authored-by: Manu Sridharan <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR fixes typetools#3281 by merging stores after expression statements, as follows.