-
Notifications
You must be signed in to change notification settings - Fork 533
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fixes 5445: Add checks for feature flags #5464
Fixes 5445: Add checks for feature flags #5464
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks @kkmurerwa! Overall implementation looks great, but I have a comment re- Function Scoping and Style Consistency: You use both function declarations and the function keyword. It's generally better to stick with one style for consistency.
PTAL.
@adhiamboperes I have made the changes requested. PTAL and let me know if further modifications are required. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, thanks @kkmurerwa!
Explanation
Fixes #5445: When merged, this PR will;
Essential Checklist