Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixes 5445: Add checks for feature flags #5464

Merged
merged 12 commits into from
Jul 19, 2024

Conversation

kkmurerwa
Copy link
Collaborator

@kkmurerwa kkmurerwa commented Jul 16, 2024

Explanation

Fixes #5445: When merged, this PR will;

  • Introduce a check to ensure new feature flags are added into the FeatureFlagsLogger
  • Add any existing flags that are currently not being logged
  • Add the feature_flags_check.sh file to static_checks.sh so that it can be run locally

Essential Checklist

  • The PR title and explanation each start with "Fix #bugnum: " (If this PR fixes part of an issue, prefix the title with "Fix part of #bugnum: ...".)
  • Any changes to scripts/assets files have their rationale included in the PR explanation.
  • The PR follows the style guide.
  • The PR does not contain any unnecessary code changes from Android Studio (reference).
  • The PR is made from a branch that's not called "develop" and is up-to-date with "develop".
  • The PR is assigned to the appropriate reviewers (reference).

@kkmurerwa kkmurerwa changed the title Fix 5445: Add checks for feature flags Fixes 5445: Add checks for feature flags Jul 18, 2024
@kkmurerwa kkmurerwa marked this pull request as ready for review July 18, 2024 11:10
@kkmurerwa kkmurerwa requested a review from a team as a code owner July 18, 2024 11:10
@kkmurerwa kkmurerwa requested a review from BenHenning July 18, 2024 11:10
Copy link
Collaborator

@adhiamboperes adhiamboperes left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @kkmurerwa! Overall implementation looks great, but I have a comment re- Function Scoping and Style Consistency: You use both function declarations and the function keyword. It's generally better to stick with one style for consistency.

PTAL.

@kkmurerwa kkmurerwa assigned adhiamboperes and unassigned kkmurerwa Jul 19, 2024
@kkmurerwa
Copy link
Collaborator Author

@adhiamboperes I have made the changes requested. PTAL and let me know if further modifications are required.

Copy link
Collaborator

@adhiamboperes adhiamboperes left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks @kkmurerwa!

@adhiamboperes adhiamboperes removed their assignment Jul 19, 2024
@adhiamboperes adhiamboperes merged commit 4b49cd8 into oppia:develop Jul 19, 2024
41 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Feature Request]: Introduce mechanisms to ensure newly created feature flags are logged
4 participants