Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix part of #5070: Display empty answer message in Math expressions input interaction. #5317

Merged
merged 44 commits into from
Mar 12, 2024

Conversation

Vishwajith-Shettigar
Copy link
Collaborator

@Vishwajith-Shettigar Vishwajith-Shettigar commented Jan 22, 2024

Explanation

Fix part of #5070, In Math expressions Interaction UI, leave submit button enabled when answer is empty. Show an error on submitting an empty answer.

MathExpressionInteractionsViewTestActivity added to accessibility_label_exemptions and test_file_exemptions files.

Numeric expression

numerix_expression.webm

Algebraic expression

algebraic_expression.webm

Math equation

math_equation.webm

Essential Checklist

  • The PR title and explanation each start with "Fix #bugnum: " (If this PR fixes part of an issue, prefix the title with "Fix part of #bugnum: ...".)
  • Any changes to scripts/assets files have their rationale included in the PR explanation.
  • The PR follows the style guide.
  • The PR does not contain any unnecessary code changes from Android Studio (reference).
  • The PR is made from a branch that's not called "develop" and is up-to-date with "develop".
  • The PR is assigned to the appropriate reviewers (reference).

For UI-specific PRs only

If your PR includes UI-related changes, then:

  • Add screenshots for portrait/landscape for both a tablet & phone of the before & after UI changes
  • For the screenshots above, include both English and pseudo-localized (RTL) screenshots (see RTL guide)
  • Add a video showing the full UX flow with a screen reader enabled (see accessibility guide)
  • For PRs introducing new UI elements or color changes, both light and dark mode screenshots must be included
  • Add a screenshot demonstrating that you ran affected Espresso tests locally & that they're passing

@Vishwajith-Shettigar Vishwajith-Shettigar marked this pull request as ready for review January 23, 2024 05:21
@Vishwajith-Shettigar Vishwajith-Shettigar requested review from a team as code owners January 23, 2024 05:21
@Vishwajith-Shettigar
Copy link
Collaborator Author

@adhiamboperes, PTAL.

Copy link

oppiabot bot commented Jan 23, 2024

Unassigning @Vishwajith-Shettigar since a re-review was requested. @Vishwajith-Shettigar, please make sure you have addressed all review comments. Thanks!

@Vishwajith-Shettigar Vishwajith-Shettigar marked this pull request as draft January 24, 2024 04:22
@Vishwajith-Shettigar Vishwajith-Shettigar marked this pull request as ready for review January 24, 2024 10:23
@Vishwajith-Shettigar Vishwajith-Shettigar requested review from a team as code owners January 24, 2024 10:23
Copy link
Member

@BenHenning BenHenning left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @Vishwajith-Shettigar! Took a pass and had just a few comments. PTAL.

Also, could you update the branch to the latest develop (as there are conflicts to resolve)?

@Vishwajith-Shettigar
Copy link
Collaborator Author

Thank you @BenHenning, PTAL.

Copy link
Member

@BenHenning BenHenning left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @Vishwajith-Shettigar! Just one follow-up--PTAL.

@Vishwajith-Shettigar
Copy link
Collaborator Author

@BenHenning, PTAL.

@oppiabot oppiabot bot assigned BenHenning and unassigned Vishwajith-Shettigar Mar 6, 2024
Copy link

oppiabot bot commented Mar 6, 2024

Unassigning @Vishwajith-Shettigar since a re-review was requested. @Vishwajith-Shettigar, please make sure you have addressed all review comments. Thanks!

Copy link
Member

@BenHenning BenHenning left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @Vishwajith-Shettigar! This LGTM.

@BenHenning BenHenning merged commit b763b6a into oppia:develop Mar 12, 2024
39 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants