-
Notifications
You must be signed in to change notification settings - Fork 535
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix part of #5070: Display empty answer message in Math expressions input interaction. #5317
Fix part of #5070: Display empty answer message in Math expressions input interaction. #5317
Conversation
@adhiamboperes, PTAL. |
Unassigning @Vishwajith-Shettigar since a re-review was requested. @Vishwajith-Shettigar, please make sure you have addressed all review comments. Thanks! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks @Vishwajith-Shettigar! Took a pass and had just a few comments. PTAL.
Also, could you update the branch to the latest develop (as there are conflicts to resolve)?
...Test/java/org/oppia/android/app/customview/interaction/MathExpressionInteractionsViewTest.kt
Outdated
Show resolved
Hide resolved
app/src/sharedTest/java/org/oppia/android/app/player/state/StateFragmentTest.kt
Outdated
Show resolved
Hide resolved
app/src/sharedTest/java/org/oppia/android/app/player/state/StateFragmentTest.kt
Show resolved
Hide resolved
Thank you @BenHenning, PTAL. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks @Vishwajith-Shettigar! Just one follow-up--PTAL.
app/src/sharedTest/java/org/oppia/android/app/player/state/StateFragmentTest.kt
Show resolved
Hide resolved
@BenHenning, PTAL. |
Unassigning @Vishwajith-Shettigar since a re-review was requested. @Vishwajith-Shettigar, please make sure you have addressed all review comments. Thanks! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks @Vishwajith-Shettigar! This LGTM.
Explanation
Fix part of #5070, In Math expressions Interaction UI, leave submit button enabled when answer is empty. Show an error on submitting an empty answer.
MathExpressionInteractionsViewTestActivity added to accessibility_label_exemptions and test_file_exemptions files.
Numeric expression
numerix_expression.webm
Algebraic expression
algebraic_expression.webm
Math equation
math_equation.webm
Essential Checklist
For UI-specific PRs only
If your PR includes UI-related changes, then: