Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix Part of #5001: Create Firebase Wrapper #5280

Closed
wants to merge 23 commits into from
Closed

Fix Part of #5001: Create Firebase Wrapper #5280

wants to merge 23 commits into from

Conversation

adhiamboperes
Copy link
Collaborator

@adhiamboperes adhiamboperes commented Dec 21, 2023 •
edited
Loading

Explanation

Fixes Part of #5001
Creates a wrapper for FirebaseAuth that can be swapped out in tests.
Refactors dagger modules related to authentication.
Removes unused interfaces.
Updates tests.

Essential Checklist

  • The PR title and explanation each start with "Fix #bugnum: " (If this PR fixes part of an issue, prefix the title with "Fix part of #bugnum: ...".)
  • Any changes to scripts/assets files have their rationale included in the PR explanation.
  • The PR follows the style guide.
  • The PR does not contain any unnecessary code changes from Android Studio (reference).
  • The PR is made from a branch that's not called "develop" and is up-to-date with "develop".
  • The PR is assigned to the appropriate reviewers (reference).

For UI-specific PRs only

If your PR includes UI-related changes, then:

  • Add screenshots for portrait/landscape for both a tablet & phone of the before & after UI changes
  • For the screenshots above, include both English and pseudo-localized (RTL) screenshots (see RTL guide)
  • Add a video showing the full UX flow with a screen reader enabled (see accessibility guide)
  • For PRs introducing new UI elements or color changes, both light and dark mode screenshots must be included
  • Add a screenshot demonstrating that you ran affected Espresso tests locally & that they're passing

@adhiamboperes adhiamboperes requested review from a team as code owners December 21, 2023 13:09
@adhiamboperes adhiamboperes requested review from BenHenning and removed request for a team December 21, 2023 13:09
@adhiamboperes adhiamboperes self-assigned this Dec 21, 2023
adhiamboperes
adhiamboperes commented Dec 23, 2023
View reviewed changes
domain/src/test/java/org/oppia/android/domain/auth/AuthenticationModuleTest.kt Outdated
@Singleton
@Component(
modules = [
TestModule::class, TestDispatcherModule::class, AuthenticationModule::class,
TestModule::class, TestDispatcherModule::class, TestAuthenticationModule::class,
Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Unable to get this test to pass since it requires AuthenticationModule::class, which still requires the real firebase app to be initialized. I am experiencing difficulty providing a fake while still Binding the ProdImpl of the wrapper, to be tested.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why can't we bind the production implementations here for this test? Not clear to me what the specific issue is.

@oppiabot OppiaBot
Copy link

oppiabot bot commented Dec 30, 2023

Hi @adhiamboperes, I'm going to mark this PR as stale because it hasn't had any updates for 7 days. If no further activity occurs within 7 days, it will be automatically closed so that others can take up the issue.
If you are still working on this PR, please make a follow-up commit within 3 days (and submit it for review, if applicable). Please also let us know if you are stuck so we can help you!

@oppiabot oppiabot bot added the stale Corresponds to items that haven't seen a recent update and may be automatically closed. label Dec 30, 2023
@adhiamboperes adhiamboperes removed the stale Corresponds to items that haven't seen a recent update and may be automatically closed. label Jan 2, 2024
@adhiamboperes
Copy link
Collaborator Author

Closing as commits have been squashed into #5098

@adhiamboperes adhiamboperes deleted the create-firebase-wrapper branch January 18, 2024 05:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@BenHenning BenHenning Awaiting requested review from BenHenning BenHenning was automatically assigned from oppia/owners

Assignees

@adhiamboperes adhiamboperes

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@adhiamboperes @BenHenning