Fix part of #3363 AddProfileActivityTest some test didn't pass.

[XichengSpencer]

Explanation

Fix part of #3363
Remove testAddProfileActivity_inputPin_configChange_downloadAccessSwitchIsOn() as discussed with Ben and Adhiambo.

• The old test failed when testing the checkbox should persevere its state after the screen rotated, which native checkbox doesn't have this ability and we agree that we don't need extra implementation to achieve this.

Negate download access logic in AddProfileActivityPresenter so it will correctly set the listener.

Improve testAddProfileActivity_configChange_inputShortPin_create_pinLengthError() by adding the swipeup() action to make the create button fully visible during the test but the test is still flaky

Essential Checklist

• The PR title and explanation each start with "Fix #bugnum: " (If this PR fixes part of an issue, prefix the title with "Fix part of #bugnum: ...".)
• Any changes to scripts/assets files have their rationale included in the PR explanation.
• The PR follows the style guide.
• The PR does not contain any unnecessary code changes from Android Studio (reference).
• The PR is made from a branch that's not called "develop" and is up-to-date with "develop".
• The PR is assigned to the appropriate reviewers (reference).

For UI-specific PRs only

If your PR includes UI-related changes, then:

• Add screenshots for portrait/landscape for both a tablet & phone of the before & after UI changes
• For the screenshots above, include both English and pseudo-localized (RTL) screenshots (see RTL guide)
• Add a video showing the full UX flow with a screen reader enabled (see accessibility guide)
• For PRs introducing new UI elements or color changes, both light and dark mode screenshots must be included
• Add a screenshot demonstrating that you ran affected Espresso tests locally & that they're passing
  

[adhiamboperes]

Thanks @XichengSpencer.

I have left a comment in-line.

Also, could you please update the PR description(the title too) as previously discussed?

[oppiabot]

Hi @XichengSpencer, I'm going to mark this PR as stale because it hasn't had any updates for 7 days. If no further activity occurs within 7 days, it will be automatically closed so that others can take up the issue.
If you are still working on this PR, please make a follow-up commit within 3 days (and submit it for review, if applicable). Please also let us know if you are stuck so we can help you!

[adhiamboperes]

Thanks @XichengSpencer, This LGTM!

[oppiabot]

Hi @XichengSpencer, this PR is ready to be merged. Please address any remaining comments prior to merging, and feel free to ask someone to merge your PR once the CI checks pass and you're happy with it. Thanks!