Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix #630 : Oppia Terminology Wiki #5177

Merged
merged 6 commits into from
Oct 9, 2023
Merged

Fix #630 : Oppia Terminology Wiki #5177

merged 6 commits into from
Oct 9, 2023

Conversation

MohitGupta121
Copy link
Member

@MohitGupta121 MohitGupta121 commented Oct 3, 2023

Explanation

Fix #630 : Oppia Terminology Wiki

I have introduced new terminology in the Oppia wiki file to clarify the meaning of commonly used terms such as Topics, Story, Promoted Story, Skill, Chapter, Exploration, Question, and Concept card within the Oppia and Oppia-Android codebase. Additionally, I have included a visual flowchart that illustrates the interrelationships among these terms.

Essential Checklist

  • The PR title and explanation each start with "Fix #bugnum: " (If this PR fixes part of an issue, prefix the title with "Fix part of #bugnum: ...".)
  • Any changes to scripts/assets files have their rationale included in the PR explanation.
  • The PR follows the style guide.
  • The PR does not contain any unnecessary code changes from Android Studio (reference).
  • The PR is made from a branch that's not called "develop" and is up-to-date with "develop".
  • The PR is assigned to the appropriate reviewers (reference).

Copy link
Member Author

@MohitGupta121 MohitGupta121 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@adhiamboperes I apologize for delay PR. PTAL, Thanks!

Copy link
Collaborator

@adhiamboperes adhiamboperes left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @MohitGupta121! Please review the suggestions and also update your PR description to add a bit for information.

wiki/Terminology in Oppia.md Outdated Show resolved Hide resolved
wiki/Terminology in Oppia.md Outdated Show resolved Hide resolved
wiki/Terminology in Oppia.md Outdated Show resolved Hide resolved
wiki/Terminology in Oppia.md Outdated Show resolved Hide resolved
wiki/Terminology in Oppia.md Outdated Show resolved Hide resolved
wiki/Terminology in Oppia.md Outdated Show resolved Hide resolved
@oppiabot
Copy link

oppiabot bot commented Oct 6, 2023

Unassigning @adhiamboperes since the review is done.

@oppiabot
Copy link

oppiabot bot commented Oct 6, 2023

Hi @MohitGupta121, it looks like some changes were requested on this pull request by @adhiamboperes. PTAL. Thanks!

@MohitGupta121
Copy link
Member Author

Okay, Thanks @adhiamboperes I'll look into these changes.

Copy link
Member Author

@MohitGupta121 MohitGupta121 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@adhiamboperes PTAL, updated PR description with explanation, and suggested changes. Thanks!

Copy link
Collaborator

@adhiamboperes adhiamboperes left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @MohitGupta121, I have left some additional grammar changes.

wiki/Terminology-in-Oppia.md Outdated Show resolved Hide resolved
wiki/Terminology-in-Oppia.md Outdated Show resolved Hide resolved
wiki/Terminology-in-Oppia.md Outdated Show resolved Hide resolved
wiki/Terminology-in-Oppia.md Outdated Show resolved Hide resolved
@oppiabot
Copy link

oppiabot bot commented Oct 9, 2023

Unassigning @adhiamboperes since the review is done.

@oppiabot
Copy link

oppiabot bot commented Oct 9, 2023

Hi @MohitGupta121, it looks like some changes were requested on this pull request by @adhiamboperes. PTAL. Thanks!

@MohitGupta121 MohitGupta121 removed their assignment Oct 9, 2023
Copy link
Member Author

@MohitGupta121 MohitGupta121 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@adhiamboperes Thanks, PTAL.

Copy link
Collaborator

@adhiamboperes adhiamboperes left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @MohitGupta121, LGTM!

@adhiamboperes adhiamboperes enabled auto-merge (squash) October 9, 2023 12:39
@oppiabot
Copy link

oppiabot bot commented Oct 9, 2023

Unassigning @adhiamboperes since they have already approved the PR.

@oppiabot
Copy link

oppiabot bot commented Oct 9, 2023

Assigning @BenHenning for code owner reviews. Thanks!

@adhiamboperes adhiamboperes merged commit c3bb601 into oppia:develop Oct 9, 2023
25 checks passed
@MohitGupta121 MohitGupta121 deleted the oppia_terms_wiki branch October 9, 2023 13:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Wiki: Oppia Terminology Wiki
3 participants