-
Notifications
You must be signed in to change notification settings - Fork 529
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix #630 : Oppia Terminology Wiki #5177
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@adhiamboperes I apologize for delay PR. PTAL, Thanks!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks @MohitGupta121! Please review the suggestions and also update your PR description to add a bit for information.
Unassigning @adhiamboperes since the review is done. |
Hi @MohitGupta121, it looks like some changes were requested on this pull request by @adhiamboperes. PTAL. Thanks! |
Okay, Thanks @adhiamboperes I'll look into these changes. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@adhiamboperes PTAL, updated PR description with explanation, and suggested changes. Thanks!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks @MohitGupta121, I have left some additional grammar changes.
Unassigning @adhiamboperes since the review is done. |
Hi @MohitGupta121, it looks like some changes were requested on this pull request by @adhiamboperes. PTAL. Thanks! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@adhiamboperes Thanks, PTAL.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks @MohitGupta121, LGTM!
Unassigning @adhiamboperes since they have already approved the PR. |
Assigning @BenHenning for code owner reviews. Thanks! |
Explanation
Fix #630 : Oppia Terminology Wiki
I have introduced new terminology in the Oppia wiki file to clarify the meaning of commonly used terms such as Topics, Story, Promoted Story, Skill, Chapter, Exploration, Question, and Concept card within the Oppia and Oppia-Android codebase. Additionally, I have included a visual flowchart that illustrates the interrelationships among these terms.
Essential Checklist