-
Notifications
You must be signed in to change notification settings - Fork 527
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix #5171: Fixes all warnings in "Accessibility" category #5173
Fix #5171: Fixes all warnings in "Accessibility" category #5173
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks @theMr17! I have left some suggestions, and once done please attach a screenshot that shows running ./gradlew :app:lint
does not raise any of these 3 warnings.
app/src/main/res/layout/test_drawable_binding_adapter_activity.xml
Outdated
Show resolved
Hide resolved
Unassigning @adhiamboperes since the review is done. |
Hi @theMr17, it looks like some changes were requested on this pull request by @adhiamboperes. PTAL. Thanks! |
@adhiamboperes PTAL, I have done the changes you suggested. Also, here is the screenshot that shows those 3 warnings are not present anymore. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks @theMr17, this LGTM!
Unassigning @adhiamboperes since they have already approved the PR. |
Hi @theMr17, this PR is ready to be merged. Please address any remaining comments prior to merging, and feel free to ask someone to merge your PR once the CI checks pass and you're happy with it. Thanks! |
Explanation
Fixes #5171
Under this category, the warnings are mainly of 3 types:
Warning: Image without contentDescription.
Fix: Add a
contentDescription
to each of thoseImageView
, or mark as not important for accessibility.Warning: 'onTouch' lambda should call 'View#performClick' when a click is detected
Fix: Call
customView.performClick( )
.Warning: 'clickable' attribute found, please also add 'focusable'.
Fix: Set
android:focusable="true"
as its necessary ifandroid:clickable="true"
.Essential Checklist
For UI-specific PRs only
If your PR includes UI-related changes, then: