Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix part of #5079 : Updated wiki for Gradle Build Failed - Task :utility:kaptGenerateStubsDebugKotlin FAILED #5083

Merged
merged 2 commits into from
Jul 11, 2023

Conversation

MohitGupta121
Copy link
Member

@MohitGupta121 MohitGupta121 commented Jul 9, 2023

Explanation

Fix part of #5079 : Updated wiki to add information about resolving common setup error: Gradle Build Failed - Task :utility:kaptGenerateStubsDebugKotlin FAILED

Essential Checklist

  • The PR title and explanation each start with "Fix #bugnum: " (If this PR fixes part of an issue, prefix the title with "Fix part of #bugnum: ...".)
  • Any changes to scripts/assets files have their rationale included in the PR explanation.
  • The PR follows the style guide.
  • The PR does not contain any unnecessary code changes from Android Studio (reference).
  • The PR is made from a branch that's not called "develop" and is up-to-date with "develop".
  • The PR is assigned to the appropriate reviewers (reference).

For UI-specific PRs only

If your PR includes UI-related changes, then:

  • Add screenshots for portrait/landscape for both a tablet & phone of the before & after UI changes
  • For the screenshots above, include both English and pseudo-localized (RTL) screenshots (see RTL guide)
  • Add a video showing the full UX flow with a screen reader enabled (see accessibility guide)
  • Add a screenshot demonstrating that you ran affected Espresso tests locally & that they're passing

@MohitGupta121 MohitGupta121 requested a review from a team as a code owner July 9, 2023 17:49
@MohitGupta121 MohitGupta121 requested review from a team as code owners July 9, 2023 17:49
@MohitGupta121 MohitGupta121 requested a review from seanlip July 9, 2023 17:49
Copy link
Member Author

@MohitGupta121 MohitGupta121 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@adhiamboperes PTAL, Thanks!

Copy link
Collaborator

@adhiamboperes adhiamboperes left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @MohitGupta121!

In addition to my in-line suggestions:

The PR title and description are a bit misleading; they seem to imply that this PR fixes the gradle build issue instead of updating the wiki. Please update that.

Please also change this to "Fix Part of #5079".

wiki/Troubleshooting-Installation.md Outdated Show resolved Hide resolved
wiki/Troubleshooting-Installation.md Outdated Show resolved Hide resolved
@MohitGupta121 MohitGupta121 changed the title Fix #5079 : Gradle Build Failed - Task :utility:kaptGenerateStubsDebugKotlin FAILED Fix part of #5079 : Updated wiki for Gradle Build Failed - Task :utility:kaptGenerateStubsDebugKotlin FAILED Jul 10, 2023
Copy link
Member Author

@MohitGupta121 MohitGupta121 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@adhiamboperes PTAL, Thanks.
I updated the suggested changes.

Copy link
Collaborator

@adhiamboperes adhiamboperes left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @MohitGupta121, this LGTM!

Assigning @seanlip for codeowners.

@seanlip seanlip merged commit dbbbccf into develop Jul 11, 2023
@seanlip seanlip deleted the gradle_error_wiki branch July 11, 2023 03:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants