Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update README.md #5060

Merged
merged 6 commits into from
Jun 19, 2023
Merged

Update README.md #5060

merged 6 commits into from
Jun 19, 2023

Conversation

prafulbbandre
Copy link
Contributor

Explanation

This Pr makes changes to the redme.md file.

Essential Checklist

  • The PR title and explanation each start with "Fix #bugnum: " (If this PR fixes part of an issue, prefix the title with "Fix part of #bugnum: ...".)
  • Any changes to scripts/assets files have their rationale included in the PR explanation.
  • The PR follows the style guide.
  • The PR does not contain any unnecessary code changes from Android Studio (reference).
  • The PR is made from a branch that's not called "develop" and is up-to-date with "develop".
  • The PR is assigned to the appropriate reviewers (reference).

For UI-specific PRs only

If your PR includes UI-related changes, then:

  • Add screenshots for portrait/landscape for both a tablet & phone of the before & after UI changes
  • For the screenshots above, include both English and pseudo-localized (RTL) screenshots (see RTL guide)
  • Add a video showing the full UX flow with a screen reader enabled (see accessibility guide)
  • Add a screenshot demonstrating that you ran affected Espresso tests locally & that they're passing

Verified

This commit was created on GitHub.com and signed with GitHub’s verified signature.
@prafulbbandre prafulbbandre requested a review from a team as a code owner June 16, 2023 19:18
@prafulbbandre prafulbbandre requested a review from seanlip June 16, 2023 19:18
@prafulbbandre
Copy link
Contributor Author

@seanlip PTAL

Copy link
Member

@seanlip seanlip left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @prafulbbandre, left some notes, PTAL.

.github/README.md Outdated Show resolved Hide resolved
@seanlip seanlip assigned prafulbbandre and unassigned seanlip Jun 17, 2023
@seanlip
Copy link
Member

seanlip commented Jun 17, 2023 via email

@prafulbbandre prafulbbandre requested review from a team as code owners June 18, 2023 08:40
@prafulbbandre prafulbbandre removed their assignment Jun 18, 2023
@prafulbbandre prafulbbandre requested a review from seanlip June 18, 2023 08:44
@prafulbbandre
Copy link
Contributor Author

@seanlip PTAL

.github/README.md Outdated Show resolved Hide resolved
wiki/Installing-Oppia-Android.md Outdated Show resolved Hide resolved
@seanlip seanlip assigned prafulbbandre and unassigned seanlip Jun 18, 2023
@prafulbbandre
Copy link
Contributor Author

@seanlip can you please rerun the tests.

@seanlip
Copy link
Member

seanlip commented Jun 18, 2023

Done. Please reply to all comments before requesting further reviews.

@prafulbbandre prafulbbandre requested a review from seanlip June 18, 2023 19:05
@prafulbbandre prafulbbandre removed their assignment Jun 18, 2023
@prafulbbandre
Copy link
Contributor Author

@seanlip PTAL

Copy link
Member

@seanlip seanlip left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @prafulbbandre!

@seanlip seanlip merged commit be57dd2 into oppia:develop Jun 19, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants