-
Notifications
You must be signed in to change notification settings - Fork 535
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update README.md #5060
Update README.md #5060
Conversation
@seanlip PTAL |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks @prafulbbandre, left some notes, PTAL.
Yes that is fine, as long as developers aren't likely to leave the
installation page before going all the way to the end.
…On Sun, Jun 18, 2023, 1:32 AM PRAFUL BANDRE ***@***.***> wrote:
***@***.**** commented on this pull request.
------------------------------
In .github/README.md
<#5060 (comment)>:
> @@ -16,7 +16,7 @@ Oppia Android is written using Kotlin and Java, and leverages Bazel, databinding
## Installation
-Please refer to the [installation wiki page](https://github.com/oppia/oppia-android/wiki/Contributing-to-Oppia-android#install-oppia-android) for full instructions.
+Please refer to the [Installing-Oppia-Android](https://github.com/oppia/oppia-android/wiki/Installing-Oppia-Android) page for full instructions on how to install Oppia-Android on local machine.
Will it be okay if we add the link to the general contribution
instructions page at the end of the installation page.
—
Reply to this email directly, view it on GitHub
<#5060 (comment)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/ACQV5SVAPUDWUKONS5BQBJDXLXSZTANCNFSM6AAAAAAZJUOYME>
.
You are receiving this because you were mentioned.Message ID:
***@***.***>
|
@seanlip PTAL |
@seanlip can you please rerun the tests. |
Done. Please reply to all comments before requesting further reviews. |
@seanlip PTAL |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks @prafulbbandre!
Explanation
This Pr makes changes to the redme.md file.
Essential Checklist
For UI-specific PRs only
If your PR includes UI-related changes, then: