Add codeowners to translation strings files.

[seanlip]

Explanation

Adding @adhiamboperes and me to codeowners so that we can help with translation string file approvals (like #4969).

Essential Checklist

• The PR title and explanation each start with "Fix #bugnum: " (If this PR fixes part of an issue, prefix the title with "Fix part of #bugnum: ...".)
• Any changes to scripts/assets files have their rationale included in the PR explanation.
• The PR follows the style guide.
• The PR does not contain any unnecessary code changes from Android Studio (reference).
• The PR is made from a branch that's not called "develop" and is up-to-date with "develop".
• The PR is assigned to the appropriate reviewers (reference).

[seanlip]

@BenHenning this is just a suggestion -- see if you like it. If not, totally fine to close this PR. Thanks!

[BenHenning]

I usually don't have much issue with reviewing the PRs (they're not very common); the bigger issue is that auto-assignment doesn't seem to be working with them.

My only concern with expanding the existing codeowners for localization is making sure reviewers know what to look for since we've had past strings break due to having incorrect format specifiers and some HTML formatting problems (though Translatewiki mostly covers those problems). We still need much more robust checks for strings--these haven't been implemented yet.

I'm fine with expanding codeowners here so long as you both are fine with bringing a translation PR to my attention if it even seems like it might have issues when it comes to markup or format specifiers @seanlip @adhiamboperes. Would that be fine?

[seanlip]

Yeah, that's fine with me, thanks @BenHenning. I didn't realize we lacked validation here, it has actually broken Web in the past. Do we have an issue tracking this?

[adhiamboperes]

I usually don't have much issue with reviewing the PRs (they're not very common); the bigger issue is that auto-assignment doesn't seem to be working with them.

My only concern with expanding the existing codeowners for localization is making sure reviewers know what to look for since we've had past strings break due to having incorrect format specifiers and some HTML formatting problems (though Translatewiki mostly covers those problems). We still need much more robust checks for strings--these haven't been implemented yet.

I'm fine with expanding codeowners here so long as you both are fine with bringing a translation PR to my attention if it even seems like it might have issues when it comes to markup or format specifiers @seanlip @adhiamboperes. Would that be fine?

Yes, this is fine.

[BenHenning]

Yeah, that's fine with me, thanks @BenHenning. I didn't realize we lacked validation here, it has actually broken Web in the past. Do we have an issue tracking this?

Yep: #4562. I haven't filled in the details of it yet, I have a TDD with the high-level details that need to be distilled into that issue.

[BenHenning]

Thanks @seanlip and @adhiamboperes for confirming. Approving & enabling auto-merge.

[oppiabot]

Unassigning @BenHenning since they have already approved the PR.

[oppiabot]

Hi @seanlip, this PR is ready to be merged. Please address any remaining comments prior to merging, and feel free to merge this PR once the CI checks pass and you're happy with it. Thanks!