-
Notifications
You must be signed in to change notification settings - Fork 528
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
App and OS deprecation: Milestone 1 #4967
Conversation
…providers for both the app and testing
…providers for both app and testing
@adhiamboperes could you please review this first until it looks good to you & then send it my way for approval? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks @kkmurerwa.
I have taken a pass and requested (mostly) minor changes.
utility/src/main/java/org/oppia/android/util/platformparameter/PlatformParameterConstants.kt
Outdated
Show resolved
Hide resolved
utility/src/main/java/org/oppia/android/util/platformparameter/PlatformParameterConstants.kt
Outdated
Show resolved
Hide resolved
...ing/src/main/java/org/oppia/android/testing/platformparameter/TestPlatformParameterModule.kt
Show resolved
Hide resolved
Unassigning @adhiamboperes since the review is done. |
Hi @kkmurerwa, it looks like some changes were requested on this pull request by @adhiamboperes. PTAL. Thanks! |
… flag to improve readability
Hey, @adhiamboperes. I have addressed your comments. The PR should be ready for another review. PTAL |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hey @kkmurerwa, these changes LGTM except there are some more nits relating to other comments you're yet to update.
utility/src/main/java/org/oppia/android/util/platformparameter/PlatformParameterConstants.kt
Outdated
Show resolved
Hide resolved
utility/src/main/java/org/oppia/android/util/platformparameter/PlatformParameterConstants.kt
Outdated
Show resolved
Hide resolved
utility/src/main/java/org/oppia/android/util/platformparameter/PlatformParameterConstants.kt
Outdated
Show resolved
Hide resolved
utility/src/main/java/org/oppia/android/util/platformparameter/PlatformParameterConstants.kt
Outdated
Show resolved
Hide resolved
utility/src/main/java/org/oppia/android/util/platformparameter/PlatformParameterConstants.kt
Outdated
Show resolved
Hide resolved
utility/src/main/java/org/oppia/android/util/platformparameter/PlatformParameterConstants.kt
Outdated
Show resolved
Hide resolved
…able and easier to understand
Hi @adhiamboperes. I have updated the comments some more to reflect your latest suggestions. I think it is okay for another review. PTAL |
utility/src/main/java/org/oppia/android/util/platformparameter/PlatformParameterConstants.kt
Outdated
Show resolved
Hide resolved
Unassigning @kkmurerwa since a re-review was requested. @kkmurerwa, please make sure you have addressed all review comments. Thanks! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hi @kkmurerwa, these changes look good to me!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks @kkmurerwa! Just had a couple follow-ups--PTAL.
domain/src/test/java/org/oppia/android/domain/platformparameter/PlatformParameterModuleTest.kt
Show resolved
Hide resolved
domain/src/test/java/org/oppia/android/domain/platformparameter/PlatformParameterModuleTest.kt
Outdated
Show resolved
Hide resolved
domain/src/test/java/org/oppia/android/domain/platformparameter/PlatformParameterModuleTest.kt
Outdated
Show resolved
Hide resolved
domain/src/test/java/org/oppia/android/domain/platformparameter/PlatformParameterModuleTest.kt
Outdated
Show resolved
Hide resolved
Hey @BenHenning. I pushed a new commit with the suggested changes. The tests should be fine now, though I did not include an explicit test for the defaulting to zero scenario. I believe this is covered by the other tests. PTAL. |
Unassigning @kkmurerwa since a re-review was requested. @kkmurerwa, please make sure you have addressed all review comments. Thanks! |
Hi @kkmurerwa, I'm going to mark this PR as stale because it hasn't had any updates for 7 days. If no further activity occurs within 7 days, it will be automatically closed so that others can take up the issue. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks @kkmurerwa! Sorry for the delayed review here. The PR LGTM!
Updating with the latest develop & enabling auto-merge. |
Unassigning @BenHenning since they have already approved the PR. |
Hi @kkmurerwa, this PR is ready to be merged. Please address any remaining comments prior to merging, and feel free to ask someone to merge your PR once the CI checks pass and you're happy with it. Thanks! |
Explanation
When this PR is merged, it will;
Essential Checklist
For UI-specific PRs only
If your PR includes UI-related changes, then: