Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

App and OS deprecation: Milestone 1 #4967

Merged
merged 13 commits into from
May 27, 2023

Conversation

kkmurerwa
Copy link
Collaborator

Explanation

When this PR is merged, it will;

  • Add platform parameters for App/OS deprecation, optional app update version code, forced app update version code and lowest supported API level.
  • Create dependency injection providers for these four new platform parameters.

Essential Checklist

  • The PR title and explanation each start with "Fix #bugnum: " (If this PR fixes part of an issue, prefix the title with "Fix part of #bugnum: ...".)
  • Any changes to scripts/assets files have their rationale included in the PR explanation.
  • The PR follows the style guide.
  • The PR does not contain any unnecessary code changes from Android Studio (reference).
  • The PR is made from a branch that's not called "develop" and is up-to-date with "develop".
  • The PR is assigned to the appropriate reviewers (reference).

For UI-specific PRs only

If your PR includes UI-related changes, then:

  • Add screenshots for portrait/landscape for both a tablet & phone of the before & after UI changes
  • For the screenshots above, include both English and pseudo-localized (RTL) screenshots (see RTL guide)
  • Add a video showing the full UX flow with a screen reader enabled (see accessibility guide)
  • Add a screenshot demonstrating that you ran affected Espresso tests locally & that they're passing

@BenHenning
Copy link
Member

BenHenning commented May 9, 2023

@adhiamboperes could you please review this first until it looks good to you & then send it my way for approval?

Copy link
Collaborator

@adhiamboperes adhiamboperes left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @kkmurerwa.
I have taken a pass and requested (mostly) minor changes.

@oppiabot
Copy link

oppiabot bot commented May 9, 2023

Unassigning @adhiamboperes since the review is done.

@oppiabot
Copy link

oppiabot bot commented May 9, 2023

Hi @kkmurerwa, it looks like some changes were requested on this pull request by @adhiamboperes. PTAL. Thanks!

@kkmurerwa
Copy link
Collaborator Author

Hey, @adhiamboperes. I have addressed your comments. The PR should be ready for another review. PTAL

@kkmurerwa kkmurerwa assigned adhiamboperes and unassigned kkmurerwa May 9, 2023
Copy link
Collaborator

@adhiamboperes adhiamboperes left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey @kkmurerwa, these changes LGTM except there are some more nits relating to other comments you're yet to update.

@kkmurerwa
Copy link
Collaborator Author

Hi @adhiamboperes. I have updated the comments some more to reflect your latest suggestions. I think it is okay for another review. PTAL

@kkmurerwa kkmurerwa assigned adhiamboperes and unassigned kkmurerwa May 10, 2023
@oppiabot oppiabot bot assigned adhiamboperes and BenHenning and unassigned kkmurerwa May 12, 2023
@oppiabot
Copy link

oppiabot bot commented May 12, 2023

Unassigning @kkmurerwa since a re-review was requested. @kkmurerwa, please make sure you have addressed all review comments. Thanks!

Copy link
Collaborator

@adhiamboperes adhiamboperes left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @kkmurerwa, these changes look good to me!

@adhiamboperes adhiamboperes removed their assignment May 16, 2023
Copy link
Member

@BenHenning BenHenning left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @kkmurerwa! Just had a couple follow-ups--PTAL.

@BenHenning BenHenning assigned kkmurerwa and unassigned BenHenning May 16, 2023
@kkmurerwa
Copy link
Collaborator Author

Hey @BenHenning. I pushed a new commit with the suggested changes. The tests should be fine now, though I did not include an explicit test for the defaulting to zero scenario. I believe this is covered by the other tests. PTAL.

@oppiabot
Copy link

oppiabot bot commented May 16, 2023

Unassigning @kkmurerwa since a re-review was requested. @kkmurerwa, please make sure you have addressed all review comments. Thanks!

@oppiabot
Copy link

oppiabot bot commented May 23, 2023

Hi @kkmurerwa, I'm going to mark this PR as stale because it hasn't had any updates for 7 days. If no further activity occurs within 7 days, it will be automatically closed so that others can take up the issue.
If you are still working on this PR, please make a follow-up commit within 3 days (and submit it for review, if applicable). Please also let us know if you are stuck so we can help you!

@oppiabot oppiabot bot added the stale Corresponds to items that haven't seen a recent update and may be automatically closed. label May 23, 2023
Copy link
Member

@BenHenning BenHenning left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @kkmurerwa! Sorry for the delayed review here. The PR LGTM!

@oppiabot oppiabot bot removed the stale Corresponds to items that haven't seen a recent update and may be automatically closed. label May 27, 2023
@BenHenning
Copy link
Member

Updating with the latest develop & enabling auto-merge.

@BenHenning BenHenning enabled auto-merge (squash) May 27, 2023 02:56
@oppiabot
Copy link

oppiabot bot commented May 27, 2023

Unassigning @BenHenning since they have already approved the PR.

@oppiabot oppiabot bot added the PR: LGTM label May 27, 2023
@oppiabot
Copy link

oppiabot bot commented May 27, 2023

Hi @kkmurerwa, this PR is ready to be merged. Please address any remaining comments prior to merging, and feel free to ask someone to merge your PR once the CI checks pass and you're happy with it. Thanks!

@BenHenning BenHenning merged commit 711d5f6 into oppia:develop May 27, 2023
@kkmurerwa kkmurerwa deleted the app-and-os-deprecation branch November 1, 2023 10:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants