-
Notifications
You must be signed in to change notification settings - Fork 527
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Migrate to new third party structure #4920
Conversation
Hi @BenHenning, I'm going to mark this PR as stale because it hasn't had any updates for 7 days. If no further activity occurs within 7 days, it will be automatically closed so that others can take up the issue. |
Conflicts: third_party/BUILD.bazel third_party/maven_install.json
This changes the following: - Removes the alpha_kitkat build (since it's no longer important). - Adds build checks for beta & GA builds. - Updates the logic to run against the base commit rather than develop for better interoperability with chained PRs.
…l-and-kotlin Conflicts: config/proguard/kotlin-proguard-rules.pro third_party/BUILD.bazel
Upgrading to Moshi 1.14 requires pulling in Kotlin's 1.7.x runtime library which will require other dependency updates. Moshi 1.14 isn't actually needed for successful builds, so this fixes Proguard builds by reversing that dependency. This alsp updates the new build stats workflow to use Bazel 6.1.1 & JDK 11, and fixes a test introduced in #4092.
…third-party-structure Conflicts: WORKSPACE app/BUILD.bazel app/src/main/java/org/oppia/android/app/viewmodel/BUILD.bazel domain/BUILD.bazel domain/src/main/java/org/oppia/android/domain/oppialogger/logscheduler/BUILD.bazel domain/src/main/java/org/oppia/android/domain/oppialogger/loguploader/BUILD.bazel oppia_android_application.bzl scripts/src/java/org/oppia/android/scripts/common/BUILD.bazel scripts/src/java/org/oppia/android/scripts/docs/BUILD.bazel scripts/src/java/org/oppia/android/scripts/license/BUILD.bazel scripts/src/javatests/org/oppia/android/scripts/common/BazelClientTest.kt scripts/src/javatests/org/oppia/android/scripts/license/BUILD.bazel scripts/src/javatests/org/oppia/android/scripts/license/MavenDependenciesListCheckTest.kt scripts/src/javatests/org/oppia/android/scripts/license/MavenDependenciesRetrieverTest.kt third_party/BUILD.bazel third_party/kotlin/BUILD.bazel third_party/versions.bzl utility/BUILD.bazel utility/src/test/java/org/oppia/android/util/caching/testing/BUILD.bazel utility/src/test/java/org/oppia/android/util/data/BUILD.bazel utility/src/test/java/org/oppia/android/util/locale/BUILD.bazel utility/src/test/java/org/oppia/android/util/locale/testing/BUILD.bazel utility/src/test/java/org/oppia/android/util/logging/BUILD.bazel utility/src/test/java/org/oppia/android/util/logging/firebase/BUILD.bazel
This modularizes WORKSPACE similar to oppia-proto-api, except to a much greater extent.
This introduces significant simplification for dependency management that also doesn't result in broad third_party reference updates (except for scripts which is failure well isolated).
This doesn't yet have a CI run, but it's already resulted in corrections to the app's versions.bzl lists.
Enable test-only Maven artifacts.
This resulted in some updates for both Gradle & Bazel, but the assumption is that the changes should be minimal. The latest version was picked between Bazel & Gradle, and some other version alignments took place for assumed improved compatibility.
This more or less brings dependency management into a finalized state, though there's still some cleanup possible after this.
Specifically: - Resolved most of the TODOs for this branch. - Reenabled & fixed some utility/ tests. - Improved buildifier script output. - Fixed a bunch of formatting issues in both new and old Bazel code. - Removed the testonly hack for scripts since it's not needed anymore. - Added documentation throughout the new code. - Revised both the third_party versions and macro file structures.
This moves all external deps that had custom Oppia forks to instead use patches and/or local BUILD files (except androidsvg which is a far more complicated change compared to the other packages). This also removes shallow_since since it's now discouraged to use (as of Bazel 6.x).
Re-ran the check, as well, and found no changes needed to any of the Maven deps lists.
Hi @BenHenning, I'm going to mark this PR as stale because it hasn't had any updates for 7 days. If no further activity occurs within 7 days, it will be automatically closed so that others can take up the issue. |
This brings it into parity with other coroutines dependencies, and moves past a potential race condition with runBlocking (which was actually encountered in a downstream PR), per: https://github.com/Kotlin/kotlinx.coroutines/releases/tag/1.6.2.
This change ensures that builds, tools, and local tests all use the same version of Java, and specifically the remote JDK 11 that's bundled within Bazel itself (or, rather, downloaded by Bazel during workspace setup). This ensures more consistency across different build configurations, and has subsequently led to a significant simplification of setup instructions for Linux, Mac, and Windows. Separately, I also noticed that the Python instructions seem outdated now that the project has been migrated to Bazel 6.x. Python 2 should no longer be needed.
Java is probably still needed for sdkmanager.
Revert changes to Windows doc.
…to-newer-bazel-and-kotlin
…third-party-structure Conflicts: .github/CODEOWNERS .github/workflows/stats.yml WORKSPACE app/BUILD.bazel app/build.gradle app/src/main/java/org/oppia/android/app/devoptions/vieweventlogs/ViewEventLogsViewModel.kt app/src/main/res/layout/home_fragment.xml app/src/sharedTest/java/org/oppia/android/app/devoptions/ViewEventLogsActivityTest.kt app/src/sharedTest/java/org/oppia/android/app/devoptions/ViewEventLogsFragmentTest.kt build.gradle build_flavors.bzl build_vars.bzl data/BUILD.bazel domain/build.gradle domain/src/test/java/org/oppia/android/domain/oppialogger/loguploader/LogUploadWorkerTest.kt instrumentation/oppia_instrumentation_test.bzl instrumentation/src/java/org/oppia/android/instrumentation/application/BUILD.bazel scripts/assets/maven_dependencies.textproto scripts/src/java/org/oppia/android/scripts/license/BUILD.bazel scripts/src/java/org/oppia/android/scripts/maven/BUILD.bazel scripts/src/java/org/oppia/android/scripts/proto/BUILD.bazel scripts/src/java/org/oppia/android/scripts/todo/model/BUILD.bazel scripts/src/javatests/org/oppia/android/scripts/license/MavenDependenciesRetrieverTest.kt scripts/src/javatests/org/oppia/android/scripts/todo/BUILD.bazel scripts/third_party/versions/maven_install.json testing/BUILD.bazel testing/src/main/java/org/oppia/android/testing/TestLogReportingModule.kt testing/src/main/java/org/oppia/android/testing/platformparameter/BUILD.bazel third_party/BUILD.bazel third_party/tools/kotlin/remove_processor_duplicates.patch third_party/versions.bzl utility/BUILD.bazel utility/build.gradle utility/src/main/java/org/oppia/android/util/logging/firebase/BUILD.bazel utility/src/main/java/org/oppia/android/util/logging/firebase/DebugLogReportingModule.kt utility/src/main/java/org/oppia/android/util/logging/firebase/LogReportingModule.kt utility/src/test/java/org/oppia/android/util/locale/BUILD.bazel wiki/Updating-Maven-Dependencies.md
This adds WORKSPACE, versions.bzl, and other third-party changes that were cut when resolving conflicts (for simplicity). More work is still needed to actually get the post-merge codebase to build & pass tests.
At this point all scripts are building and script tests passing. This includes incorporating oppia_proto_api (for parity with the develop branch), and enabling dependency validation (using the new Maven dependency validation script) in static_checks.sh (for parity with the static checks CI workflow).
App builds now, as do all non-app tests (haven't checked all app tests due to required build time).
APK & AAB differences analysisNote that this is a summarized snapshot. See the CI artifacts for detailed differences. DevExpand to see flavor specificsUniversal APKAPK file size: 16 MiB (old), 15 MiB (new), 854 KiB (Removed) APK download size (estimated): 14 MiB (old), 14 MiB (new), 834 KiB (Removed) Method count: 221791 (old), 203033 (new), 18758 (Removed) Features: 2 (old), 2 (new), 0 (No change) Permissions: 6 (old), 6 (new), 0 (No change) Resources: 6550 (old), 6550 (new), 0 (No change)
Lesson assets: 105 (old), 105 (new), 0 (No change) AAB differencesExpand to see AAB specificsSupported configurations:
Base APKAPK file size: 15 MiB (old), 15 MiB (new), 854 KiB (Removed) Configuration hdpiAPK file size: 59 KiB (old), 59 KiB (new), 4 bytes (Removed) Configuration ldpiAPK file size: 56 KiB (old), 56 KiB (new), 0 bytes (No change) Configuration mdpiAPK file size: 53 KiB (old), 53 KiB (new), 4 bytes (Removed) Configuration tvdpiAPK file size: 102 KiB (old), 102 KiB (new), 4 bytes (Removed) Configuration xhdpiAPK file size: 67 KiB (old), 67 KiB (new), 4 bytes (Removed) Configuration xxhdpiAPK file size: 76 KiB (old), 76 KiB (new), 0 bytes (No change) Configuration xxxhdpiAPK file size: 79 KiB (old), 79 KiB (new), 0 bytes (No change) AlphaExpand to see flavor specificsUniversal APKAPK file size: 10 MiB (old), 9183 KiB (new), 1062 KiB (Removed) APK download size (estimated): 9150 KiB (old), 8095 KiB (new), 1054 KiB (Removed) Method count: 99436 (old), 86854 (new), 12582 (Removed) Features: 2 (old), 2 (new), 0 (No change) Permissions: 6 (old), 6 (new), 0 (No change) Resources: 5504 (old), 5504 (new), 0 (No change)
Lesson assets: 105 (old), 105 (new), 0 (No change) AAB differencesExpand to see AAB specificsSupported configurations:
Base APKAPK file size: 9 MiB (old), 8945 KiB (new), 1062 KiB (Removed) Configuration hdpiAPK file size: 52 KiB (old), 52 KiB (new), 4 bytes (Removed) Configuration ldpiAPK file size: 52 KiB (old), 52 KiB (new), 4 bytes (Removed) Configuration mdpiAPK file size: 46 KiB (old), 46 KiB (new), 4 bytes (Removed) Configuration tvdpiAPK file size: 90 KiB (old), 90 KiB (new), 4 bytes (Removed) Configuration xhdpiAPK file size: 60 KiB (old), 60 KiB (new), 4 bytes (Removed) Configuration xxhdpiAPK file size: 69 KiB (old), 69 KiB (new), 4 bytes (Removed) Configuration xxxhdpiAPK file size: 71 KiB (old), 71 KiB (new), 0 bytes (No change) BetaExpand to see flavor specificsUniversal APKAPK file size: 9 MiB (old), 9143 KiB (new), 1062 KiB (Removed) APK download size (estimated): 9135 KiB (old), 8084 KiB (new), 1050 KiB (Removed) Method count: 99436 (old), 86854 (new), 12582 (Removed) Features: 2 (old), 2 (new), 0 (No change) Permissions: 6 (old), 6 (new), 0 (No change) Resources: 5504 (old), 5504 (new), 0 (No change)
Lesson assets: 105 (old), 105 (new), 0 (No change) AAB differencesExpand to see AAB specificsSupported configurations:
Base APKAPK file size: 9 MiB (old), 8906 KiB (new), 1062 KiB (Removed) Configuration hdpiAPK file size: 52 KiB (old), 52 KiB (new), 4 bytes (Removed) Configuration ldpiAPK file size: 52 KiB (old), 52 KiB (new), 4 bytes (Removed) Configuration mdpiAPK file size: 46 KiB (old), 46 KiB (new), 4 bytes (Removed) Configuration tvdpiAPK file size: 90 KiB (old), 90 KiB (new), 4 bytes (Removed) Configuration xhdpiAPK file size: 60 KiB (old), 60 KiB (new), 4 bytes (Removed) Configuration xxhdpiAPK file size: 69 KiB (old), 69 KiB (new), 4 bytes (Removed) Configuration xxxhdpiAPK file size: 71 KiB (old), 71 KiB (new), 0 bytes (No change) GaExpand to see flavor specificsUniversal APKAPK file size: 9 MiB (old), 9143 KiB (new), 1062 KiB (Removed) APK download size (estimated): 9136 KiB (old), 8084 KiB (new), 1051 KiB (Removed) Method count: 99436 (old), 86854 (new), 12582 (Removed) Features: 2 (old), 2 (new), 0 (No change) Permissions: 6 (old), 6 (new), 0 (No change) Resources: 5504 (old), 5504 (new), 0 (No change)
Lesson assets: 105 (old), 105 (new), 0 (No change) AAB differencesExpand to see AAB specificsSupported configurations:
Base APKAPK file size: 9 MiB (old), 8906 KiB (new), 1062 KiB (Removed) Configuration hdpiAPK file size: 52 KiB (old), 52 KiB (new), 4 bytes (Removed) Configuration ldpiAPK file size: 52 KiB (old), 52 KiB (new), 4 bytes (Removed) Configuration mdpiAPK file size: 46 KiB (old), 46 KiB (new), 4 bytes (Removed) Configuration tvdpiAPK file size: 90 KiB (old), 90 KiB (new), 4 bytes (Removed) Configuration xhdpiAPK file size: 60 KiB (old), 60 KiB (new), 4 bytes (Removed) Configuration xxhdpiAPK file size: 69 KiB (old), 69 KiB (new), 4 bytes (Removed) Configuration xxxhdpiAPK file size: 71 KiB (old), 71 KiB (new), 0 bytes (No change) |
2 similar comments
APK & AAB differences analysisNote that this is a summarized snapshot. See the CI artifacts for detailed differences. DevExpand to see flavor specificsUniversal APKAPK file size: 16 MiB (old), 15 MiB (new), 854 KiB (Removed) APK download size (estimated): 14 MiB (old), 14 MiB (new), 834 KiB (Removed) Method count: 221791 (old), 203033 (new), 18758 (Removed) Features: 2 (old), 2 (new), 0 (No change) Permissions: 6 (old), 6 (new), 0 (No change) Resources: 6550 (old), 6550 (new), 0 (No change)
Lesson assets: 105 (old), 105 (new), 0 (No change) AAB differencesExpand to see AAB specificsSupported configurations:
Base APKAPK file size: 15 MiB (old), 15 MiB (new), 854 KiB (Removed) Configuration hdpiAPK file size: 59 KiB (old), 59 KiB (new), 4 bytes (Removed) Configuration ldpiAPK file size: 56 KiB (old), 56 KiB (new), 0 bytes (No change) Configuration mdpiAPK file size: 53 KiB (old), 53 KiB (new), 4 bytes (Removed) Configuration tvdpiAPK file size: 102 KiB (old), 102 KiB (new), 4 bytes (Removed) Configuration xhdpiAPK file size: 67 KiB (old), 67 KiB (new), 4 bytes (Removed) Configuration xxhdpiAPK file size: 76 KiB (old), 76 KiB (new), 0 bytes (No change) Configuration xxxhdpiAPK file size: 79 KiB (old), 79 KiB (new), 0 bytes (No change) AlphaExpand to see flavor specificsUniversal APKAPK file size: 10 MiB (old), 9183 KiB (new), 1062 KiB (Removed) APK download size (estimated): 9150 KiB (old), 8095 KiB (new), 1054 KiB (Removed) Method count: 99436 (old), 86854 (new), 12582 (Removed) Features: 2 (old), 2 (new), 0 (No change) Permissions: 6 (old), 6 (new), 0 (No change) Resources: 5504 (old), 5504 (new), 0 (No change)
Lesson assets: 105 (old), 105 (new), 0 (No change) AAB differencesExpand to see AAB specificsSupported configurations:
Base APKAPK file size: 9 MiB (old), 8945 KiB (new), 1062 KiB (Removed) Configuration hdpiAPK file size: 52 KiB (old), 52 KiB (new), 4 bytes (Removed) Configuration ldpiAPK file size: 52 KiB (old), 52 KiB (new), 4 bytes (Removed) Configuration mdpiAPK file size: 46 KiB (old), 46 KiB (new), 4 bytes (Removed) Configuration tvdpiAPK file size: 90 KiB (old), 90 KiB (new), 4 bytes (Removed) Configuration xhdpiAPK file size: 60 KiB (old), 60 KiB (new), 4 bytes (Removed) Configuration xxhdpiAPK file size: 69 KiB (old), 69 KiB (new), 4 bytes (Removed) Configuration xxxhdpiAPK file size: 71 KiB (old), 71 KiB (new), 0 bytes (No change) BetaExpand to see flavor specificsUniversal APKAPK file size: 9 MiB (old), 9143 KiB (new), 1062 KiB (Removed) APK download size (estimated): 9135 KiB (old), 8084 KiB (new), 1050 KiB (Removed) Method count: 99436 (old), 86854 (new), 12582 (Removed) Features: 2 (old), 2 (new), 0 (No change) Permissions: 6 (old), 6 (new), 0 (No change) Resources: 5504 (old), 5504 (new), 0 (No change)
Lesson assets: 105 (old), 105 (new), 0 (No change) AAB differencesExpand to see AAB specificsSupported configurations:
Base APKAPK file size: 9 MiB (old), 8906 KiB (new), 1062 KiB (Removed) Configuration hdpiAPK file size: 52 KiB (old), 52 KiB (new), 4 bytes (Removed) Configuration ldpiAPK file size: 52 KiB (old), 52 KiB (new), 4 bytes (Removed) Configuration mdpiAPK file size: 46 KiB (old), 46 KiB (new), 4 bytes (Removed) Configuration tvdpiAPK file size: 90 KiB (old), 90 KiB (new), 4 bytes (Removed) Configuration xhdpiAPK file size: 60 KiB (old), 60 KiB (new), 4 bytes (Removed) Configuration xxhdpiAPK file size: 69 KiB (old), 69 KiB (new), 4 bytes (Removed) Configuration xxxhdpiAPK file size: 71 KiB (old), 71 KiB (new), 0 bytes (No change) GaExpand to see flavor specificsUniversal APKAPK file size: 9 MiB (old), 9143 KiB (new), 1062 KiB (Removed) APK download size (estimated): 9136 KiB (old), 8084 KiB (new), 1051 KiB (Removed) Method count: 99436 (old), 86854 (new), 12582 (Removed) Features: 2 (old), 2 (new), 0 (No change) Permissions: 6 (old), 6 (new), 0 (No change) Resources: 5504 (old), 5504 (new), 0 (No change)
Lesson assets: 105 (old), 105 (new), 0 (No change) AAB differencesExpand to see AAB specificsSupported configurations:
Base APKAPK file size: 9 MiB (old), 8906 KiB (new), 1062 KiB (Removed) Configuration hdpiAPK file size: 52 KiB (old), 52 KiB (new), 4 bytes (Removed) Configuration ldpiAPK file size: 52 KiB (old), 52 KiB (new), 4 bytes (Removed) Configuration mdpiAPK file size: 46 KiB (old), 46 KiB (new), 4 bytes (Removed) Configuration tvdpiAPK file size: 90 KiB (old), 90 KiB (new), 4 bytes (Removed) Configuration xhdpiAPK file size: 60 KiB (old), 60 KiB (new), 4 bytes (Removed) Configuration xxhdpiAPK file size: 69 KiB (old), 69 KiB (new), 4 bytes (Removed) Configuration xxxhdpiAPK file size: 71 KiB (old), 71 KiB (new), 0 bytes (No change) |
APK & AAB differences analysisNote that this is a summarized snapshot. See the CI artifacts for detailed differences. DevExpand to see flavor specificsUniversal APKAPK file size: 16 MiB (old), 15 MiB (new), 854 KiB (Removed) APK download size (estimated): 14 MiB (old), 14 MiB (new), 834 KiB (Removed) Method count: 221791 (old), 203033 (new), 18758 (Removed) Features: 2 (old), 2 (new), 0 (No change) Permissions: 6 (old), 6 (new), 0 (No change) Resources: 6550 (old), 6550 (new), 0 (No change)
Lesson assets: 105 (old), 105 (new), 0 (No change) AAB differencesExpand to see AAB specificsSupported configurations:
Base APKAPK file size: 15 MiB (old), 15 MiB (new), 854 KiB (Removed) Configuration hdpiAPK file size: 59 KiB (old), 59 KiB (new), 4 bytes (Removed) Configuration ldpiAPK file size: 56 KiB (old), 56 KiB (new), 0 bytes (No change) Configuration mdpiAPK file size: 53 KiB (old), 53 KiB (new), 4 bytes (Removed) Configuration tvdpiAPK file size: 102 KiB (old), 102 KiB (new), 4 bytes (Removed) Configuration xhdpiAPK file size: 67 KiB (old), 67 KiB (new), 4 bytes (Removed) Configuration xxhdpiAPK file size: 76 KiB (old), 76 KiB (new), 0 bytes (No change) Configuration xxxhdpiAPK file size: 79 KiB (old), 79 KiB (new), 0 bytes (No change) AlphaExpand to see flavor specificsUniversal APKAPK file size: 10 MiB (old), 9183 KiB (new), 1062 KiB (Removed) APK download size (estimated): 9150 KiB (old), 8095 KiB (new), 1054 KiB (Removed) Method count: 99436 (old), 86854 (new), 12582 (Removed) Features: 2 (old), 2 (new), 0 (No change) Permissions: 6 (old), 6 (new), 0 (No change) Resources: 5504 (old), 5504 (new), 0 (No change)
Lesson assets: 105 (old), 105 (new), 0 (No change) AAB differencesExpand to see AAB specificsSupported configurations:
Base APKAPK file size: 9 MiB (old), 8945 KiB (new), 1062 KiB (Removed) Configuration hdpiAPK file size: 52 KiB (old), 52 KiB (new), 4 bytes (Removed) Configuration ldpiAPK file size: 52 KiB (old), 52 KiB (new), 4 bytes (Removed) Configuration mdpiAPK file size: 46 KiB (old), 46 KiB (new), 4 bytes (Removed) Configuration tvdpiAPK file size: 90 KiB (old), 90 KiB (new), 4 bytes (Removed) Configuration xhdpiAPK file size: 60 KiB (old), 60 KiB (new), 4 bytes (Removed) Configuration xxhdpiAPK file size: 69 KiB (old), 69 KiB (new), 4 bytes (Removed) Configuration xxxhdpiAPK file size: 71 KiB (old), 71 KiB (new), 0 bytes (No change) BetaExpand to see flavor specificsUniversal APKAPK file size: 9 MiB (old), 9143 KiB (new), 1062 KiB (Removed) APK download size (estimated): 9135 KiB (old), 8084 KiB (new), 1050 KiB (Removed) Method count: 99436 (old), 86854 (new), 12582 (Removed) Features: 2 (old), 2 (new), 0 (No change) Permissions: 6 (old), 6 (new), 0 (No change) Resources: 5504 (old), 5504 (new), 0 (No change)
Lesson assets: 105 (old), 105 (new), 0 (No change) AAB differencesExpand to see AAB specificsSupported configurations:
Base APKAPK file size: 9 MiB (old), 8906 KiB (new), 1062 KiB (Removed) Configuration hdpiAPK file size: 52 KiB (old), 52 KiB (new), 4 bytes (Removed) Configuration ldpiAPK file size: 52 KiB (old), 52 KiB (new), 4 bytes (Removed) Configuration mdpiAPK file size: 46 KiB (old), 46 KiB (new), 4 bytes (Removed) Configuration tvdpiAPK file size: 90 KiB (old), 90 KiB (new), 4 bytes (Removed) Configuration xhdpiAPK file size: 60 KiB (old), 60 KiB (new), 4 bytes (Removed) Configuration xxhdpiAPK file size: 69 KiB (old), 69 KiB (new), 4 bytes (Removed) Configuration xxxhdpiAPK file size: 71 KiB (old), 71 KiB (new), 0 bytes (No change) GaExpand to see flavor specificsUniversal APKAPK file size: 9 MiB (old), 9143 KiB (new), 1062 KiB (Removed) APK download size (estimated): 9136 KiB (old), 8084 KiB (new), 1051 KiB (Removed) Method count: 99436 (old), 86854 (new), 12582 (Removed) Features: 2 (old), 2 (new), 0 (No change) Permissions: 6 (old), 6 (new), 0 (No change) Resources: 5504 (old), 5504 (new), 0 (No change)
Lesson assets: 105 (old), 105 (new), 0 (No change) AAB differencesExpand to see AAB specificsSupported configurations:
Base APKAPK file size: 9 MiB (old), 8906 KiB (new), 1062 KiB (Removed) Configuration hdpiAPK file size: 52 KiB (old), 52 KiB (new), 4 bytes (Removed) Configuration ldpiAPK file size: 52 KiB (old), 52 KiB (new), 4 bytes (Removed) Configuration mdpiAPK file size: 46 KiB (old), 46 KiB (new), 4 bytes (Removed) Configuration tvdpiAPK file size: 90 KiB (old), 90 KiB (new), 4 bytes (Removed) Configuration xhdpiAPK file size: 60 KiB (old), 60 KiB (new), 4 bytes (Removed) Configuration xxhdpiAPK file size: 69 KiB (old), 69 KiB (new), 4 bytes (Removed) Configuration xxxhdpiAPK file size: 71 KiB (old), 71 KiB (new), 0 bytes (No change) |
APK & AAB differences analysisNote that this is a summarized snapshot. See the CI artifacts for detailed differences. DevExpand to see flavor specificsUniversal APKAPK file size: 16 MiB (old), 15 MiB (new), 950 KiB (Removed) APK download size (estimated): 14 MiB (old), 14 MiB (new), 924 KiB (Removed) Method count: 226905 (old), 203033 (new), 23872 (Removed) Features: 2 (old), 2 (new), 0 (No change) Permissions: 6 (old), 6 (new), 0 (No change) Resources: 6550 (old), 6550 (new), 0 (No change)
Lesson assets: 111 (old), 105 (new), 6 (Removed):
AAB differencesExpand to see AAB specificsSupported configurations:
Base APKAPK file size: 16 MiB (old), 15 MiB (new), 950 KiB (Removed) Configuration hdpiAPK file size: 59 KiB (old), 59 KiB (new), 4 bytes (Removed) Configuration ldpiAPK file size: 56 KiB (old), 56 KiB (new), 0 bytes (No change) Configuration mdpiAPK file size: 53 KiB (old), 53 KiB (new), 4 bytes (Removed) Configuration tvdpiAPK file size: 102 KiB (old), 102 KiB (new), 4 bytes (Removed) Configuration xhdpiAPK file size: 67 KiB (old), 67 KiB (new), 4 bytes (Removed) Configuration xxhdpiAPK file size: 76 KiB (old), 76 KiB (new), 0 bytes (No change) Configuration xxxhdpiAPK file size: 79 KiB (old), 79 KiB (new), 0 bytes (No change) AlphaExpand to see flavor specificsUniversal APKAPK file size: 10 MiB (old), 9183 KiB (new), 1099 KiB (Removed) APK download size (estimated): 9183 KiB (old), 8095 KiB (new), 1087 KiB (Removed) Method count: 101341 (old), 86854 (new), 14487 (Removed) Features: 2 (old), 2 (new), 0 (No change) Permissions: 6 (old), 6 (new), 0 (No change) Resources: 5504 (old), 5504 (new), 0 (No change)
Lesson assets: 111 (old), 105 (new), 6 (Removed):
AAB differencesExpand to see AAB specificsSupported configurations:
Base APKAPK file size: 9 MiB (old), 8945 KiB (new), 1099 KiB (Removed) Configuration hdpiAPK file size: 52 KiB (old), 52 KiB (new), 4 bytes (Removed) Configuration ldpiAPK file size: 52 KiB (old), 52 KiB (new), 4 bytes (Removed) Configuration mdpiAPK file size: 46 KiB (old), 46 KiB (new), 4 bytes (Removed) Configuration tvdpiAPK file size: 90 KiB (old), 90 KiB (new), 4 bytes (Removed) Configuration xhdpiAPK file size: 60 KiB (old), 60 KiB (new), 4 bytes (Removed) Configuration xxhdpiAPK file size: 69 KiB (old), 69 KiB (new), 4 bytes (Removed) Configuration xxxhdpiAPK file size: 71 KiB (old), 71 KiB (new), 0 bytes (No change) BetaExpand to see flavor specificsUniversal APKAPK file size: 10 MiB (old), 9143 KiB (new), 1099 KiB (Removed) APK download size (estimated): 9168 KiB (old), 8084 KiB (new), 1083 KiB (Removed) Method count: 101341 (old), 86854 (new), 14487 (Removed) Features: 2 (old), 2 (new), 0 (No change) Permissions: 6 (old), 6 (new), 0 (No change) Resources: 5504 (old), 5504 (new), 0 (No change)
Lesson assets: 111 (old), 105 (new), 6 (Removed):
AAB differencesExpand to see AAB specificsSupported configurations:
Base APKAPK file size: 9 MiB (old), 8906 KiB (new), 1099 KiB (Removed) Configuration hdpiAPK file size: 52 KiB (old), 52 KiB (new), 4 bytes (Removed) Configuration ldpiAPK file size: 52 KiB (old), 52 KiB (new), 4 bytes (Removed) Configuration mdpiAPK file size: 46 KiB (old), 46 KiB (new), 4 bytes (Removed) Configuration tvdpiAPK file size: 90 KiB (old), 90 KiB (new), 4 bytes (Removed) Configuration xhdpiAPK file size: 60 KiB (old), 60 KiB (new), 4 bytes (Removed) Configuration xxhdpiAPK file size: 69 KiB (old), 69 KiB (new), 4 bytes (Removed) Configuration xxxhdpiAPK file size: 71 KiB (old), 71 KiB (new), 0 bytes (No change) GaExpand to see flavor specificsUniversal APKAPK file size: 10 MiB (old), 9143 KiB (new), 1099 KiB (Removed) APK download size (estimated): 9168 KiB (old), 8084 KiB (new), 1083 KiB (Removed) Method count: 101341 (old), 86854 (new), 14487 (Removed) Features: 2 (old), 2 (new), 0 (No change) Permissions: 6 (old), 6 (new), 0 (No change) Resources: 5504 (old), 5504 (new), 0 (No change)
Lesson assets: 111 (old), 105 (new), 6 (Removed):
AAB differencesExpand to see AAB specificsSupported configurations:
Base APKAPK file size: 9 MiB (old), 8906 KiB (new), 1099 KiB (Removed) Configuration hdpiAPK file size: 52 KiB (old), 52 KiB (new), 4 bytes (Removed) Configuration ldpiAPK file size: 52 KiB (old), 52 KiB (new), 4 bytes (Removed) Configuration mdpiAPK file size: 46 KiB (old), 46 KiB (new), 4 bytes (Removed) Configuration tvdpiAPK file size: 90 KiB (old), 90 KiB (new), 4 bytes (Removed) Configuration xhdpiAPK file size: 60 KiB (old), 60 KiB (new), 4 bytes (Removed) Configuration xxhdpiAPK file size: 69 KiB (old), 69 KiB (new), 4 bytes (Removed) Configuration xxxhdpiAPK file size: 71 KiB (old), 71 KiB (new), 0 bytes (No change) |
Explanation
TODO: Finish.
Essential Checklist
For UI-specific PRs only
If your PR includes UI-related changes, then: