Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix #456: HtmlParser Bullet spacing improvisation #488

Closed
wants to merge 1 commit into from

Conversation

rt4914
Copy link
Contributor

@rt4914 rt4914 commented Nov 29, 2019

Explanation

Screenshot_1575021866

Checklist

  • The PR title starts with "Fix #bugnum: ", followed by a short, clear summary of the changes. (If this PR fixes part of an issue, prefix the title with "Fix part of #bugnum: ...".)
  • The PR explanation includes the words "Fixes #bugnum: ..." (or "Fixes part of #bugnum" if the PR only partially fixes an issue).
  • The PR follows the style guide.
  • The PR does not contain any unnecessary auto-generated code from Android Studio.
  • The PR is made from a branch that's not called "develop".
  • The PR is made from a branch that is up-to-date with "develop".
  • The PR's branch is based on "develop" and not on any other branch.
  • The PR is assigned to an appropriate reviewer in both the Assignees and the Reviewers sections.

@veena14cs
Copy link
Contributor

On itemSelection answers it is looking like this.

Screenshot_20191129-155130

@rt4914
Copy link
Contributor Author

rt4914 commented Nov 29, 2019

On itemSelection answers it is looking like this.

Screenshot_20191129-155130

Great catch. Then I believe this change won't fix the issue. I will close this PR for now. I was just giving it a quick try.

@rt4914 rt4914 closed this Nov 29, 2019
@rt4914 rt4914 deleted the bullet-fix branch November 29, 2019 10:25
@veena14cs
Copy link
Contributor

On itemSelection answers it is looking like this.

Screenshot_20191129-155130

We can check ULTagHandler to take care of this tags. I had tried using this but it giving me spacing problem. I think you can figure it out if you try.

@rt4914
Copy link
Contributor Author

rt4914 commented Nov 29, 2019

On itemSelection answers it is looking like this.
Screenshot_20191129-155130

We can check ULTagHandler to take care of this tags. I had tried using this but it giving me spacing problem. I think you can figure it out if you try.

Can you just create a PR with whatever you tried and based on that I will try to fix that.

@veena14cs
Copy link
Contributor

On itemSelection answers it is looking like this.
Screenshot_20191129-155130

We can check ULTagHandler to take care of this tags. I had tried using this but it giving me spacing problem. I think you can figure it out if you try.

Can you just create a PR with whatever you tried and based on that I will try to fix that.

Sure I can do that.

@veena14cs
Copy link
Contributor

Duplicate of this PR is created here

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants