Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixes Part of #4195 : Dark mode implementation - Content and Feedback for Questions and Exploration #4824

Merged
merged 7 commits into from
Jan 7, 2023
Merged

Fixes Part of #4195 : Dark mode implementation - Content and Feedback for Questions and Exploration #4824

merged 7 commits into from
Jan 7, 2023

Conversation

MohitGupta121
Copy link
Member

@MohitGupta121 MohitGupta121 commented Jan 6, 2023

Explanation

Fixes Part of #4195 : Dark mode implementation - Content and Feedback for Questions and Exploration

Essential Checklist

  • The PR title and explanation each start with "Fix #bugnum: " (If this PR fixes part of an issue, prefix the title with "Fix part of #bugnum: ...".)
  • Any changes to scripts/assets files have their rationale included in the PR explanation.
  • The PR follows the style guide.
  • The PR does not contain any unnecessary code changes from Android Studio (reference).
  • The PR is made from a branch that's not called "develop" and is up-to-date with "develop".
  • The PR is assigned to the appropriate reviewers (reference).

For UI-specific PRs only

Content and Feedbacks

If your PR includes UI-related changes, then:

  • Add screenshots for portrait/landscape for both a tablet & phone of the before & after UI changes
  • For the screenshots above, include both English and pseudo-localized (RTL) screenshots (see RTL guide)
  • Add a video showing the full UX flow with a screen reader enabled (see accessibility guide)
  • Add a screenshot demonstrating that you ran affected Espresso tests locally & that they're passing

@github-actions
Copy link

github-actions bot commented Jan 6, 2023

Thanks for submitting this pull request! Some main reviewers
have taken time off for the next few weeks, so it may take a
little while before we can look at this PR. We appreciate your
patience while some of our team members recharge. We'll be fully
returning on 10 January 2022.

Copy link
Member Author

@MohitGupta121 MohitGupta121 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@rt4914 PTAL, can you please review this PR.

Copy link
Contributor

@rt4914 rt4914 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@MohitGupta121 Please generate screenshots for question player too.

Also, link this issue with correct issue number.

@rt4914 rt4914 assigned MohitGupta121 and unassigned rt4914 Jan 6, 2023
Copy link
Contributor

@rt4914 rt4914 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Also add android:textColorLink to all these TextViews as they might contain some internal hyperlink.

@MohitGupta121 MohitGupta121 changed the title Dark mode implementation - Content and Feedback Questions and Exploration Fixes Part of #4195 : Dark mode implementation - Content and Feedback Questions and Exploration Jan 6, 2023
Copy link
Member Author

@MohitGupta121 MohitGupta121 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@rt4914 PTAL, Done review changes.

@MohitGupta121 MohitGupta121 assigned rt4914 and unassigned MohitGupta121 Jan 6, 2023
@MohitGupta121 MohitGupta121 requested a review from rt4914 January 6, 2023 16:41
Copy link
Contributor

@rt4914 rt4914 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, Thanks.

@rt4914 rt4914 merged commit c1d63dd into oppia:develop Jan 7, 2023
@MohitGupta121 MohitGupta121 deleted the dark-mode-content-feedback branch January 7, 2023 08:44
@MohitGupta121 MohitGupta121 changed the title Fixes Part of #4195 : Dark mode implementation - Content and Feedback Questions and Exploration Fixes Part of #4195 : Dark mode implementation - Content and Feedback for Questions and Exploration Jan 7, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants