-
Notifications
You must be signed in to change notification settings - Fork 528
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Dark mode implementation - Developer Options #4815
Dark mode implementation - Developer Options #4815
Conversation
Thanks for submitting this pull request! Some main reviewers |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@rt4914 can you PTAL on this PR.
I removed the checkbox (colors and drawables) used by developer options and used the shared_checkbox
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@MohitGupta121 Suggestion
The light mode mock for Developer Options
should look similar to that of Mark Chapters Completed
.
Okay |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@rt4914 PTAL,
Is this Light Mode UI is fine for Developer Options?
Thanks.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, Thanks.
Explanation
Dark mode implementation - Developer Options
Essential Checklist
For UI-specific PRs only
Developer Options
Mark Chapters Completed
Mark Stories Completed
Mark Topics Completed
Events Logs
Force Network Type
Math Expressions/Equations
If your PR includes UI-related changes, then: