Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Dark mode implementation - Developer Options #4815

Merged
merged 58 commits into from
Jan 1, 2023
Merged

Dark mode implementation - Developer Options #4815

merged 58 commits into from
Jan 1, 2023

Conversation

MohitGupta121
Copy link
Member

@MohitGupta121 MohitGupta121 commented Dec 31, 2022

Explanation

Dark mode implementation - Developer Options

Essential Checklist

  • The PR title and explanation each start with "Fix #bugnum: " (If this PR fixes part of an issue, prefix the title with "Fix part of #bugnum: ...".)
  • Any changes to scripts/assets files have their rationale included in the PR explanation.
  • The PR follows the style guide.
  • The PR does not contain any unnecessary code changes from Android Studio (reference).
  • The PR is made from a branch that's not called "develop" and is up-to-date with "develop".
  • The PR is assigned to the appropriate reviewers (reference).

For UI-specific PRs only

Developer Options

Mark Chapters Completed

Mark Stories Completed

Mark Topics Completed

Events Logs

Force Network Type

Math Expressions/Equations

If your PR includes UI-related changes, then:

  • Add screenshots for portrait/landscape for both a tablet & phone of the before & after UI changes
  • For the screenshots above, include both English and pseudo-localized (RTL) screenshots (see RTL guide)
  • Add a video showing the full UX flow with a screen reader enabled (see accessibility guide)
  • Add a screenshot demonstrating that you ran affected Espresso tests locally & that they're passing

MohitGupta121 and others added 30 commits May 25, 2022 12:47
@github-actions
Copy link

Thanks for submitting this pull request! Some main reviewers
have taken time off for the next few weeks, so it may take a
little while before we can look at this PR. We appreciate your
patience while some of our team members recharge. We'll be fully
returning on 10 January 2022.

Copy link
Member Author

@MohitGupta121 MohitGupta121 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@rt4914 can you PTAL on this PR.

I removed the checkbox (colors and drawables) used by developer options and used the shared_checkbox

Copy link
Contributor

@rt4914 rt4914 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@MohitGupta121 Suggestion

The light mode mock for Developer Options should look similar to that of Mark Chapters Completed.

@rt4914 rt4914 assigned MohitGupta121 and unassigned rt4914 Dec 31, 2022
@MohitGupta121
Copy link
Member Author

@MohitGupta121 Suggestion

The light mode mock for Developer Options should look similar to that of Mark Chapters Completed.

Okay

Copy link
Member Author

@MohitGupta121 MohitGupta121 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@rt4914 PTAL,
Is this Light Mode UI is fine for Developer Options?
Thanks.

@MohitGupta121 MohitGupta121 requested a review from rt4914 December 31, 2022 15:48
Copy link
Contributor

@rt4914 rt4914 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, Thanks.

@rt4914 rt4914 merged commit 318024d into oppia:develop Jan 1, 2023
@MohitGupta121 MohitGupta121 deleted the dark-mode-implementation-12 branch January 1, 2023 15:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants