Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix #478:Image is cut off in learner's answer. #479

Merged
merged 2 commits into from
Nov 28, 2019
Merged

Fix #478:Image is cut off in learner's answer. #479

merged 2 commits into from
Nov 28, 2019

Conversation

veena14cs
Copy link
Contributor

Explanation

This PR fixed image alignment.

image

@rt4914
Copy link
Contributor

rt4914 commented Nov 27, 2019

@veena14cs Please check this, image is not even visible

The issue is in develop itself, but still needs solution, meanwhile I am also checking this.

Screenshot_1574855775

rt4914
rt4914 reviewed Nov 27, 2019
View reviewed changes
Copy link
Contributor

@rt4914 rt4914 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

PTAL

@rt4914 rt4914 assigned veena14cs and unassigned rt4914 Nov 27, 2019
rt4914
rt4914 approved these changes Nov 27, 2019
View reviewed changes
Copy link
Contributor

@rt4914 rt4914 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I am approving this, if you wish to check the problem mentioned in some other issue, then file it on github and merge this.

@veena14cs
Copy link
Contributor Author

I am approving this, if you wish to check the problem mentioned in some other issue, then file it on github and merge this.

I will check this if I can fix in the same PR.

@veena14cs
Copy link
Contributor Author

I am approving this, if you wish to check the problem mentioned in some other issue, then file it on github and merge this.

I think it took time to load the image on your phone.

Screenshot_20191127-185020

@rt4914
Copy link
Contributor

rt4914 commented Nov 28, 2019

This PR is not related to the issue that I was pointing out, so better just merge this and I will file an issue for that.

@veena14cs
Copy link
Contributor Author

This PR is not related to the issue that I was pointing out, so better just merge this and I will file an issue for that.

Okay got it.

@veena14cs veena14cs merged commit 7d3d130 into develop Nov 28, 2019
@veena14cs veena14cs deleted the image-alignment-fix branch November 28, 2019 06:11
@BenHenning
Copy link
Member

@veena14cs why did we change text justification for the answer to right? I think that's causing the bullet list items to look wrong, and I don't think that's what we want to do per the mocks. It also causes paragraph wrapping to look wrong:

image

Filed #499 to track this.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rt4914 rt4914 rt4914 approved these changes

@nikitamarysolomanpvt nikitamarysolomanpvt Awaiting requested review from nikitamarysolomanpvt

Assignees

@veena14cs veena14cs

@nikitamarysolomanpvt nikitamarysolomanpvt

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@veena14cs @rt4914 @BenHenning @nikitamarysolomanpvt