-
Notifications
You must be signed in to change notification settings - Fork 531
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix #4684: Revert (most of) #4587 #4686
Conversation
/cc @vrajdesai78 |
One was an incorrect manual fix during reversion, and the other is keeping a fix from the original PR that would otherwise cuase an existing test suite to fail.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Just one note? Otherwise LGTM
@BenHenning I am good with the revert of changes related to thumbnail image. I have made that change previously because accessibility scanner is giving a suggestion to improve scaling with "Fixed witdh" |
Thanks @seanlip! Enabling auto-merge for once CI finishes. @vrajdesai78 we'll need to find a way to satisfy the constraints such that it doesn't break the app (wrap_content isn't the correct thing to do here). |
Ah forgot that I need to force-merge since technically this requires @rt4914's codeowners approval. |
Explanation
Fixes #4684
This PR reverts #4587. I think the change of match_parent to wraps_content caused the promoted story container to grow for larger images, and this wasn't caught until we tried the changes with production assets. I noticed other places in the PR that might have the same issue, so rather than trying to make sense of everything in order to properly fix it & add tests, I opted to revert the change since the regression is beta-blocking (even though it wasn't a clean reversion and required manual changes).
Note that the reversion includes keeping the changes to recently_played_fragment since otherwise changes in RecentlyPlayedFragmentTest fail, and the change seems unlikely to cause any problems with respect to potential thumbnail sizing issues.
Essential Checklist
For UI-specific PRs only
There's not much to show here--see the issue for context on the problem. The post-reversion just reverts things back to their previous state (i.e. no regression).