-
Notifications
You must be signed in to change notification settings - Fork 528
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fixes #3906: Incorrect output for rich text in hints and solution #4666
Fixes #3906: Incorrect output for rich text in hints and solution #4666
Conversation
…into Incorrect-output-for-rich-text-in-Hints-and-Solution
@BenHenning @rt4914 CI checks are failing due to some flaky tests. Can you re-run it. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks @vrajdesai78. Just had one follow-up comment--PTAL.
app/src/sharedTest/java/org/oppia/android/app/player/exploration/ExplorationActivityTest.kt
Outdated
Show resolved
Hide resolved
@BenHenning replied to your comment, also can you please re-run CI checks. Thanks |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks @vrajdesai78! This LGTM. Just waiting on CI.
Unassigning @BenHenning since they have already approved the PR. |
CI is looking good, so I have no other concerns here. I think you just need @rt4914's approval at this point. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Currently the hint-content and "Hint 1", show/hide
all these are getting read-at-once.
Instead the hint-content, ie., Remember ....
should be entirely separate from other things like Hint 1
and show/hide
Thanks @rt4914, I have updated code according to your suggestion. Also, updated video in the description. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@vrajdesai78 Suggested some more changes based on the current output.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, Thanks.
Explanation
Fixes #3906: Fixed the overall accessibility of Hints and Solution as follows:
Essential Checklist
Video for Hints
hints.mp4
Video for Solution
solution.mp4