Fix #4644 : Fixes not building for m1 Mac #4653
Conversation
There was a problem hiding this comment.
Thanks @antonmagnus. It looks like CI is failing, and I think it's because of the local.properties reference (which I suspect won't work for a few reasons). PTAL at my in-file comment for more specifics.
| artifact = "com.google.protobuf:protoc:3.8.0" | ||
| } | ||
| Properties properties = new Properties() | ||
| properties.load(project.rootProject.file("local.properties").newDataInputStream()) |
There was a problem hiding this comment.
The project doesn't have a local.properties--is this something just on your local machine?
Also, we need to set this up such that it will work for other team members without them needing to set up their own local.properties (otherwise, it's really likely people will get stuck since it won't be clear that they need to do that).
Could we use a different approach?
|
Hi @antonmagnus, I'm going to mark this PR as stale because it hasn't had any updates for 7 days. If no further activity occurs within 7 days, it will be automatically closed so that others can take up the issue. |
oppiabot
bot
added
the
stale
Fixes #4644
In the build Gradle model file the variable is fetched from root project variables and not from the local.properties.
Now it instead fetches from the local.properties where it was saved with the build script.
Remains to be tested before on in other environments before merging.