-
Notifications
You must be signed in to change notification settings - Fork 528
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix #4602, #4449: Modify the design of the chapter list in lessons tab #4605
Fix #4602, #4449: Modify the design of the chapter list in lessons tab #4605
Conversation
…apter list by default
PTAL @BenHenning |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks @JishnuGoyal. I needed to re-run one workflow due to a timeout, so waiting to see if that passes.
Otherwise, the PR LGTM for code, but for the description and title can you please:
- Make sure to use the original title, but update it to include both issues being fixed
- Make sure to use the original description, but include a new part where you mention the regression & what was specifically changed compared to the original PR (which should be linked) to make it clear what was fixed?
Thanks, @BenHenning. PTAL and let me know if further context should be added. |
Unassigning @JishnuGoyal since a re-review was requested. @JishnuGoyal, please make sure you have addressed all review comments. Thanks! |
@BenHenning could this be merged? PTAL, thanks! |
As mentioned over chat, please update the PR to properly include the changes and assign back @JishnuGoyal. |
I'm closing this PR since this has undergone a lot of changes and reversion attempts, and is only going to be difficult to review. |
Explanation
Fixes #4602
Fixes #4449
In response to the revert commit in #4603, this PR aims to remove an extra resource entry whose collision with the original PR resulted in a breakdown. This PR should also close #4449.
The original PR (which should be referred to for any context on this issue) aims to change the look of the recycler view adapter items on the topic lessons tab.
Now there are different looking item view holders for completed, in-progress, locked and not-started chapter which results in a clear CTA for the users, and they are more likely to click on the correct option. Link to the UI mock: https://xd.adobe.com/view/3dca36c2-5115-419c-b25e-0f10526b077c-6899/screen/558af437-bec4-4719-8d30-291da10bbc9d/specs/
Essential Checklist
For UI-specific PRs only
If your PR includes UI-related changes, then: