Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix #4413: Update placeholder launcher icon #4576

Merged
merged 1 commit into from
Sep 9, 2022
Merged

Conversation

BenHenning
Copy link
Member

@BenHenning BenHenning commented Sep 9, 2022

Explanation

Fixes #4413

This PR updates the placeholder launcher icon with something that better fits the adaptive icon expectations.

Note that this PR is removing the rounded icon per the advice of the adaptive icon support page (that it should be preferred not to be used unless necessary), and it's removing the play store icon since it shouldn't be needed. It's also inverting the colors of the icon since that seems to be less visually jarring for the circle-in-circle icon cases.

Note that this PR is introducing more binary files to the history, but they're small. Longer term we can look into rendering these PNGs during build time, but it's not an option right now.

Essential Checklist

  • The PR title and explanation each start with "Fix #bugnum: " (If this PR fixes part of an issue, prefix the title with "Fix part of #bugnum: ...".)
  • Any changes to scripts/assets files have their rationale included in the PR explanation.
  • The PR follows the style guide.
  • The PR does not contain any unnecessary code changes from Android Studio (reference).
  • The PR is made from a branch that's not called "develop" and is up-to-date with "develop".
  • The PR is assigned to the appropriate reviewers (reference).

For UI-specific PRs only

This section will be filled in post-merge (#4567 is tracking ensuring that the description is finished later).

@BenHenning BenHenning self-assigned this Sep 9, 2022
@BenHenning BenHenning marked this pull request as ready for review September 9, 2022 13:19
@BenHenning BenHenning requested a review from rt4914 as a code owner September 9, 2022 13:19
Copy link
Member Author

@BenHenning BenHenning left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I've self-reviewed this and haven't found anything of concern.

@BenHenning
Copy link
Member Author

Since this PR is part of broader urgent work for the Beta MR1 release, I'm force-merging this without review. I've self-reviewed it and found no major issues. Furthermore, #4567 is tracking ensuring that this does get reviewed by someone else later after it's been merged.

@BenHenning BenHenning merged commit 9303af9 into develop Sep 9, 2022
@BenHenning BenHenning deleted the update-app-icon branch September 9, 2022 14:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Update Oppia logo (app icon) for beta
1 participant