Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fixes #3892: Locked chapter item selection change is incorrect #4573

Merged
merged 2 commits into from
Sep 12, 2022
Merged

Fixes #3892: Locked chapter item selection change is incorrect #4573

merged 2 commits into from
Sep 12, 2022

Conversation

vrajdesai78
Copy link
Contributor

@vrajdesai78 vrajdesai78 commented Sep 8, 2022 •
edited
Loading

Explanation

Fixes #3892: Changes UX for users with visual imparity such that if screen reader is turned on, link will be disabled.

  • Link will be disabled when screen reader is turned on so that when someone clicks on locked chapter summary, it won't redirect user to previous unlocked chapter (when screen reader is turned on)

Essential Checklist

  • The PR title and explanation each start with "Fix #bugnum: " (If this PR fixes part of an issue, prefix the title with "Fix part of #bugnum: ...".)
  • Any changes to scripts/assets files have their rationale included in the PR explanation.
  • The PR follows the style guide.
  • The PR does not contain any unnecessary code changes from Android Studio (reference).
  • The PR is made from a branch that's not called "develop" and is up-to-date with "develop".
  • The PR is assigned to the appropriate reviewers (reference).

UI after changes

locked.mp4

@vrajdesai78 vrajdesai78 requested a review from rt4914 as a code owner September 8, 2022 16:46
rt4914
rt4914 approved these changes Sep 12, 2022
View reviewed changes
Copy link
Contributor

@rt4914 rt4914 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, Thanks.

@rt4914 rt4914 merged commit ad52087 into oppia:develop Sep 12, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rt4914 rt4914 rt4914 approved these changes

Assignees

@rt4914 rt4914

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[A11Y] Locked chapter item selection change is incorrect
2 participants
@vrajdesai78 @rt4914