Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix #4546: ListItemLeadingMarginSpanTest moved to shared test #4552

Merged
merged 152 commits into from
Sep 5, 2022

Conversation

veena14cs
Copy link
Contributor

@veena14cs veena14cs commented Sep 3, 2022

Fix #4552

Explanation

This PR fixes #4552. ListItemLeadingMarginSpanLocalTest is moved under shared test as it requires to support shadows.

Essential Checklist

  • The PR title and explanation each start with "Fix #bugnum: " (If this PR fixes part of an issue, prefix the title with "Fix part of #bugnum: ...".)
  • Any changes to scripts/assets files have their rationale included in the PR explanation.
  • The PR follows the style guide.
  • The PR does not contain any unnecessary code changes from Android Studio (reference).
  • The PR is made from a branch that's not called "develop" and is up-to-date with "develop".
  • The PR is assigned to the appropriate reviewers (reference).

veena14cs added 30 commits June 20, 2021 16:54
veena14cs added 23 commits May 24, 2022 00:11
Copy link
Member

@BenHenning BenHenning left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @veena14cs! This LGTM.

@BenHenning BenHenning merged commit a7a8c33 into oppia:develop Sep 5, 2022
@veena14cs veena14cs deleted the fix-list-test branch September 5, 2022 10:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

ListItemLeadingMarginSpanTest is broken when built with Espresso
2 participants