Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixes #3712: Add accessibility support for ImageRegionSelectionInteraction [Removed Todo followed by #4497] #4543

Merged
merged 10 commits into from
Oct 5, 2022
Merged

Fixes #3712: Add accessibility support for ImageRegionSelectionInteraction [Removed Todo followed by #4497] #4543

Changes from all commits
Commits
Show all changes
10 commits
Select commit Hold shift + click to select a range
11af72b
content description added
vrajdesai78 Aug 6, 2022
79f693d
tests updated
vrajdesai78 Aug 6, 2022
99a24a2
KDoc and comment added
vrajdesai78 Aug 8, 2022
ce83d64
textproto updated
vrajdesai78 Aug 19, 2022
1bd9183
kdoc comment updated
vrajdesai78 Aug 26, 2022
84b0e36
@param changed to @property in kdoc
vrajdesai78 Aug 29, 2022
14c688c
TODO removed
vrajdesai78 Aug 30, 2022
768d0b4
Merge branch 'develop' into Add-accessibility-for-ImageRegionSelectio…
vrajdesai78 Aug 30, 2022
80019dd
Merge branch 'develop' into Add-accessibility-for-ImageRegionSelectio…
vrajdesai78 Sep 2, 2022
16439d6
Updated issue number in ToDo
vrajdesai78 Oct 4, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion ...mentation/src/javatests/org/oppia/android/instrumentation/player/ExplorationPlayerTest.kt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -58,7 +58,7 @@ class ExplorationPlayerTest {
// Image Region Selection Interaction.
val imageSelectionView = device.findObjectByRes("interaction_container_frame_layout")
device.waitForRes("image_click_interaction_image_view")
// TODO(#3712): Use content description to fetch the image region.
BenHenning marked this conversation as resolved.
Show resolved Hide resolved
// TODO(#4639): Use content description to fetch the image region.
imageSelectionView.children.get(2).click()
device.findObjectByText("SUBMIT").click()
device.findObjectByText("CONTINUE").click()
Expand Down