Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix #4006: Hide Edit Accounts option from AdministratorControls #4523

Merged
merged 1 commit into from
Aug 24, 2022

Conversation

JishnuGoyal
Copy link
Contributor

Explanation

This PR changes the value of editAccountsOptionsUi feature flag to false which was mistakenly turned true.

Essential Checklist

  • The PR title and explanation each start with "Fix #bugnum: " (If this PR fixes part of an issue, prefix the title with "Fix part of #bugnum: ...".)
  • Any changes to scripts/assets files have their rationale included in the PR explanation.
  • The PR follows the style guide.
  • The PR does not contain any unnecessary code changes from Android Studio (reference).
  • The PR is made from a branch that's not called "develop" and is up-to-date with "develop".
  • The PR is assigned to the appropriate reviewers (reference).

@JishnuGoyal
Copy link
Contributor Author

PTAL @BenHenning

@JishnuGoyal
Copy link
Contributor Author

@BenHenning Could this be re-run? This test passes on my machine.

Copy link
Member

@BenHenning BenHenning left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @JishnuGoyal!

Copy link
Member

@BenHenning BenHenning left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ah, actually it looks like per CI there is now a failing test. PTAL.

@BenHenning BenHenning assigned JishnuGoyal and unassigned BenHenning Aug 24, 2022
Copy link
Member

@BenHenning BenHenning left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ah I see the test is unrelated and thus likely a flake. It's the first time I've seen that particular flake, so I'm a bit surprised. Enabling auto-merge for when it finishes. Thanks @JishnuGoyal!

@BenHenning BenHenning enabled auto-merge (squash) August 24, 2022 07:28
@oppiabot oppiabot bot added the PR: LGTM label Aug 24, 2022
@BenHenning BenHenning merged commit ca39ac6 into oppia:develop Aug 24, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants