Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix #425: Update fraction rule parsing to use non-negative int instead of double #450

Merged
merged 2 commits into from
Nov 26, 2019
Merged

Fix #425: Update fraction rule parsing to use non-negative int instead of double #450

Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
2b53df1
Update fraction rule parsing to use non-negative int instead of double.
BenHenning Nov 20, 2019
e6090d4
Address reviewer comment.
BenHenning Nov 26, 2019
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion domain/src/main/java/org/oppia/domain/util/StateRetriever.kt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -184,7 +184,7 @@ class StateRetriever @Inject constructor(
"HasDenominatorEqualTo", "HasNumeratorEqualTo" -> ruleSpecBuilder.putInput(
inputName,
InteractionObject.newBuilder()
.setReal(inputsJson.getDouble(inputName))
.setNonNegativeInt(inputsJson.getInt(inputName))
BenHenning marked this conversation as resolved.
Show resolved Hide resolved
.build()
)
else -> ruleSpecBuilder.putInput(inputName, createExactInputFromJson(inputsJson, inputName, interactionId))
Expand Down