Update CODEOWNERS to consolidate test-related ownership #4434
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Remove anandwana001 from codeowners.
Correct instrumentation codeowner pattern. This is needed now that broad test ownership is no longer defined.
|
@seanlip PTAL for codeowners. |
seanlip
approved these changes
Jul 15, 2022
|
Hi @BenHenning, this PR is ready to be merged. Please address any remaining comments prior to merging, and feel free to merge this PR once the CI checks pass and you're happy with it. Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Explanation
This PR removes @anandwana001 from CODEOWNERS since he hasn't been active lately. I also removed the broad test codeownership. I think we've matured enough as a team for domain codeowners to own their respective tests (particularly because we can enforce code-wide patterns using CI-run static analysis scripts).
Essential Checklist
The PR title and explanation each start with "Fix #bugnum: " (If this PR fixes part of an issue, prefix the title with "Fix part of #bugnum: ...".)-- N/AFor UI-specific PRs only
N/A -- This PR is only changing codeowners and does not affect the app directly.