Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix part of #4044: Add KotliTeX integration (direct LaTeX rendering) #4068

Merged
Merged
Show file tree
Hide file tree
Changes from 250 commits
Commits
Show all changes
345 commits
Select commit Hold shift + click to select a range
8ead9bf
Add KDocs & test exemptions.
BenHenning Jan 25, 2022
aeec35c
Lint fixes.
BenHenning Jan 25, 2022
57e6f5b
Remove temporary TODOs.
BenHenning Jan 25, 2022
10eac78
Merge branch 'add-support-for-math-expressions-pt7-math-expression-pa…
BenHenning Jan 25, 2022
07be596
Add tests.
BenHenning Jan 26, 2022
19a6425
Split StringToFractionParser.
BenHenning Jan 26, 2022
444d3d0
Merge branch 'develop' into add-support-for-math-expressions-pt1-fix-…
BenHenning Jan 26, 2022
cb5c5d1
Merge branch 'add-support-for-math-expressions-pt1-fix-proto-imports'…
BenHenning Jan 27, 2022
7a364c3
Address reviewer comments + other stuff.
BenHenning Jan 27, 2022
2c0b9cd
Merge branch 'add-support-for-math-expressions-pt2-math-utility-refac…
BenHenning Jan 27, 2022
4364d7f
Merge branch 'add-support-for-math-expressions-pt3-math-expression-pr…
BenHenning Jan 27, 2022
cfe6cab
Move StringExtensions & fraction parsing.
BenHenning Jan 27, 2022
5e83a33
Merge branch 'add-support-for-math-expressions-pt2-math-utility-refac…
BenHenning Jan 27, 2022
c6cf5f5
Merge branch 'add-support-for-math-expressions-pt3-math-expression-pr…
BenHenning Jan 27, 2022
73dccd8
Address reviewer comments.
BenHenning Jan 27, 2022
b7535fa
Alphabetize test exemptions.
BenHenning Jan 27, 2022
f4cd6cd
Merge branch 'add-support-for-math-expressions-pt4-commutative-compar…
BenHenning Jan 27, 2022
574ebb8
Merge branch 'add-support-for-math-expressions-pt5-polynomial-protos'…
BenHenning Jan 27, 2022
a00164c
Fix typo & add regex check.
BenHenning Jan 27, 2022
0287f19
Add missing KDocs.
BenHenning Jan 27, 2022
75103d5
Merge branch 'add-support-for-math-expressions-pt2-math-utility-refac…
BenHenning Jan 27, 2022
52d2605
Merge branch 'add-support-for-math-expressions-pt3-math-expression-pr…
BenHenning Jan 27, 2022
37dbc85
Merge branch 'add-support-for-math-expressions-pt4-commutative-compar…
BenHenning Jan 27, 2022
385d2d3
Merge branch 'add-support-for-math-expressions-pt5-polynomial-protos'…
BenHenning Jan 27, 2022
4bacc8a
Merge branch 'add-support-for-math-expressions-pt6-tokenizer' into ad…
BenHenning Jan 27, 2022
1e5279d
Post-merge cleanups.
BenHenning Jan 27, 2022
bbf7e2d
Add new test for negation with math symbol.
BenHenning Jan 27, 2022
cf72c8d
Merge branch 'add-support-for-math-expressions-pt7-math-expression-pa…
BenHenning Jan 27, 2022
ba4128c
Post-merge fixes.
BenHenning Jan 27, 2022
fd09758
Add KDocs.
BenHenning Jan 27, 2022
01c2326
Refactor & simplify real ext impl.
BenHenning Jan 27, 2022
98d6939
Lint fixes.
BenHenning Jan 28, 2022
928aa6f
Merge branch 'add-support-for-math-expressions-pt8-latex-conversion-a…
BenHenning Jan 28, 2022
ca412f7
Simplify operation list converter a lot.
BenHenning Jan 28, 2022
f172bcf
Prepare for new tests.
BenHenning Jan 28, 2022
65a9fe1
Remove the ComparableOperationList wrapper.
BenHenning Jan 28, 2022
fa4de34
Merge branch 'add-support-for-math-expressions-pt4-commutative-compar…
BenHenning Jan 28, 2022
e2d226f
Merge branch 'add-support-for-math-expressions-pt5-polynomial-protos'…
BenHenning Jan 28, 2022
fbd935c
Change parameterized method delimiter.
BenHenning Jan 28, 2022
5b6d1f2
Merge branch 'add-support-for-math-expressions-pt6-tokenizer' into ad…
BenHenning Jan 28, 2022
fd11a79
Merge branch 'add-support-for-math-expressions-pt7-math-expression-pa…
BenHenning Jan 28, 2022
8420c56
Use utility directly in test.
BenHenning Jan 28, 2022
047645c
Merge branch 'add-support-for-math-expressions-pt8-latex-conversion-a…
BenHenning Jan 28, 2022
b8a3e2e
Post-merge fixes.
BenHenning Jan 28, 2022
28811b3
Add first round of tests.
BenHenning Jan 28, 2022
b400176
Finish initial test suite.
BenHenning Jan 29, 2022
e6c09d8
Simplify operation sorting comparators.
BenHenning Jan 29, 2022
bebc100
Remove old tests.
BenHenning Jan 29, 2022
3cecc6c
Add remaining missing tests.
BenHenning Jan 29, 2022
573fee9
KDocs & test exemption.
BenHenning Jan 29, 2022
1970f34
Renames & lint fixes.
BenHenning Jan 29, 2022
f5abb4d
Merge branch 'add-support-for-math-expressions-pt9-commutative-compar…
BenHenning Jan 29, 2022
45b6099
Post-merge fixes.
BenHenning Jan 29, 2022
76a7887
Add tests.
BenHenning Feb 2, 2022
06ba279
KDocs + exemptions.
BenHenning Feb 2, 2022
ad3091d
Lint fixes.
BenHenning Feb 2, 2022
576d7dc
Merge branch 'add-support-for-math-expressions-pt10-polynomials' into…
BenHenning Feb 2, 2022
b8ce188
Post-merge fixes.
BenHenning Feb 2, 2022
468b565
Add extension tests.
BenHenning Feb 4, 2022
4030aa3
Add classifier tests.
BenHenning Feb 4, 2022
d20256c
Use more intentional epsilons for float comparing.
BenHenning Feb 4, 2022
cdaf778
Merge branch 'add-support-for-math-expressions-pt5-polynomial-protos'…
BenHenning Feb 4, 2022
7e97d0b
Treat en-dash as a subtraction symbol.
BenHenning Feb 4, 2022
a9c68b1
Add explicit platform selection for paramerized.
BenHenning Feb 5, 2022
a273ee6
Exemption fixes.
BenHenning Feb 5, 2022
924214d
Merge branch 'develop' into add-support-for-math-expressions-pt1-fix-…
BenHenning Feb 5, 2022
686c4b6
Merge branch 'add-support-for-math-expressions-pt1-fix-proto-imports'…
BenHenning Feb 5, 2022
1a3cba5
Merge branch 'add-support-for-math-expressions-pt2-math-utility-refac…
BenHenning Feb 5, 2022
bff824e
Merge branch 'add-support-for-math-expressions-pt3-math-expression-pr…
BenHenning Feb 5, 2022
90b05bf
Merge branch 'add-support-for-math-expressions-pt4-commutative-compar…
BenHenning Feb 5, 2022
09e2aad
Remove failing test.
BenHenning Feb 5, 2022
c7c2e4b
Merge branch 'add-support-for-math-expressions-pt5-polynomial-protos'…
BenHenning Feb 5, 2022
8bdf183
Merge branch 'add-support-for-math-expressions-pt6-tokenizer' into ad…
BenHenning Feb 5, 2022
b48d06a
Fix unary expression precedence.
BenHenning Feb 5, 2022
8ac22cb
Fixes & add more test cases.
BenHenning Feb 5, 2022
cdee008
Merge branch 'add-support-for-math-expressions-pt7-math-expression-pa…
BenHenning Feb 5, 2022
476e604
Post-merge fixes & test changes.
BenHenning Feb 5, 2022
5ed0013
Use utility directly in LaTeX tests.
BenHenning Feb 5, 2022
370dcf6
Merge branch 'add-support-for-math-expressions-pt8-latex-conversion-a…
BenHenning Feb 5, 2022
c16db64
Post-merge fixes.
BenHenning Feb 5, 2022
df4221f
Merge branch 'add-support-for-math-expressions-pt9-commutative-compar…
BenHenning Feb 5, 2022
dab330e
Post-merge fixes.
BenHenning Feb 5, 2022
7567232
Merge branch 'add-support-for-math-expressions-pt10-polynomials' into…
BenHenning Feb 5, 2022
9c70c31
Post-merge fixes.
BenHenning Feb 5, 2022
3248e84
Lint & other check fixes.
BenHenning Feb 5, 2022
43cc4e0
Merge branch 'add-support-for-math-expressions-pt11-numeric-expressio…
BenHenning Feb 5, 2022
3960220
Replace deprecated term.
BenHenning Feb 5, 2022
528e9f7
Merge branch 'add-support-for-math-expressions-pt11-numeric-expressio…
BenHenning Feb 5, 2022
f7ec751
Post-merge fixes.
BenHenning Feb 5, 2022
782e058
Add full test suites for alg exp classifiers.
BenHenning Feb 5, 2022
0a7cb69
Lint & static check fixes.
BenHenning Feb 5, 2022
fd0c0cc
Fix test on Gradle.
BenHenning Feb 5, 2022
2839e7b
Merge branch 'add-support-for-math-expressions-pt11-numeric-expressio…
BenHenning Feb 5, 2022
812b66e
Fix test for Gradle.
BenHenning Feb 5, 2022
5035277
Merge branch 'add-support-for-math-expressions-pt12-algebraic-express…
BenHenning Feb 5, 2022
d811636
Add tests for math equations.
BenHenning Feb 5, 2022
0c00467
Static check & lint fixes.
BenHenning Feb 5, 2022
89de734
Merge branch 'add-support-for-math-expressions-pt13-math-equation-inp…
BenHenning Feb 5, 2022
d026506
Post-merge fixes.
BenHenning Feb 5, 2022
cddd3b5
Merge branch 'add-support-for-math-expressions-pt14-enable-math-class…
BenHenning Feb 5, 2022
c4d53dd
Split up tests.
BenHenning Feb 5, 2022
15d9d25
Add missing test in Bazel, and fix it.
BenHenning Feb 7, 2022
b63883e
Correct order for genrule.
BenHenning Feb 7, 2022
8562393
Merge branch 'add-support-for-math-expressions-pt14-enable-math-class…
BenHenning Feb 7, 2022
0642757
Add full test suite.
BenHenning Feb 8, 2022
4c163bf
Clean up + KDocs + exemption.
BenHenning Feb 8, 2022
01b1832
Lint fixes.
BenHenning Feb 8, 2022
f41654f
Merge branch 'add-support-for-math-expressions-pt15-math-expression-a…
BenHenning Feb 8, 2022
0059a8d
Post-merge fix.
BenHenning Feb 8, 2022
43fbc3d
Cache KotliTeX renders.
BenHenning Feb 10, 2022
47b153e
Add tests, docs, and exemptions.
BenHenning Feb 10, 2022
0918b86
Update to fixed version of KotliTeX.
BenHenning Feb 10, 2022
6f2723d
Lint fixes.
BenHenning Feb 10, 2022
8c9cc54
Add new dependency licenses.
BenHenning Feb 10, 2022
2727235
Fix license links.
BenHenning Feb 10, 2022
6fb2c6c
Fix Gradle build.
BenHenning Feb 11, 2022
9d72168
Create the math drawable synchronously.
BenHenning Feb 11, 2022
34d90a7
Remove new deps from Maven list.
BenHenning Feb 11, 2022
551071c
Add argument partitioning.
BenHenning Feb 11, 2022
8016252
Make allowance for empty cases to fix tests.
BenHenning Feb 11, 2022
3c791e6
Lint fixes.
BenHenning Feb 11, 2022
ecc836e
Merge branch 'develop' into add-support-for-math-expressions-pt1-fix-…
BenHenning Feb 18, 2022
b183d67
Merge branch 'add-support-for-math-expressions-pt1-fix-proto-imports'…
BenHenning Feb 18, 2022
005d9a0
Merge branch 'add-support-for-math-expressions-pt2-math-utility-refac…
BenHenning Feb 18, 2022
ba198fd
Merge branch 'add-support-for-math-expressions-pt3-math-expression-pr…
BenHenning Feb 18, 2022
1f2b90d
Merge branch 'add-support-for-math-expressions-pt4-commutative-compar…
BenHenning Feb 18, 2022
86e90f7
Merge branch 'add-support-for-math-expressions-pt5-polynomial-protos'…
BenHenning Feb 18, 2022
a6dc7d4
Address reviewer comment.
BenHenning Feb 18, 2022
a6d1111
Merge branch 'add-support-for-math-expressions-pt6-tokenizer' into ad…
BenHenning Feb 18, 2022
64a1b55
Merge branch 'add-support-for-math-expressions-pt7-math-expression-pa…
BenHenning Feb 18, 2022
151e0bf
Merge branch 'add-support-for-math-expressions-pt8-latex-conversion-a…
BenHenning Feb 18, 2022
fd9ec1f
Fix broken build.
BenHenning Feb 18, 2022
960287d
Merge branch 'add-support-for-math-expressions-pt1-fix-proto-imports'…
BenHenning Feb 18, 2022
b85567e
Merge branch 'add-support-for-math-expressions-pt2-math-utility-refac…
BenHenning Feb 18, 2022
2ed67c5
Merge branch 'add-support-for-math-expressions-pt3-math-expression-pr…
BenHenning Feb 18, 2022
3744cf2
Merge branch 'add-support-for-math-expressions-pt4-commutative-compar…
BenHenning Feb 18, 2022
c57e792
Merge branch 'add-support-for-math-expressions-pt5-polynomial-protos'…
BenHenning Feb 18, 2022
056f547
Merge branch 'add-support-for-math-expressions-pt6-tokenizer' into ad…
BenHenning Feb 18, 2022
5431e27
Merge branch 'add-support-for-math-expressions-pt7-math-expression-pa…
BenHenning Feb 18, 2022
829bb16
Merge branch 'add-support-for-math-expressions-pt8-latex-conversion-a…
BenHenning Feb 18, 2022
23254ca
Merge branch 'add-support-for-math-expressions-pt9-commutative-compar…
BenHenning Feb 18, 2022
0fc8a1b
Fix broken build post-merge.
BenHenning Feb 18, 2022
e4b92e5
Merge branch 'add-support-for-math-expressions-pt2-math-utility-refac…
BenHenning Feb 18, 2022
9eb1c2d
Merge branch 'add-support-for-math-expressions-pt3-math-expression-pr…
BenHenning Feb 18, 2022
1f3fb48
Merge branch 'add-support-for-math-expressions-pt4-commutative-compar…
BenHenning Feb 18, 2022
24ac61c
Merge branch 'add-support-for-math-expressions-pt5-polynomial-protos'…
BenHenning Feb 18, 2022
c74aee0
Merge branch 'add-support-for-math-expressions-pt6-tokenizer' into ad…
BenHenning Feb 18, 2022
e814df8
Merge branch 'add-support-for-math-expressions-pt7-math-expression-pa…
BenHenning Feb 18, 2022
6df7a21
Merge branch 'add-support-for-math-expressions-pt8-latex-conversion-a…
BenHenning Feb 18, 2022
446d263
Merge branch 'add-support-for-math-expressions-pt9-commutative-compar…
BenHenning Feb 18, 2022
3cd065f
Merge branch 'add-support-for-math-expressions-pt10-polynomials' into…
BenHenning Feb 18, 2022
c59598c
Fix broken post-merge classifier.
BenHenning Feb 18, 2022
41be40e
Address reviewer comment.
BenHenning Feb 18, 2022
8070cb6
Merge branch 'add-support-for-math-expressions-pt11-numeric-expressio…
BenHenning Feb 18, 2022
1ea2241
Post-merge build fixes.
BenHenning Feb 18, 2022
6bf8006
Merge branch 'add-support-for-math-expressions-pt12-algebraic-express…
BenHenning Feb 18, 2022
3407bf4
Post-merge build fixes for new classifiers.
BenHenning Feb 18, 2022
337a195
Merge branch 'add-support-for-math-expressions-pt13-math-equation-inp…
BenHenning Feb 18, 2022
4328d56
Post-merge build fixes.
BenHenning Feb 18, 2022
7e6fc7d
Merge branch 'add-support-for-math-expressions-pt14-enable-math-class…
BenHenning Feb 18, 2022
0e9402a
Correct reference document link.
BenHenning Feb 18, 2022
f340900
Merge branch 'add-support-for-math-expressions-pt15-math-expression-a…
BenHenning Feb 18, 2022
3b7c424
Ensure LaTeX isn't stretched or cut-off.
BenHenning Feb 23, 2022
c01f939
Merge branch 'develop' into add-support-for-math-expressions-pt1-fix-…
BenHenning Feb 24, 2022
14f7057
Merge branch 'add-support-for-math-expressions-pt1-fix-proto-imports'…
BenHenning Feb 24, 2022
b98e1ec
Merge branch 'add-support-for-math-expressions-pt2-math-utility-refac…
BenHenning Feb 24, 2022
b50c40f
Merge branch 'add-support-for-math-expressions-pt3-math-expression-pr…
BenHenning Feb 24, 2022
6d0cc9e
Merge branch 'add-support-for-math-expressions-pt4-commutative-compar…
BenHenning Feb 24, 2022
2217f7d
Merge branch 'add-support-for-math-expressions-pt5-polynomial-protos'…
BenHenning Feb 24, 2022
a9adda1
Merge branch 'add-support-for-math-expressions-pt6-tokenizer' into ad…
BenHenning Feb 24, 2022
ac63847
Merge branch 'add-support-for-math-expressions-pt7-math-expression-pa…
BenHenning Feb 24, 2022
3f236cb
Merge branch 'add-support-for-math-expressions-pt8-latex-conversion-a…
BenHenning Feb 24, 2022
7a76b98
Merge branch 'add-support-for-math-expressions-pt9-commutative-compar…
BenHenning Feb 24, 2022
af86921
Merge branch 'add-support-for-math-expressions-pt10-polynomials' into…
BenHenning Feb 24, 2022
ebac9b3
Merge branch 'add-support-for-math-expressions-pt11-numeric-expressio…
BenHenning Feb 24, 2022
ba460f5
Merge branch 'add-support-for-math-expressions-pt12-algebraic-express…
BenHenning Feb 24, 2022
a2359e4
Merge branch 'add-support-for-math-expressions-pt13-math-equation-inp…
BenHenning Feb 24, 2022
db99c80
Merge branch 'add-support-for-math-expressions-pt14-enable-math-class…
BenHenning Feb 24, 2022
55949e0
Merge branch 'add-support-for-math-expressions-pt15-math-expression-a…
BenHenning Feb 24, 2022
8691e43
Add and fix missing test (was broken on Gradle).
BenHenning Feb 24, 2022
000d88d
Merge branch 'add-support-for-math-expressions-pt14-enable-math-class…
BenHenning Feb 24, 2022
fe4a92f
Merge branch 'add-support-for-math-expressions-pt15-math-expression-a…
BenHenning Feb 24, 2022
1d74aed
Merge branch 'develop' into add-support-for-math-expressions-pt1-fix-…
BenHenning Mar 7, 2022
2ae10ec
Merge branch 'add-support-for-math-expressions-pt1-fix-proto-imports'…
BenHenning Mar 7, 2022
60670a5
Merge branch 'add-support-for-math-expressions-pt2-math-utility-refac…
BenHenning Mar 7, 2022
473b562
Merge branch 'add-support-for-math-expressions-pt3-math-expression-pr…
BenHenning Mar 7, 2022
73a052f
Merge branch 'add-support-for-math-expressions-pt4-commutative-compar…
BenHenning Mar 7, 2022
e35b13f
Merge branch 'add-support-for-math-expressions-pt5-polynomial-protos'…
BenHenning Mar 7, 2022
9aa8315
Merge branch 'add-support-for-math-expressions-pt6-tokenizer' into ad…
BenHenning Mar 7, 2022
e8b8f9f
Merge branch 'add-support-for-math-expressions-pt7-math-expression-pa…
BenHenning Mar 7, 2022
a28d87f
Merge branch 'add-support-for-math-expressions-pt8-latex-conversion-a…
BenHenning Mar 7, 2022
9c7a1cb
Merge branch 'add-support-for-math-expressions-pt9-commutative-compar…
BenHenning Mar 7, 2022
3a69df4
Merge branch 'add-support-for-math-expressions-pt10-polynomials' into…
BenHenning Mar 7, 2022
a632215
Merge branch 'add-support-for-math-expressions-pt11-numeric-expressio…
BenHenning Mar 7, 2022
4c32610
Merge branch 'add-support-for-math-expressions-pt12-algebraic-express…
BenHenning Mar 7, 2022
523cdcb
Merge branch 'add-support-for-math-expressions-pt13-math-equation-inp…
BenHenning Mar 7, 2022
66ed496
Merge branch 'add-support-for-math-expressions-pt14-enable-math-class…
BenHenning Mar 7, 2022
9d1c112
Merge branch 'add-support-for-math-expressions-pt15-math-expression-a…
BenHenning Mar 7, 2022
8945c3a
Merge branch 'develop' into add-support-for-math-expressions-pt1-fix-…
BenHenning Mar 17, 2022
391cf22
Post-merge fix.
BenHenning Mar 17, 2022
7918001
Merge branch 'add-support-for-math-expressions-pt1-fix-proto-imports'…
BenHenning Mar 17, 2022
c29a47c
More post-merge fixes.
BenHenning Mar 17, 2022
19b3800
Merge branch 'add-support-for-math-expressions-pt2-math-utility-refac…
BenHenning Mar 17, 2022
aa4fd38
Merge branch 'add-support-for-math-expressions-pt3-math-expression-pr…
BenHenning Mar 17, 2022
eb2bcc3
Merge branch 'add-support-for-math-expressions-pt4-commutative-compar…
BenHenning Mar 17, 2022
8bd314f
Merge branch 'add-support-for-math-expressions-pt5-polynomial-protos'…
BenHenning Mar 17, 2022
429ee02
Merge branch 'add-support-for-math-expressions-pt6-tokenizer' into ad…
BenHenning Mar 17, 2022
445664a
Fix TODO comment.
BenHenning Mar 17, 2022
b82b158
Merge branch 'add-support-for-math-expressions-pt7-math-expression-pa…
BenHenning Mar 17, 2022
4dd551b
Merge branch 'add-support-for-math-expressions-pt8-latex-conversion-a…
BenHenning Mar 17, 2022
4b9b9ac
Merge branch 'add-support-for-math-expressions-pt9-commutative-compar…
BenHenning Mar 17, 2022
af405aa
Merge branch 'add-support-for-math-expressions-pt10-polynomials' into…
BenHenning Mar 17, 2022
5d797b0
Merge branch 'add-support-for-math-expressions-pt11-numeric-expressio…
BenHenning Mar 17, 2022
89361ed
Merge branch 'add-support-for-math-expressions-pt12-algebraic-express…
BenHenning Mar 17, 2022
2ef6688
Merge branch 'add-support-for-math-expressions-pt13-math-equation-inp…
BenHenning Mar 17, 2022
85d8933
Merge branch 'add-support-for-math-expressions-pt14-enable-math-class…
BenHenning Mar 17, 2022
f01c425
Merge branch 'add-support-for-math-expressions-pt15-math-expression-a…
BenHenning Mar 17, 2022
10081a6
Post-merge fix.
BenHenning Mar 17, 2022
2bd741a
Update KotliTeX version.
BenHenning Mar 18, 2022
52862d6
Merge branch 'develop' into add-support-for-math-expressions-pt1-fix-…
BenHenning Mar 25, 2022
cd31247
Merge branch 'develop' into add-support-for-math-expressions-pt1-fix-…
BenHenning Mar 25, 2022
4dbd838
Merge branch 'add-support-for-math-expressions-pt1-fix-proto-imports'…
BenHenning Mar 25, 2022
deabf3a
Merge branch 'develop' into add-support-for-math-expressions-pt2-math…
BenHenning Mar 26, 2022
8bd89e6
Merge branch 'add-support-for-math-expressions-pt2-math-utility-refac…
BenHenning Mar 26, 2022
06f9cfd
Merge branch 'develop' into add-support-for-math-expressions-pt3-math…
BenHenning Mar 26, 2022
a1284a1
Merge branch 'add-support-for-math-expressions-pt3-math-expression-pr…
BenHenning Mar 26, 2022
2c2328b
Merge branch 'develop' into add-support-for-math-expressions-pt4-comm…
BenHenning Mar 26, 2022
feb901b
Merge branch 'add-support-for-math-expressions-pt4-commutative-compar…
BenHenning Mar 26, 2022
783aaf0
Merge branch 'develop' into add-support-for-math-expressions-pt5-poly…
BenHenning Mar 26, 2022
7306faa
Merge branch 'add-support-for-math-expressions-pt5-polynomial-protos'…
BenHenning Mar 26, 2022
d59437c
Merge branch 'develop' into add-support-for-math-expressions-pt6-toke…
BenHenning Mar 26, 2022
be04055
Merge branch 'add-support-for-math-expressions-pt6-tokenizer' into ad…
BenHenning Mar 26, 2022
88ecf9e
Merge branch 'develop' into add-support-for-math-expressions-pt7-math…
BenHenning Mar 26, 2022
7cb991a
Merge branch 'add-support-for-math-expressions-pt7-math-expression-pa…
BenHenning Mar 26, 2022
b94f94f
Merge branch 'develop' into add-support-for-math-expressions-pt8-late…
BenHenning Mar 26, 2022
3229bae
Merge branch 'add-support-for-math-expressions-pt8-latex-conversion-a…
BenHenning Mar 26, 2022
d31a403
Merge branch 'develop' into add-support-for-math-expressions-pt9-comm…
BenHenning Mar 26, 2022
67c53ec
Merge branch 'add-support-for-math-expressions-pt9-commutative-compar…
BenHenning Mar 26, 2022
ff2df48
Merge branch 'develop' into add-support-for-math-expressions-pt10-pol…
BenHenning Mar 26, 2022
c41bda8
Merge branch 'add-support-for-math-expressions-pt10-polynomials' into…
BenHenning Mar 26, 2022
e34c52a
Merge branch 'develop' into add-support-for-math-expressions-pt11-num…
BenHenning Mar 26, 2022
78935c3
Merge branch 'add-support-for-math-expressions-pt11-numeric-expressio…
BenHenning Mar 26, 2022
9271db4
Merge branch 'develop' into add-support-for-math-expressions-pt12-alg…
BenHenning Mar 26, 2022
3c0dbff
Merge branch 'add-support-for-math-expressions-pt12-algebraic-express…
BenHenning Mar 26, 2022
d29b349
Merge branch 'develop' into add-support-for-math-expressions-pt13-mat…
BenHenning Mar 26, 2022
52de127
Merge branch 'add-support-for-math-expressions-pt13-math-equation-inp…
BenHenning Mar 26, 2022
c4beb96
Merge branch 'develop' into add-support-for-math-expressions-pt14-ena…
BenHenning Mar 27, 2022
1bf3c1a
Merge branch 'add-support-for-math-expressions-pt14-enable-math-class…
BenHenning Mar 27, 2022
b5334bc
Merge branch 'develop' into add-support-for-math-expressions-pt15-mat…
BenHenning Mar 27, 2022
429ec8d
Merge branch 'add-support-for-math-expressions-pt15-math-expression-a…
BenHenning Mar 27, 2022
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
The table of contents is too big for display.
Diff view
Diff view
  •  
  •  
  •  
9 changes: 9 additions & 0 deletions WORKSPACE
Original file line number Diff line number Diff line change
Expand Up @@ -129,6 +129,15 @@ git_repository(
remote = "https://github.com/oppia/androidsvg",
)

# A custom fork of KotliTeX that removes resources artifacts that break the build, and updates the
# min target SDK version to be compatible with Oppia.
git_repository(
name = "kotlitex",
commit = "ba51aaca442d248b7b44b4eeb5bb9846ad45b245",
remote = "https://github.com/oppia/kotlitex",
shallow_since = "1645642252 -0800",
)

bind(
name = "databinding_annotation_processor",
actual = "//tools/android:compiler_annotation_processor",
Expand Down
27 changes: 20 additions & 7 deletions app/BUILD.bazel
Original file line number Diff line number Diff line change
Expand Up @@ -189,7 +189,7 @@ VIEW_MODELS_WITH_RESOURCE_IMPORTS = [
"src/main/java/org/oppia/android/app/onboarding/OnboardingViewModel.kt",
"src/main/java/org/oppia/android/app/ongoingtopiclist/OngoingTopicItemViewModel.kt",
"src/main/java/org/oppia/android/app/options/TextSizeItemViewModel.kt",
"src/main/java/org/oppia/android/app/parser/StringToFractionParser.kt",
"src/main/java/org/oppia/android/app/parser/FractionParsingUiError.kt",
"src/main/java/org/oppia/android/app/parser/StringToNumberParser.kt",
"src/main/java/org/oppia/android/app/parser/StringToRatioParser.kt",
"src/main/java/org/oppia/android/app/player/state/itemviewmodel/DragDropInteractionContentViewModel.kt",
Expand Down Expand Up @@ -546,8 +546,8 @@ android_library(
":views",
"//app/src/main/java/org/oppia/android/app/translation:app_language_activity_injector_provider",
"//app/src/main/java/org/oppia/android/app/translation:app_language_resource_handler",
"//model:interaction_object_java_proto_lite",
"//model:thumbnail_java_proto_lite",
"//model/src/main/proto:interaction_object_java_proto_lite",
"//model/src/main/proto:thumbnail_java_proto_lite",
"//third_party:androidx_annotation_annotation",
"//third_party:androidx_constraintlayout_constraintlayout",
"//third_party:androidx_core_core",
Expand Down Expand Up @@ -578,8 +578,8 @@ kt_android_library(
deps = [
":dagger",
"//domain/src/main/java/org/oppia/android/domain/audio:cellular_audio_dialog_controller",
"//model:question_java_proto_lite",
"//model:topic_java_proto_lite",
"//model/src/main/proto:question_java_proto_lite",
"//model/src/main/proto:topic_java_proto_lite",
"//third_party:androidx_recyclerview_recyclerview",
],
)
Expand Down Expand Up @@ -658,6 +658,7 @@ kt_android_library(
"//utility/src/main/java/org/oppia/android/util/extensions:context_extensions",
"//utility/src/main/java/org/oppia/android/util/logging/firebase:debug_event_logger",
"//utility/src/main/java/org/oppia/android/util/logging/firebase:debug_module",
"//utility/src/main/java/org/oppia/android/util/math:fraction_parser",
# TODO(#59): Remove 'debug_util_module' once we completely migrate to Bazel from Gradle as
# we can then directly exclude debug files from the build and thus won't be requiring this module.
"//utility/src/main/java/org/oppia/android/util/networking:debug_util_module",
Expand Down Expand Up @@ -686,7 +687,7 @@ android_library(
":view_models",
"//app/src/main/java/org/oppia/android/app/translation:app_language_activity_injector_provider",
"//app/src/main/java/org/oppia/android/app/translation:app_language_resource_handler",
"//model:thumbnail_java_proto_lite",
"//model/src/main/proto:thumbnail_java_proto_lite",
"//third_party:androidx_annotation_annotation",
"//third_party:androidx_constraintlayout_constraintlayout",
"//third_party:androidx_lifecycle_lifecycle-livedata-core",
Expand Down Expand Up @@ -732,13 +733,16 @@ kt_android_library(
"//data/src/main/java/org/oppia/android/data/backends/gae:network_config_prod_module",
"//data/src/main/java/org/oppia/android/data/backends/gae:prod_module",
"//domain/src/main/java/org/oppia/android/domain/classify:interactions_module",
"//domain/src/main/java/org/oppia/android/domain/classify/rules/algebraicexpressioninput:algebraic_expression_input_rule_module",
"//domain/src/main/java/org/oppia/android/domain/classify/rules/continueinteraction:continue_module",
"//domain/src/main/java/org/oppia/android/domain/classify/rules/dragAndDropSortInput:drag_and_drop_sort_input_module",
"//domain/src/main/java/org/oppia/android/domain/classify/rules/fractioninput:fraction_input_module",
"//domain/src/main/java/org/oppia/android/domain/classify/rules/imageClickInput:image_click_input_module",
"//domain/src/main/java/org/oppia/android/domain/classify/rules/itemselectioninput:item_selection_input_module",
"//domain/src/main/java/org/oppia/android/domain/classify/rules/mathequationinput:math_equation_input_rule_module",
"//domain/src/main/java/org/oppia/android/domain/classify/rules/multiplechoiceinput:multiple_choice_input_module",
"//domain/src/main/java/org/oppia/android/domain/classify/rules/numberwithunits:number_with_units_rule_module",
"//domain/src/main/java/org/oppia/android/domain/classify/rules/numericexpressioninput:numeric_expression_input_rule_module",
"//domain/src/main/java/org/oppia/android/domain/classify/rules/numericinput:numeric_input_rule_module",
"//domain/src/main/java/org/oppia/android/domain/classify/rules/ratioinput:ratio_input_module",
"//domain/src/main/java/org/oppia/android/domain/classify/rules/textinput:text_input_rule_module",
Expand All @@ -749,8 +753,8 @@ kt_android_library(
"//domain/src/main/java/org/oppia/android/domain/oppialogger:startup_listener",
"//domain/src/main/java/org/oppia/android/domain/oppialogger/exceptions:logger_module",
"//domain/src/main/java/org/oppia/android/domain/oppialogger/loguploader:worker_module",
"//model/src/main/proto:arguments_java_proto_lite",
"//domain/src/main/java/org/oppia/android/domain/profile:profile_management_controller",
"//model:arguments_java_proto_lite",
"//app/src/main/java/org/oppia/android/app/testing/activity:test_activity",
"//third_party:androidx_databinding_databinding-adapters",
"//third_party:androidx_databinding_databinding-common",
Expand Down Expand Up @@ -778,7 +782,9 @@ kt_android_library(
"//utility/src/main/java/org/oppia/android/util/parser/image:image_parsing_module",
# TODO(#2432): Replace debug_module with prod_module when building the app in prod mode.
"//utility/src/main/java/org/oppia/android/util/networking:debug_module",
"//utility/src/main/java/org/oppia/android/util/logging:console_logger_injector_provider",
"//utility/src/main/java/org/oppia/android/util/statusbar:status_bar_color",
"//utility/src/main/java/org/oppia/android/util/threading:dispatcher_injector_provider",
],
)

Expand Down Expand Up @@ -822,15 +828,19 @@ TEST_DEPS = [
":test_deps",
"//app/src/main/java/org/oppia/android/app/testing/activity:test_activity",
"//app/src/main/java/org/oppia/android/app/translation/testing:test_module",
"//app/src/main/java/org/oppia/android/app/utility/math:math_expression_accessibility_util",
"//domain",
"//domain/src/main/java/org/oppia/android/domain/audio:audio_player_controller",
"//domain/src/main/java/org/oppia/android/domain/classify/rules/algebraicexpressioninput:algebraic_expression_input_rule_module",
"//domain/src/main/java/org/oppia/android/domain/classify/rules/continueinteraction:continue_module",
"//domain/src/main/java/org/oppia/android/domain/classify/rules/dragAndDropSortInput:drag_and_drop_sort_input_module",
"//domain/src/main/java/org/oppia/android/domain/classify/rules/fractioninput:fraction_input_module",
"//domain/src/main/java/org/oppia/android/domain/classify/rules/imageClickInput:image_click_input_module",
"//domain/src/main/java/org/oppia/android/domain/classify/rules/itemselectioninput:item_selection_input_module",
"//domain/src/main/java/org/oppia/android/domain/classify/rules/mathequationinput:math_equation_input_rule_module",
"//domain/src/main/java/org/oppia/android/domain/classify/rules/multiplechoiceinput:multiple_choice_input_module",
"//domain/src/main/java/org/oppia/android/domain/classify/rules/numberwithunits:number_with_units_rule_module",
"//domain/src/main/java/org/oppia/android/domain/classify/rules/numericexpressioninput:numeric_expression_input_rule_module",
"//domain/src/main/java/org/oppia/android/domain/classify/rules/numericinput:numeric_input_rule_module",
"//domain/src/main/java/org/oppia/android/domain/classify/rules/ratioinput:ratio_input_module",
"//domain/src/main/java/org/oppia/android/domain/classify/rules/textinput:text_input_rule_module",
Expand All @@ -844,6 +854,8 @@ TEST_DEPS = [
"//testing/src/main/java/org/oppia/android/testing/espresso:konfetti_view_matcher",
"//testing/src/main/java/org/oppia/android/testing/espresso:text_input_action",
"//testing/src/main/java/org/oppia/android/testing/junit:initialize_default_locale_rule",
"//testing/src/main/java/org/oppia/android/testing/math:math_equation_subject",
"//testing/src/main/java/org/oppia/android/testing/math:math_expression_subject",
"//testing/src/main/java/org/oppia/android/testing/mockito",
"//testing/src/main/java/org/oppia/android/testing/network",
"//testing/src/main/java/org/oppia/android/testing/network:test_module",
Expand Down Expand Up @@ -879,6 +891,7 @@ TEST_DEPS = [
"//utility/src/main/java/org/oppia/android/util/accessibility:test_module",
"//utility/src/main/java/org/oppia/android/util/caching:asset_prod_module",
"//utility/src/main/java/org/oppia/android/util/caching/testing:caching_test_module",
"//utility/src/main/java/org/oppia/android/util/math:math_expression_parser",
"//utility/src/main/java/org/oppia/android/util/parser/html:custom_bullet_span",
"//utility/src/main/java/org/oppia/android/util/parser/html:html_parser",
"//utility/src/main/java/org/oppia/android/util/parser/html:html_parser_entity_type_module",
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -75,6 +75,6 @@ kt_android_library(
"//app:app_visibility",
],
deps = [
"//model:profile_java_proto_lite",
"//model/src/main/proto:profile_java_proto_lite",
],
)
Original file line number Diff line number Diff line change
Expand Up @@ -14,13 +14,16 @@ import org.oppia.android.app.translation.ActivityRecreatorProdModule
import org.oppia.android.data.backends.gae.NetworkConfigProdModule
import org.oppia.android.data.backends.gae.NetworkModule
import org.oppia.android.domain.classify.InteractionsModule
import org.oppia.android.domain.classify.rules.algebraicexpressioninput.AlgebraicExpressionInputModule
import org.oppia.android.domain.classify.rules.continueinteraction.ContinueModule
import org.oppia.android.domain.classify.rules.dragAndDropSortInput.DragDropSortInputModule
import org.oppia.android.domain.classify.rules.fractioninput.FractionInputModule
import org.oppia.android.domain.classify.rules.imageClickInput.ImageClickInputModule
import org.oppia.android.domain.classify.rules.itemselectioninput.ItemSelectionInputModule
import org.oppia.android.domain.classify.rules.mathequationinput.MathEquationInputModule
import org.oppia.android.domain.classify.rules.multiplechoiceinput.MultipleChoiceInputModule
import org.oppia.android.domain.classify.rules.numberwithunits.NumberWithUnitsRuleModule
import org.oppia.android.domain.classify.rules.numericexpressioninput.NumericExpressionInputModule
import org.oppia.android.domain.classify.rules.numericinput.NumericInputRuleModule
import org.oppia.android.domain.classify.rules.ratioinput.RatioInputModule
import org.oppia.android.domain.classify.rules.textinput.TextInputRuleModule
Expand Down Expand Up @@ -93,6 +96,8 @@ import javax.inject.Singleton
DeveloperOptionsModule::class, PlatformParameterSyncUpWorkerModule::class,
NetworkConnectionUtilDebugModule::class, NetworkConfigProdModule::class, AssetModule::class,
LocaleProdModule::class, ActivityRecreatorProdModule::class,
NumericExpressionInputModule::class, AlgebraicExpressionInputModule::class,
MathEquationInputModule::class,
// TODO(#59): Remove this module once we completely migrate to Bazel from Gradle as we can then
// directly exclude debug files from the build and thus won't be requiring this module.
NetworkConnectionDebugUtilModule::class
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -3,11 +3,15 @@ package org.oppia.android.app.application
import org.oppia.android.app.translation.AppLanguageApplicationInjector
import org.oppia.android.domain.locale.LocaleApplicationInjector
import org.oppia.android.util.data.DataProvidersInjector
import org.oppia.android.util.logging.ConsoleLoggerInjector
import org.oppia.android.util.system.OppiaClockInjector
import org.oppia.android.util.threading.DispatcherInjector

/** Injector for application-level dependencies that can't be directly injected where needed. */
interface ApplicationInjector :
DataProvidersInjector,
AppLanguageApplicationInjector,
OppiaClockInjector,
LocaleApplicationInjector
LocaleApplicationInjector,
DispatcherInjector,
ConsoleLoggerInjector
Original file line number Diff line number Diff line change
Expand Up @@ -6,15 +6,21 @@ import org.oppia.android.domain.locale.LocaleApplicationInjector
import org.oppia.android.domain.locale.LocaleApplicationInjectorProvider
import org.oppia.android.util.data.DataProvidersInjector
import org.oppia.android.util.data.DataProvidersInjectorProvider
import org.oppia.android.util.logging.ConsoleLoggerInjector
import org.oppia.android.util.logging.ConsoleLoggerInjectorProvider
import org.oppia.android.util.system.OppiaClockInjector
import org.oppia.android.util.system.OppiaClockInjectorProvider
import org.oppia.android.util.threading.DispatcherInjector
import org.oppia.android.util.threading.DispatcherInjectorProvider

/** Provider for [ApplicationInjector]. The application context will implement this interface. */
interface ApplicationInjectorProvider :
DataProvidersInjectorProvider,
AppLanguageApplicationInjectorProvider,
OppiaClockInjectorProvider,
LocaleApplicationInjectorProvider {
LocaleApplicationInjectorProvider,
DispatcherInjectorProvider,
ConsoleLoggerInjectorProvider {
fun getApplicationInjector(): ApplicationInjector

override fun getDataProvidersInjector(): DataProvidersInjector = getApplicationInjector()
Expand All @@ -25,4 +31,8 @@ interface ApplicationInjectorProvider :
override fun getOppiaClockInjector(): OppiaClockInjector = getApplicationInjector()

override fun getLocaleApplicationInjector(): LocaleApplicationInjector = getApplicationInjector()

override fun getDispatcherInjector(): DispatcherInjector = getApplicationInjector()

override fun getConsoleLoggerInjector(): ConsoleLoggerInjector = getApplicationInjector()
}
Original file line number Diff line number Diff line change
Expand Up @@ -20,6 +20,8 @@ import org.oppia.android.app.utility.KeyboardHelper.Companion.showSoftKeyboard
// background="@drawable/edit_text_background"
// maxLength="200".

// TODO(#4135): Add a dedicated test suite for this class.

/** The custom EditText class for fraction input interaction view. */
class FractionInputInteractionView @JvmOverloads constructor(
context: Context,
Expand Down
Original file line number Diff line number Diff line change
@@ -0,0 +1,45 @@
package org.oppia.android.app.parser

import androidx.annotation.StringRes
import org.oppia.android.R
import org.oppia.android.app.translation.AppLanguageResourceHandler
import org.oppia.android.util.math.FractionParser.FractionParsingError

/** Enum to store the errors of [FractionInputInteractionView]. */
enum class FractionParsingUiError(@StringRes private var error: Int?) {
/** Corresponds to [FractionParsingError.VALID]. */
VALID(error = null),

/** Corresponds to [FractionParsingError.INVALID_CHARS]. */
INVALID_CHARS(error = R.string.fraction_error_invalid_chars),

/** Corresponds to [FractionParsingError.INVALID_FORMAT]. */
INVALID_FORMAT(error = R.string.fraction_error_invalid_format),

/** Corresponds to [FractionParsingError.DIVISION_BY_ZERO]. */
DIVISION_BY_ZERO(error = R.string.fraction_error_divide_by_zero),

/** Corresponds to [FractionParsingError.NUMBER_TOO_LONG]. */
NUMBER_TOO_LONG(error = R.string.fraction_error_larger_than_seven_digits);

/**
* Returns the string corresponding to this error's string resources, or null if there is none.
*/
fun getErrorMessageFromStringRes(resourceHandler: AppLanguageResourceHandler): String? =
error?.let(resourceHandler::getStringInLocale)

companion object {
/**
* Returns the [FractionParsingUiError] corresponding to the specified [FractionParsingError].
*/
fun createFromParsingError(parsingError: FractionParsingError): FractionParsingUiError {
return when (parsingError) {
FractionParsingError.VALID -> VALID
FractionParsingError.INVALID_CHARS -> INVALID_CHARS
FractionParsingError.INVALID_FORMAT -> INVALID_FORMAT
FractionParsingError.DIVISION_BY_ZERO -> DIVISION_BY_ZERO
FractionParsingError.NUMBER_TOO_LONG -> NUMBER_TOO_LONG
}
}
}
}
Original file line number Diff line number Diff line change
Expand Up @@ -3,7 +3,7 @@ package org.oppia.android.app.parser
import androidx.annotation.StringRes
import org.oppia.android.R
import org.oppia.android.app.translation.AppLanguageResourceHandler
import org.oppia.android.domain.util.normalizeWhitespace
import org.oppia.android.util.extensions.normalizeWhitespace

/**
* This class contains methods that help to parse string to number, check realtime and submit time
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -4,8 +4,8 @@ import androidx.annotation.StringRes
import org.oppia.android.R
import org.oppia.android.app.model.RatioExpression
import org.oppia.android.app.translation.AppLanguageResourceHandler
import org.oppia.android.domain.util.normalizeWhitespace
import org.oppia.android.domain.util.removeWhitespace
import org.oppia.android.util.extensions.normalizeWhitespace
import org.oppia.android.util.extensions.removeWhitespace

/**
* Utility for parsing [RatioExpression]s from strings and validating strings can be parsed
Expand Down
Loading