Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixes: #3296: Add check to ensure all TODOs are correctly formatted and correspond to an open issue on Github #3508

Merged
merged 249 commits into from
Aug 16, 2021
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
249 commits
Select commit Hold shift + click to select a range
225a4fc
Fix #3290: Add support for generic regex pattern matching
Sparsh1212 Jun 10, 2021
638895f
Apply review suggestions for proto location
Sparsh1212 Jun 11, 2021
e3fd706
Delete main directory
Sparsh1212 Jun 11, 2021
b25e776
Implment script logic and tests
Sparsh1212 Jun 14, 2021
d44e015
CI setup part 1
Sparsh1212 Jun 14, 2021
de1d38f
syntax fix in yaml file
Sparsh1212 Jun 14, 2021
173fe53
import nits in dummy file
Sparsh1212 Jun 15, 2021
618e380
Use regex patterns from script in script test
Sparsh1212 Jun 16, 2021
e3830ac
Make PR suggestions into effect
Sparsh1212 Jun 16, 2021
bb93c0a
Make PR suggestions into effect
Sparsh1212 Jun 16, 2021
f7342c1
Make PR suggestions into effect
Sparsh1212 Jun 16, 2021
51e593b
Improve naming of script_assets variables
Sparsh1212 Jun 16, 2021
0d17657
Make PR suggestions into effect
Sparsh1212 Jun 16, 2021
16bb041
Make PR suggestions
Sparsh1212 Jun 17, 2021
325f28c
Make PR suggestions
Sparsh1212 Jun 17, 2021
a3f8ea6
Revamp testing approach
Sparsh1212 Jun 18, 2021
b1970eb
Merge branch 'develop' into regex-checks
Sparsh1212 Jun 18, 2021
51e64aa
Fix #3291: Add check for XML syntax correctness
Sparsh1212 Jun 18, 2021
f440a33
nit fixes
Sparsh1212 Jun 18, 2021
255773d
Merge branch 'regex-checks' into xml-syntax-check
Sparsh1212 Jun 18, 2021
7b2a178
Introduce XML syntax check in static checks workflow
Sparsh1212 Jun 18, 2021
14c5f6f
Fix #3292: Add check for test files presence for prod files
Sparsh1212 Jun 18, 2021
163310e
Make nit suggestions
Sparsh1212 Jun 20, 2021
6131c1d
Merge branch 'regex-checks' into xml-syntax-check
Sparsh1212 Jun 21, 2021
9cb5fc5
Make nit suggestions
Sparsh1212 Jun 21, 2021
4120775
Merge branch 'xml-syntax-check' into test-file-check
Sparsh1212 Jun 21, 2021
8c98cf2
Make nit suggestions
Sparsh1212 Jun 21, 2021
7f1762c
Fix #3300: Add check for accessibility labels for activities
Sparsh1212 Jun 21, 2021
5229ac9
Add CI check for label presence for activities
Sparsh1212 Jun 21, 2021
7e1d24a
Add ScriptConstants file to exemptions test list
Sparsh1212 Jun 21, 2021
08cf6c3
merge test-file-check
Sparsh1212 Jun 21, 2021
b72e419
Test if: always()
Sparsh1212 Jun 21, 2021
d8472ab
Revert "Test if: always()"
Sparsh1212 Jun 21, 2021
fe42a64
Add if: always()
Sparsh1212 Jun 21, 2021
e12f247
Merge branch 'xml-syntax-check' into test-file-check
Sparsh1212 Jun 21, 2021
9fdb165
Add if: always()
Sparsh1212 Jun 21, 2021
7bf2726
Merge branch 'test-file-check' into accesibilty-label-check
Sparsh1212 Jun 21, 2021
6e3424b
Add if: always()
Sparsh1212 Jun 21, 2021
381853c
Apply review suggestions on PR
Sparsh1212 Jun 22, 2021
c59494f
Merge branch 'regex-checks' into xml-syntax-check
Sparsh1212 Jun 23, 2021
293ab92
Make review suggestions from regex pattern checks
Sparsh1212 Jun 23, 2021
f393e1e
Merge branch 'xml-syntax-check' into test-file-check
Sparsh1212 Jun 23, 2021
56d607e
Implement review suggestions based on #3340
Sparsh1212 Jun 24, 2021
d01a238
Refactor PR as per feedback recieved
Sparsh1212 Jun 24, 2021
b7cb290
Merge branch 'regex-checks' into xml-syntax-check
Sparsh1212 Jun 24, 2021
5a4ac03
Implement feedback suggestions
Sparsh1212 Jun 24, 2021
f6b0715
Merge branch 'xml-syntax-check' into test-file-check
Sparsh1212 Jun 24, 2021
0feacee
Implement review suggestions
Sparsh1212 Jun 24, 2021
28fbc73
Implement review suggestions
Sparsh1212 Jun 24, 2021
96c0bfd
Implement review suggestions
Sparsh1212 Jun 24, 2021
dcbf660
Merge branch 'regex-checks' into xml-syntax-check
Sparsh1212 Jun 24, 2021
56cf6d0
Implement review suggestions
Sparsh1212 Jun 24, 2021
1e3c47d
Merge branch 'xml-syntax-check' into test-file-check
Sparsh1212 Jun 24, 2021
60e64dc
nits
Sparsh1212 Jun 25, 2021
cd2f287
Merge branch 'regex-checks' into xml-syntax-check
Sparsh1212 Jun 25, 2021
36033ef
Nit fixes
Sparsh1212 Jun 25, 2021
161f8ec
Merge branch 'xml-syntax-check' into test-file-check
Sparsh1212 Jun 25, 2021
996694b
Nit fixes
Sparsh1212 Jun 25, 2021
8740a48
Nit fixes
Sparsh1212 Jun 25, 2021
6671857
Merge branch 'regex-checks' into xml-syntax-check
Sparsh1212 Jun 25, 2021
11963c8
Merge branch 'xml-syntax-check' into test-file-check
Sparsh1212 Jun 25, 2021
c8aa5e4
merge test-file-check
Sparsh1212 Jun 26, 2021
3b78452
Implement feedback suggestions as per #3340
Sparsh1212 Jun 26, 2021
fe17ed9
nit fix
Sparsh1212 Jun 27, 2021
6860083
Merge branch 'regex-checks' into xml-syntax-check
Sparsh1212 Jun 27, 2021
4083244
Merge branch 'xml-syntax-check' into test-file-check
Sparsh1212 Jun 27, 2021
7c6f3e8
Merge branch 'test-file-check' into accesibilty-label-check
Sparsh1212 Jun 27, 2021
d65efa4
nit fix
Sparsh1212 Jun 27, 2021
3afc018
nit fix
Sparsh1212 Jun 28, 2021
b13e3f3
Merge branch 'xml-syntax-check' into test-file-check
Sparsh1212 Jun 28, 2021
6132e5d
Merge branch 'test-file-check' into accesibilty-label-check
Sparsh1212 Jun 28, 2021
4a5b47e
nit fix
Sparsh1212 Jun 28, 2021
60f2482
Review suggestions part 1
Sparsh1212 Jun 29, 2021
9375775
Implement review suggestions part 2
Sparsh1212 Jun 29, 2021
a94cc5e
nit fixes
Sparsh1212 Jun 30, 2021
a811521
resolve merge conflict
Sparsh1212 Jun 30, 2021
aeb20d3
update static_checks
Sparsh1212 Jun 30, 2021
d5a0166
add test to repository file
Sparsh1212 Jun 30, 2021
8ac402d
nit fix
Sparsh1212 Jun 30, 2021
32910ea
nit fix
Sparsh1212 Jun 30, 2021
8b749db
nit fix
Sparsh1212 Jun 30, 2021
6c08868
merge regex-checks
Sparsh1212 Jun 30, 2021
4add1ed
Do review suggestions
Sparsh1212 Jun 30, 2021
be2f808
Implement review suggestions
Sparsh1212 Jul 1, 2021
1002034
Implement review suggestions
Sparsh1212 Jul 1, 2021
11010b1
Merge branch 'regex-checks' into xml-syntax-check
Sparsh1212 Jul 1, 2021
ad4b0ec
nit fix
Sparsh1212 Jul 1, 2021
8eaf8df
merge xml-syntax-check
Sparsh1212 Jul 1, 2021
3042f2e
Implement review suggestions
Sparsh1212 Jul 1, 2021
49745a4
Add Ben as a codeowner for the ScriptExemptions file
Sparsh1212 Jul 1, 2021
05dbe3e
bazel files nit fix
Sparsh1212 Jul 1, 2021
45d73c9
Merge branch 'regex-checks' into xml-syntax-check
Sparsh1212 Jul 1, 2021
5a9c601
Merge branch 'xml-syntax-check' into test-file-check
Sparsh1212 Jul 1, 2021
83d66e0
Introduce a library for the regex assets
Sparsh1212 Jul 1, 2021
8cae1f8
Make directory structure same as that of #3374
Sparsh1212 Jul 2, 2021
e201a3d
Merge branch 'regex-checks' into xml-syntax-check
Sparsh1212 Jul 2, 2021
44d839c
Make directory structure similar to #3374
Sparsh1212 Jul 2, 2021
edd6b4e
Merge branch 'develop' into regex-checks
Sparsh1212 Jul 2, 2021
5e38f79
Merge branch 'regex-checks' into xml-syntax-check
Sparsh1212 Jul 2, 2021
73de958
merge xml-syntax-checks
Sparsh1212 Jul 2, 2021
9e67cab
add new files to test file script exemptions and nit fixes
Sparsh1212 Jul 2, 2021
7a73b1f
merge develop
Sparsh1212 Jul 3, 2021
1637ccd
diable ktlint max-line-length
Sparsh1212 Jul 3, 2021
fba990e
disable ktlint-max-line
Sparsh1212 Jul 3, 2021
262a4ec
disable ktlint max-length
Sparsh1212 Jul 3, 2021
8e5887c
merge regex-checks
Sparsh1212 Jul 3, 2021
fcb0555
remove testonly attribute from tests
Sparsh1212 Jul 3, 2021
de21e33
Merge branch 'xml-syntax-check' into test-file-check
Sparsh1212 Jul 3, 2021
130c0d9
add new files to script exemptions
Sparsh1212 Jul 3, 2021
b56c104
nit fix
Sparsh1212 Jul 4, 2021
cdb88fe
Merge branch 'regex-checks' into xml-syntax-check
Sparsh1212 Jul 4, 2021
98f7d73
Merge branch 'xml-syntax-check' into test-file-check
Sparsh1212 Jul 4, 2021
3459461
nit fix
Sparsh1212 Jul 5, 2021
69c5f96
Merge branch 'regex-checks' into xml-syntax-check
Sparsh1212 Jul 5, 2021
26a8d52
Merge branch 'xml-syntax-check' into test-file-check
Sparsh1212 Jul 5, 2021
2e785d5
merge regex-checks
Sparsh1212 Jul 5, 2021
5e13219
nit fix
Sparsh1212 Jul 5, 2021
21e5197
Apply review suggestions
Sparsh1212 Jul 6, 2021
e557570
ktlint fix
Sparsh1212 Jul 6, 2021
3cb5db3
nit fix
Sparsh1212 Jul 6, 2021
c37cca3
Apply nit fixes
Sparsh1212 Jul 6, 2021
e2186d7
Apply nit fixes
Sparsh1212 Jul 6, 2021
7d7f9fc
Remove script constants
Sparsh1212 Jul 7, 2021
b70c880
nit fix
Sparsh1212 Jul 7, 2021
e70413b
add tests for XML syntax error handler
Sparsh1212 Jul 7, 2021
8e8bcf5
merge xml-syntax-check
Sparsh1212 Jul 7, 2021
31c1df5
add todo
Sparsh1212 Jul 7, 2021
5849bc0
Merge branch 'regex-checks' into xml-syntax-check
Sparsh1212 Jul 7, 2021
e09e837
Merge branch 'xml-syntax-check' into test-file-check
Sparsh1212 Jul 7, 2021
637606c
add todo
Sparsh1212 Jul 7, 2021
5ed9d9a
Merge branch 'develop' into regex-checks
Sparsh1212 Jul 8, 2021
bab0b70
Merge branch 'regex-checks' into xml-syntax-check
Sparsh1212 Jul 8, 2021
c30158c
nit fixes
Sparsh1212 Jul 8, 2021
d57ef42
Merge branch 'develop' into regex-checks
Sparsh1212 Jul 8, 2021
d873ecd
Merge branch 'regex-checks' into xml-syntax-check
Sparsh1212 Jul 8, 2021
de8bf3a
add test
Sparsh1212 Jul 8, 2021
5a1cbd9
Merge branch 'xml-syntax-check' into test-file-check
Sparsh1212 Jul 8, 2021
91e108a
add testOnly
Sparsh1212 Jul 8, 2021
17ddf56
Merge branch 'regex-checks' into xml-syntax-check
Sparsh1212 Jul 8, 2021
594d31a
Merge branch 'xml-syntax-check' into test-file-check
Sparsh1212 Jul 8, 2021
1940980
nit fixes
Sparsh1212 Jul 8, 2021
d34d46b
nit fix
Sparsh1212 Jul 8, 2021
ba0b960
Merge branch 'xml-syntax-check' into test-file-check
Sparsh1212 Jul 8, 2021
50ea8ae
nit fixes
Sparsh1212 Jul 8, 2021
c72e5a9
nit fixes
Sparsh1212 Jul 8, 2021
57d0b42
nit fixes
Sparsh1212 Jul 8, 2021
c32c921
nit fixes
Sparsh1212 Jul 8, 2021
b99a316
fix textproto file
Sparsh1212 Jul 8, 2021
af6a607
merge-regex-checks
Sparsh1212 Jul 8, 2021
6bdea69
Merge branch 'xml-syntax-check' into test-file-check
Sparsh1212 Jul 8, 2021
7f13ff8
merge xml-syntax-check
Sparsh1212 Jul 8, 2021
19fc1e9
add exemptions to textproto
Sparsh1212 Jul 8, 2021
99a1f13
sort failures lexicographically
Sparsh1212 Jul 8, 2021
0dd079c
Merge branch 'develop' into test-file-check
Sparsh1212 Jul 9, 2021
f286c73
add new files to exemption list
Sparsh1212 Jul 9, 2021
0db928c
merge test-file-check
Sparsh1212 Jul 11, 2021
0d2d9dd
merge develop
Sparsh1212 Jul 11, 2021
a331ffa
nit fixes
Sparsh1212 Jul 11, 2021
484891e
nit fixes
Sparsh1212 Jul 11, 2021
5a7495d
add kdocs
Sparsh1212 Jul 13, 2021
9988373
nit fix
Sparsh1212 Jul 13, 2021
0eb4dd6
nit fix
Sparsh1212 Jul 13, 2021
76b8e2c
Trigger CI failure exclusively
Sparsh1212 Jul 14, 2021
e34798e
Revert CI check failure
Sparsh1212 Jul 14, 2021
1fdf50e
Fix #3340: Create a script to ensure KDoc presence
Sparsh1212 Jul 14, 2021
2fa1af8
Add initial tests
Sparsh1212 Jul 17, 2021
023bac6
Add more tests and add documentation
Sparsh1212 Jul 17, 2021
75bb351
nit fix
Sparsh1212 Jul 17, 2021
dcba69f
merge develop
Sparsh1212 Jul 17, 2021
f09d0d4
nit fix
Sparsh1212 Jul 17, 2021
9c94456
nit fix
Sparsh1212 Jul 17, 2021
03576d1
merge accessibility label check
Sparsh1212 Jul 17, 2021
633cb4b
nit fix
Sparsh1212 Jul 17, 2021
34ad4e9
Add more files to kdoc exemptions
Sparsh1212 Jul 17, 2021
1a165b3
Implementation part 1
Sparsh1212 Jul 18, 2021
2ce88ce
add exemption proto for todos
Sparsh1212 Jul 20, 2021
b042bba
nit fixes
Sparsh1212 Jul 20, 2021
3db1d29
nit fixes
Sparsh1212 Jul 20, 2021
1989ed2
add exemptions to todos and merge kdoc-check
Sparsh1212 Jul 20, 2021
33bac8e
delete open issues
Sparsh1212 Jul 20, 2021
8e9c383
Merge branch 'develop' into accesibilty-label-check
Sparsh1212 Jul 22, 2021
dc2b163
nit fixes
Sparsh1212 Jul 22, 2021
b012d04
nit fixes
Sparsh1212 Jul 22, 2021
eacacba
Add redundant exemptions check
Sparsh1212 Jul 24, 2021
57a4b8d
Merge branch 'develop' into accesibilty-label-check
Sparsh1212 Jul 24, 2021
43cf464
rectify static_checks
Sparsh1212 Jul 24, 2021
3d3b03f
Remove duplicate proto libraries
Sparsh1212 Jul 24, 2021
26df126
merge accessibility-check
Sparsh1212 Jul 24, 2021
4082259
nit fixes
Sparsh1212 Jul 24, 2021
8db6c21
nit fixes and add redundant exemptions check to script
Sparsh1212 Jul 25, 2021
1aa7ead
nit fixes
Sparsh1212 Jul 28, 2021
9fb4e1c
add activity to exemption
Sparsh1212 Jul 28, 2021
94a482b
Merge branch 'accesibilty-label-check' into kdoc-check
Sparsh1212 Jul 28, 2021
8506662
nit fixes
Sparsh1212 Jul 28, 2021
fffef74
nit fixes
Sparsh1212 Jul 28, 2021
2ed0719
Merge branch 'accesibilty-label-check' into kdoc-check
Sparsh1212 Jul 28, 2021
a7efb89
nit fixes
Sparsh1212 Jul 28, 2021
6f0f05c
nit fixes
Sparsh1212 Jul 28, 2021
6c4c64f
Merge branch 'accesibilty-label-check' into kdoc-check
Sparsh1212 Jul 28, 2021
a5a1faa
merge kdoc-check
Sparsh1212 Jul 28, 2021
e824447
revamption part 1
Sparsh1212 Jul 28, 2021
015d717
nit fixes
Sparsh1212 Jul 28, 2021
fda44e4
Merge branch 'accesibilty-label-check' into kdoc-check
Sparsh1212 Jul 28, 2021
0469e63
Merge branch 'kdoc-check' into todo-check
Sparsh1212 Jul 28, 2021
cb67d44
Merge branch 'develop' into accesibilty-label-check
Sparsh1212 Jul 28, 2021
bb68dcd
update branch
Sparsh1212 Jul 28, 2021
2343423
Merge branch 'accesibilty-label-check' into kdoc-check
Sparsh1212 Jul 28, 2021
36e5ced
Merge branch 'kdoc-check' into todo-check
Sparsh1212 Jul 28, 2021
f2e0b91
Revamped approach
Sparsh1212 Jul 28, 2021
dc8b52f
nit fixes
Sparsh1212 Jul 28, 2021
0567d69
add kdocs
Sparsh1212 Jul 29, 2021
f6299e7
delete open_issues.json
Sparsh1212 Jul 29, 2021
a5e5e28
Fix #3317: Update old todos
Jul 29, 2021
a397534
update branch
Sparsh1212 Jul 30, 2021
a46a95c
Merge branch 'develop' into kdoc-check
Sparsh1212 Jul 30, 2021
c55a8cf
nit fixes
Sparsh1212 Jul 30, 2021
912d0e7
Merge branch 'develop' into fix-todos
Jul 30, 2021
063cc1b
Remove resolved todos
Jul 30, 2021
6c4d8d6
Repurpose todos stage 1
Jul 30, 2021
8324376
Repurpose todos stage 2
Jul 30, 2021
cb0e881
Merge branch 'kdoc-check' into todo-check
Sparsh1212 Jul 31, 2021
8483c81
merge kdoc-check
Sparsh1212 Jul 31, 2021
078b242
updating todos part 3
Aug 2, 2021
88ff366
update more todos
Aug 2, 2021
4a6a9e3
add network module
Aug 2, 2021
c150cdc
update todo no. 322
Aug 3, 2021
65ee6e9
Remove unused imports
Aug 4, 2021
5d4c779
Revert "Remove unused imports"
Aug 4, 2021
afb32e4
Revert "update todo no. 322"
Aug 4, 2021
1edfafe
Repurpose no. 322
Aug 4, 2021
18221be
Merge remote-tracking branch 'upstream/fix-todos' into todo-check
Sparsh1212 Aug 5, 2021
0618169
Merge branch 'develop' into fix-todos
Aug 5, 2021
b954738
Merge remote-tracking branch 'upstream/fix-todos' into todo-check
Sparsh1212 Aug 5, 2021
6caabc5
nit fixes
Sparsh1212 Aug 5, 2021
29825a0
replace issue number for backend model todo
Aug 5, 2021
e464728
link new filed issue
Aug 5, 2021
a680eeb
Merge remote-tracking branch 'upstream/fix-todos' into todo-check
Sparsh1212 Aug 5, 2021
15063a0
Merge branch 'develop' into todo-check
Sparsh1212 Aug 6, 2021
619d40d
Merge branch 'develop' into todo-check
Sparsh1212 Aug 10, 2021
ad3eb60
nit fixes
Sparsh1212 Aug 10, 2021
cc62d02
merge develop
Sparsh1212 Aug 11, 2021
a51bb90
add exemptions
Sparsh1212 Aug 11, 2021
7dc10a5
nit fixes
Sparsh1212 Aug 11, 2021
048cd01
nit fixes
Sparsh1212 Aug 11, 2021
cbd3de0
nit fixes
Sparsh1212 Aug 11, 2021
4e17c5c
nit fixes
Sparsh1212 Aug 13, 2021
c898036
add remaining tests for all cases
Sparsh1212 Aug 13, 2021
7dfb38b
nit fixes
Sparsh1212 Aug 14, 2021
966ba9a
nit fixes
Sparsh1212 Aug 14, 2021
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 8 additions & 0 deletions .github/workflows/static_checks.yml
Original file line number Diff line number Diff line change
Expand Up @@ -129,6 +129,14 @@ jobs:
run: |
bazel run //scripts:kdoc_validity_check -- $(pwd) scripts/assets/kdoc_validity_exemptions.pb

- name: Todo Check
if: always()
env:
GITHUB_TOKEN: ${{ github.token }}
run: |
gh issue list --limit 2000 --repo oppia/oppia-android --json number > $(pwd)/open_issues.json
bazel run //scripts:todo_open_check -- $(pwd) scripts/assets/todo_open_exemptions.pb open_issues.json

third_party_dependencies_check:
name: Maven Dependencies Checks
runs-on: ubuntu-18.04
Expand Down
2 changes: 1 addition & 1 deletion app/src/main/res/layout/concept_card_fragment.xml
Original file line number Diff line number Diff line change
Expand Up @@ -72,7 +72,7 @@
android:textDirection="locale"
android:textSize="16sp" />
</LinearLayout>
<!--TODO(#352): Show worked examples in Concept Card.-->
<!-- TODO(#352): Show worked examples in Concept Card. -->
</ScrollView>

<View
Expand Down
16 changes: 16 additions & 0 deletions scripts/BUILD.bazel
Original file line number Diff line number Diff line change
Expand Up @@ -10,6 +10,7 @@ load(
"generate_maven_assets_list_from_text_protos",
"generate_regex_assets_list_from_text_protos",
"generate_test_file_assets_list_from_text_protos",
"generate_todo_assets_list_from_text_protos",
)

# Visibility for libraries that should be accessible to script tests.
Expand Down Expand Up @@ -163,3 +164,18 @@ kt_jvm_binary(
"//scripts/src/java/org/oppia/android/scripts/docs:kdoc_validity_check_lib",
],
)

TODO_OPEN_EXEMPTION_ASSETS = generate_todo_assets_list_from_text_protos(
name = "todo_exemption_assets",
todo_exemptions_name = ["todo_open_exemptions"],
)

kt_jvm_binary(
name = "todo_open_check",
testonly = True,
data = TODO_OPEN_EXEMPTION_ASSETS,
main_class = "org.oppia.android.scripts.todo.TodoOpenCheckKt",
runtime_deps = [
"//scripts/src/java/org/oppia/android/scripts/todo:todo_open_check_lib",
],
)
2 changes: 2 additions & 0 deletions scripts/assets/test_file_exemptions.textproto
Original file line number Diff line number Diff line change
Expand Up @@ -583,6 +583,8 @@ exempted_file_path: "scripts/src/java/org/oppia/android/scripts/license/model/De
exempted_file_path: "scripts/src/java/org/oppia/android/scripts/maven/model/MavenListDependency.kt"
exempted_file_path: "scripts/src/java/org/oppia/android/scripts/maven/model/MavenListDependencies.kt"
exempted_file_path: "scripts/src/java/org/oppia/android/scripts/maven/model/MavenListDependencyTree.kt"
exempted_file_path: "scripts/src/java/org/oppia/android/scripts/todo/model/Issue.kt"
exempted_file_path: "scripts/src/java/org/oppia/android/scripts/todo/model/Todo.kt"
exempted_file_path: "testing/src/main/java/org/oppia/android/testing/AccessibilityTestRule.kt"
exempted_file_path: "testing/src/main/java/org/oppia/android/testing/AssertionHelpers.kt"
exempted_file_path: "testing/src/main/java/org/oppia/android/testing/DisableAccessibilityChecks.kt"
Expand Down
280 changes: 280 additions & 0 deletions scripts/assets/todo_open_exemptions.textproto
Original file line number Diff line number Diff line change
@@ -0,0 +1,280 @@
todo_open_exemption {
exempted_file_path: ".github/CODEOWNERS"
line_number: 9
}
todo_open_exemption {
exempted_file_path: "scripts/src/javatests/org/oppia/android/scripts/todo/TodoOpenCheckTest.kt"
line_number: 64
line_number: 65
line_number: 71
line_number: 73
line_number: 95
line_number: 96
line_number: 97
line_number: 98
line_number: 99
line_number: 116
line_number: 132
line_number: 133
line_number: 136
line_number: 168
line_number: 169
line_number: 170
line_number: 175
line_number: 177
line_number: 193
line_number: 216
line_number: 217
line_number: 218
line_number: 223
line_number: 225
line_number: 231
line_number: 248
line_number: 270
line_number: 274
line_number: 312
line_number: 313
line_number: 317
line_number: 366
line_number: 367
line_number: 368
line_number: 372
line_number: 402

}
todo_open_exemption {
exempted_file_path: "scripts/src/javatests/org/oppia/android/scripts/todo/TodoCollectorTest.kt"
line_number: 33
line_number: 34
line_number: 35
line_number: 36
line_number: 37
line_number: 38
line_number: 39
line_number: 40
line_number: 41
line_number: 42
line_number: 43
line_number: 44
line_number: 45
line_number: 46
line_number: 47
line_number: 48
line_number: 49
line_number: 50
line_number: 51
line_number: 52
line_number: 53
line_number: 54
line_number: 55
line_number: 56
line_number: 57
line_number: 63
line_number: 64
line_number: 73
line_number: 76
line_number: 80
line_number: 83
line_number: 87
line_number: 90
line_number: 94
line_number: 97
line_number: 101
line_number: 104
line_number: 108
line_number: 111
line_number: 115
line_number: 118
line_number: 122
line_number: 125
line_number: 129
line_number: 132
line_number: 136
line_number: 139
line_number: 143
line_number: 146
line_number: 150
line_number: 153
line_number: 157
line_number: 160
line_number: 164
line_number: 167
line_number: 171
line_number: 174
line_number: 178
line_number: 181
line_number: 185
line_number: 188
line_number: 192
line_number: 195
line_number: 199
line_number: 202
line_number: 206
line_number: 209
line_number: 213
line_number: 216
line_number: 220
line_number: 223
line_number: 227
line_number: 230
line_number: 234
line_number: 237
line_number: 241
line_number: 244
line_number: 248
line_number: 255
line_number: 258
line_number: 262
line_number: 265
line_number: 274
line_number: 275
line_number: 279
line_number: 283
line_number: 284
line_number: 296
line_number: 299
line_number: 303
line_number: 306
line_number: 310
line_number: 313
line_number: 317
line_number: 320
line_number: 324
line_number: 327
line_number: 336
line_number: 337
line_number: 338
line_number: 339
line_number: 344
line_number: 349
line_number: 352
line_number: 365
line_number: 368
line_number: 372
line_number: 375
line_number: 379
line_number: 382
line_number: 386
line_number: 389
line_number: 393
line_number: 396
line_number: 400
line_number: 403
line_number: 407
line_number: 410
line_number: 419
line_number: 420
line_number: 421
line_number: 422
line_number: 426
line_number: 430
line_number: 433
line_number: 446
line_number: 449
line_number: 453
line_number: 456
line_number: 460
line_number: 463
line_number: 467
line_number: 470
line_number: 474
line_number: 477
line_number: 481
line_number: 484
line_number: 488
line_number: 491
line_number: 532
line_number: 533
line_number: 534
line_number: 539
line_number: 544
line_number: 547
line_number: 548
line_number: 549
line_number: 550
line_number: 551
line_number: 552
line_number: 553
line_number: 554
line_number: 555
line_number: 556
line_number: 557
line_number: 558
line_number: 559
line_number: 560
line_number: 561
line_number: 562
line_number: 563
line_number: 564
line_number: 565
line_number: 566
line_number: 567
line_number: 568
line_number: 569
line_number: 575
line_number: 588
line_number: 591
line_number: 595
line_number: 598
line_number: 602
line_number: 605
line_number: 609
line_number: 612
line_number: 616
line_number: 619
line_number: 627
line_number: 636
line_number: 645
line_number: 654
line_number: 663
line_number: 672
line_number: 681
line_number: 690
line_number: 699
line_number: 708
line_number: 717
line_number: 726
line_number: 735
line_number: 744
line_number: 753
line_number: 762
line_number: 771
line_number: 780
line_number: 789
line_number: 798
line_number: 807
line_number: 816
line_number: 826
line_number: 827
line_number: 828
line_number: 836
line_number: 839
line_number: 843
line_number: 846
line_number: 850
line_number: 853
line_number: 862
line_number: 863
line_number: 864
line_number: 873
line_number: 876
line_number: 880
line_number: 883
line_number: 887
line_number: 890
line_number: 899
line_number: 900
line_number: 901
}
todo_open_exemption {
exempted_file_path: "scripts/src/java/org/oppia/android/scripts/todo/TodoCollector.kt"
line_number: 82
}
todo_open_exemption {
exempted_file_path: "scripts/src/java/org/oppia/android/scripts/todo/TodoOpenCheck.kt"
line_number: 97
}
todo_open_exemption {
exempted_file_path: "scripts/src/java/org/oppia/android/scripts/todo/model/Todo.kt"
line_number: 10
}
24 changes: 24 additions & 0 deletions scripts/script_assets.bzl
Original file line number Diff line number Diff line change
Expand Up @@ -136,3 +136,27 @@ def generate_kdoc_validity_assets_list_from_text_protos(
proto_dep_bazel_target_prefix = "//scripts/src/java/org/oppia/android/scripts/proto",
proto_package = "proto",
)

def generate_todo_assets_list_from_text_protos(
name,
todo_exemptions_name):
"""
Converts a single list of text proto assets to binary.

Args:
name: str. The name of this generation instance. This will be a prefix for derived targets.
todo_exemptions_name: list of str. The list of todo exemptions file name.

Returns:
list of str. The list of new proto binary asset files that were generated.
"""
return generate_proto_binary_assets(
name = name,
names = todo_exemptions_name,
proto_dep_name = "script_exemptions",
proto_type_name = "TodoOpenExemptions",
name_prefix = name,
asset_dir = "assets",
proto_dep_bazel_target_prefix = "//scripts/src/java/org/oppia/android/scripts/proto",
proto_package = "proto",
)
Original file line number Diff line number Diff line change
Expand Up @@ -16,6 +16,12 @@ class RepositoryFile() {
"bazel-oppia-android",
"bazel-out",
"bazel-testlogs",
"app/build/",
BenHenning marked this conversation as resolved.
Show resolved Hide resolved
"data/build/",
"domain/build/",
"model/build/",
"testing/build/",
"utility/build/",
)

/**
Expand Down Expand Up @@ -51,7 +57,13 @@ class RepositoryFile() {
* @return whether the specified path should be analyzed per allow rules
*/
private fun checkIfProhibitedFile(pathString: String): Boolean {
return alwaysExcludeDirectoryList.any { pathString.startsWith(it) }
return alwaysExcludeDirectoryList.any {
if (it.endsWith("/")) {
pathString.startsWith("$it")
} else {
pathString.startsWith("$it/")
}
}
}

/**
Expand Down
Loading