-
Notifications
You must be signed in to change notification settings - Fork 533
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix #3199: [RTL] High-fi Profile chooser screen #3256
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
In this please add screenshots for tablet (portrait + landscape) and mobile landscape too as the UI for landscape mode is quite different.
@rt4914 I was unable to test on tablet emulator, could you please check it and assign someone to test on tablet and send screenshot. |
@veena14cs On Tablet device the RTL is not working. Please take a look. |
Thanks for these screenshots Rajat! I will make corrections and update the PR. |
@rt4914 I have updated Tablet screenshots in the description. PTAL. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, thanks.
Explanation
This PR fixes #3199. Fixes the spacing issue in between the Profile image and the name.
Note :
Please test this PR with tablet as I was not able to test this on my emulator.
Screenshot LTR and RTL
......
.......
......
.....
Checklist