Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixes part of #40: Added bottom padding to Question Player #3250

Merged
merged 8 commits into from
Jul 6, 2021

Conversation

rt4914
Copy link
Contributor

@rt4914 rt4914 commented May 25, 2021

Explanation

Fixes part of #40: Added bottom padding to Question Player

Before this PR more than 2 test cases were failing on espresso in QuestionPlayerActivityTest that were fixed by adding the bottom-padding which was also a requirement as per mocks.

But still 2 test cases are failing because of nested recyclerview for SelectionInputInteraction.

Screenshot 2021-05-25 at 8 18 19 PM

In both these tests we want to scroll to index=3 item of the selection_interaction_recycler_view but the scrolling is disabled because it's an item of question_recycler_view and in current code we cannot scroll to this specific position.

Output on Pixel 3 (5.56")

Screenshot 2021-06-24 at 12 31 13 AM

Output on Pixel 3 XL (6.3")

Screenshot 2021-06-24 at 12 28 54 AM

To fix this I have filed an issue #3370

Checklist

  • The PR title starts with "Fix #bugnum: ", followed by a short, clear summary of the changes. (If this PR fixes part of an issue, prefix the title with "Fix part of #bugnum: ...".)
  • The PR explanation includes the words "Fixes #bugnum: ..." (or "Fixes part of #bugnum" if the PR only partially fixes an issue).
  • The PR follows the style guide.
  • The PR does not contain any unnecessary auto-generated code from Android Studio.
  • The PR is made from a branch that's not called "develop".
  • The PR is made from a branch that is up-to-date with "develop".
  • The PR's branch is based on "develop" and not on any other branch.
  • The PR is assigned to an appropriate reviewer in both the Assignees and the Reviewers sections.

@rt4914
Copy link
Contributor Author

rt4914 commented May 25, 2021

@BenHenning @anandwana001 PTAL at the description and can you suggest something on how to fix these failing tests?

@rt4914 rt4914 mentioned this pull request May 25, 2021
8 tasks
@anandwana001
Copy link
Contributor

I will take a look at this by tomorrow.

@BenHenning
Copy link
Member

@rt4914 per our discussion earlier in the week, is further input needed from me for this PR?

@anandwana001 anandwana001 removed their assignment May 28, 2021
Copy link
Member

@BenHenning BenHenning left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hmm. I'm not keen on changing padding for the purpose of testing since that has real side effects for users. Do you have a before & after to demonstrate the effects?

@rt4914 rt4914 requested a review from BenHenning June 23, 2021 19:13
@rt4914 rt4914 assigned anandwana001 and BenHenning and unassigned rt4914 and anandwana001 Jun 23, 2021
@rt4914 rt4914 assigned rt4914 and unassigned BenHenning Jun 29, 2021
@rt4914 rt4914 assigned BenHenning and unassigned rt4914 Jul 5, 2021
Copy link
Member

@BenHenning BenHenning left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @rt4914. LGTM.

@BenHenning BenHenning merged commit 09e3692 into develop Jul 6, 2021
@BenHenning BenHenning deleted the fix-question-player-tests branch July 6, 2021 00:18
@rt4914 rt4914 mentioned this pull request Jul 6, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants