Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixed Issue #2809. 'AddProfileActivity' Label Added in AndroidManifest.xml. #2935

Closed
wants to merge 1 commit into from
Closed

Conversation

ihrishix
Copy link
Contributor

@ihrishix ihrishix commented Mar 18, 2021

Explanation

Fixed Issue #2809

Checklist

  • The PR title starts with "Fix #bugnum: ", followed by a short, clear summary of the changes. (If this PR fixes part of an issue, prefix the title with "Fix part of #bugnum: ...".)
  • The PR explanation includes the words "Fixes #bugnum: ..." (or "Fixes part of #bugnum" if the PR only partially fixes an issue).
  • The PR follows the style guide.
  • [x ] The PR does not contain any unnecessary auto-generated code from Android Studio.
  • [x ] The PR is made from a branch that's not called "develop".
  • The PR is made from a branch that is up-to-date with "develop".
  • The PR's branch is based on "develop" and not on any other branch.
  • The PR is assigned to an appropriate reviewer in both the Assignees and the Reviewers sections.

@ihrishix ihrishix requested a review from BenHenning as a code owner March 18, 2021 05:24
@anandwana001
Copy link
Contributor

anandwana001 commented Mar 18, 2021

@rushikeshsuryawanshi Could you please check the Checklist in the PR description and follow as per given? Let me know if need any help.

Also, check a reference PR for similar issues - #2750

@rt4914
Copy link
Contributor

rt4914 commented Mar 18, 2021

@rushikeshsuryawanshi In this original issue I have mentioned one sample PR. Please take guidance from that and create this PR accordingly.

@ihrishix
Copy link
Contributor Author

ihrishix commented Mar 19, 2021

@anandwana001 Do i need to check all boxes ? My PR doesn't fix any bug . So can't check the first one
Also, if you could please tell me what to do exactly. I'm new to OpenSource. This is my First PR

@prayutsu
Copy link
Contributor

Hi @rushikeshsuryawanshi
I suggest looking at our wiki for making a code change.
Also, the checkboxes in the PR explanation refer to the PR title, PR explanation, and our other PR guidelines.

  • Tick the first checkbox if your PR title starts with Fix #issueNumber e.g- Fix #2809: Add label for AddProfileActivity. If your title doesn't match with those formats, you should change the title and then tick the box.
  • Tick the second checkbox if you have included Fixes #issueNumber in the PR explanation(it should not include any other words in between) e.g - Fixes #2809: Added a label to the AndroidManifests.xml for AddProfileActivity.

Similarly for other checkboxes.

@rt4914
Copy link
Contributor

rt4914 commented Mar 30, 2021

Closing this because of no updates for a week.

@rt4914 rt4914 closed this Mar 30, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants