Fix #2817: Add label for ReadingTextSizeActivity #2930
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
prayutsu
suggested changes
Mar 17, 2021
| @@ -63,7 +63,8 @@ | |||
| android:theme="@style/OppiaThemeWithoutActionBar" /> | |||
| <activity | |||
| android:name=".app.options.ReadingTextSizeActivity" | |||
| android:theme="@style/OppiaThemeWithoutActionBar" /> | |||
| android:theme="@style/OppiaThemeWithoutActionBar" | |||
| android:label="@string/reading_text_size"/> | |||
| <activity | |||
There was a problem hiding this comment.
It requires reformatting.
And also please append label to the string id.
| @@ -196,22 +194,22 @@ class AppVersionActivityTest { | |||
| private fun getDateTime(dateTimeTimestamp: Long): String? { | |||
| return oppiaDateTimeFormatter.formatDateFromDateString( | |||
| OppiaDateTimeFormatter.DD_MMM_YYYY, | |||
| dateTimeTimestamp, | |||
There was a problem hiding this comment.
This file isn't related to this PR, revert the changes of this file.
|
Also please choose a descriptive branch name and avoid including your name in the branch name. You can look at our wiki to see how to choose a good branch name. |
arjunrkaushik
commented
Mar 18, 2021
| return ReadingTextSizeActivity.createReadingTextSizeActivityIntent( | ||
| ApplicationProvider.getApplicationContext(), | ||
| READING_TEXT_SIZE, | ||
| summaryValue = null |
There was a problem hiding this comment.
@prayutsu What do i pass as the summary value?
There was a problem hiding this comment.
@arjunrkaushik you can pass "Small"
|
@arjunrkaushik Any updates on this? |
|
Closing this PR as no further update |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Explanation
Fixes #2817: Add label for ReadingTextSizeActivity as Reading Text Size
Checklist