Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix #2820: Add label for FAQSingleActivity #2926

Merged
merged 3 commits into from
Mar 18, 2021
Merged

Fix #2820: Add label for FAQSingleActivity #2926

merged 3 commits into from
Mar 18, 2021

Conversation

yashraj-01
Copy link
Contributor

Explanation

Fixes #2820 . Added label for FAQSingleActivity

Checklist

  • The PR title starts with "Fix #bugnum: ", followed by a short, clear summary of the changes. (If this PR fixes part of an issue, prefix the title with "Fix part of #bugnum: ...".)
  • The PR explanation includes the words "Fixes #bugnum: ..." (or "Fixes part of #bugnum" if the PR only partially fixes an issue).
  • The PR follows the style guide.
  • The PR does not contain any unnecessary auto-generated code from Android Studio.
  • The PR is made from a branch that's not called "develop".
  • The PR is made from a branch that is up-to-date with "develop".
  • The PR's branch is based on "develop" and not on any other branch.
  • The PR is assigned to an appropriate reviewer in both the Assignees and the Reviewers sections.

@yashraj-01
Copy link
Contributor Author

@rt4914 @BenHenning PTAL

BenHenning
BenHenning requested changes Mar 17, 2021
View reviewed changes
Copy link
Member

@BenHenning BenHenning left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @yashraj-iitr! just had one comment.

app/src/sharedTest/java/org/oppia/android/app/faq/FAQSingleActivityTest.kt Outdated Show resolved Hide resolved
@BenHenning BenHenning assigned yashraj-01 and unassigned BenHenning Mar 17, 2021
@yashraj-01 yashraj-01 requested a review from BenHenning March 17, 2021 06:07
rt4914
rt4914 suggested changes Mar 17, 2021
View reviewed changes
Copy link
Contributor

@rt4914 rt4914 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@YashKr01 PTAL

app/src/main/AndroidManifest.xml Outdated Show resolved Hide resolved
@rt4914 rt4914 assigned BenHenning and unassigned rt4914 and BenHenning Mar 17, 2021
@yashraj-01 yashraj-01 requested a review from rt4914 March 17, 2021 14:24
BenHenning
BenHenning approved these changes Mar 18, 2021
View reviewed changes
Copy link
Member

@BenHenning BenHenning left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @yashraj-iitr! LGTM.

@BenHenning BenHenning assigned rt4914 and unassigned BenHenning and yashraj-01 Mar 18, 2021
@yashraj-01
Copy link
Contributor Author

@anandwana001 should I add screenshots of test results here as well?

rt4914
rt4914 approved these changes Mar 18, 2021
View reviewed changes
Copy link
Contributor

@rt4914 rt4914 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, Thanks.

@rt4914 rt4914 merged commit dd2ff0f into oppia:develop Mar 18, 2021
@yashraj-01 yashraj-01 deleted the add-label-faq-single branch March 19, 2021 08:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@BenHenning BenHenning BenHenning approved these changes

@rt4914 rt4914 rt4914 approved these changes

Assignees

@rt4914 rt4914

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[A11y] Add label for FAQSingleActivity
3 participants
@yashraj-01 @rt4914 @BenHenning