[RunAllTests] Fix part of #2844: work around Bazel-specific CI issue that's causing an OpenJDK crash/flake #2846
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Update Bazel to use JDK 9 in CI for building per https://docs.bazel.build/versions/master/bazel-and-java.html#configuring-the-jdk.
Update Bazel builds to use faster tools repository, and to use JDK 9 for building.
Remove tools override since it's now part of ~/.bazelrc.
BenHenning
commented
Mar 7, 2021
BenHenning
commented
Mar 7, 2021
Attempt to use the solution described in: bazelbuild/bazel#3236 (comment).
BenHenning
changed the title
BenHenning
changed the title
|
Is this still required? |
|
@vinitamurthi this is expected to help, but it may not be sufficient to fully fix the Bazel-caused flakes. |
vinitamurthi
approved these changes
Mar 25, 2021
Conflicts: .github/workflows/build_tests.yml .github/workflows/unit_tests.yml
|
Thanks all! Enabling auto-merge after resolving conflicts since some of the changes here may help with work I'm doing in #1861 to make Bazel CI runs a bit faster. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix part of #2844.
This attempts to fix part of #2844 by normalizing test compiling/running on JDK 9 (for parity with Gradle tests--see #2845), and by working around what appears to be a resource constraint issue Bazel is hitting. For the latter, see bazelbuild/bazel#3236 (comment). All configuration changes in this PR are done via changes to the CI environment's
~/.bazelrcfile, so nothing here should affect local builds.Note that configuring Java versions in Bazel is complicated. In particular, at any time there can be 5 different versions of Java at play:
Now, from what I can tell, I think we only need to configure (1) since (2) should already be using the correct version of Java (JDK 9). We do want the majority of the build to be on JDK 9 since that's what we're running on, but this isn't super important. See also https://docs.bazel.build/versions/master/bazel-and-java.html#configuring-the-jdk & bazelbuild/bazel#5594 for more details on how this Java resolution works.
Finally, similar to #2845 this cannot be observed as "correct" until we observe the flake itself disappearing over the next few weeks.