Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix #2657: Added BUILD.bazel in util/system #2795

Merged
merged 7 commits into from
Mar 9, 2021
Merged

Fix #2657: Added BUILD.bazel in util/system #2795

merged 7 commits into from
Mar 9, 2021

Conversation

FareesHussain
Copy link
Contributor

Explanation

Fixes #2657

Checklist

  • The PR title starts with "Fix #bugnum: ", followed by a short, clear summary of the changes. (If this PR fixes part of an issue, prefix the title with "Fix part of #bugnum: ...".)
  • The PR explanation includes the words "Fixes #bugnum: ..." (or "Fixes part of #bugnum" if the PR only partially fixes an issue).
  • The PR follows the style guide.
  • The PR does not contain any unnecessary auto-generated code from Android Studio.
  • The PR is made from a branch that's not called "develop".
  • The PR is made from a branch that is up-to-date with "develop".
  • The PR's branch is based on "develop" and not on any other branch.
  • The PR is assigned to an appropriate reviewer in both the Assignees and the Reviewers sections.

BenHenning
BenHenning requested changes Mar 2, 2021
View reviewed changes
Copy link
Member

@BenHenning BenHenning left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @FareesHussain! This seems solid. Just need to make a few small changes after #2275 is in & 1 suggested edit.

utility/src/main/java/org/oppia/android/util/system/BUILD.bazel Outdated Show resolved Hide resolved
utility/src/main/java/org/oppia/android/util/system/BUILD.bazel Outdated Show resolved Hide resolved
utility/src/main/java/org/oppia/android/util/system/BUILD.bazel Outdated Show resolved Hide resolved
@BenHenning BenHenning changed the title Fix #2657: Added BUILD.bazel in util/system Fix #2657: Added BUILD.bazel in util/system [Blocked: #2775] Mar 2, 2021
fsharpasharp
fsharpasharp approved these changes Mar 2, 2021
View reviewed changes
Copy link
Contributor

@fsharpasharp fsharpasharp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I have nothing to add besides what Ben had to say. Looks clean!

@FareesHussain FareesHussain changed the title Fix #2657: Added BUILD.bazel in util/system [Blocked: #2775] Fix #2657: Added BUILD.bazel in util/system Mar 7, 2021
BenHenning
BenHenning approved these changes Mar 9, 2021
View reviewed changes
Copy link
Member

@BenHenning BenHenning left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @FareesHussain! This LGTM.

@BenHenning BenHenning merged commit 155783f into oppia:develop Mar 9, 2021
techjd pushed a commit to techjd/oppia-android that referenced this pull request Mar 9, 2021
@FareesHussain @BenHenning @techjd
Fix oppia#2657: Added BUILD.bazel in util/system (oppia#2795)
e55c476 
* Added BUILD.bazel in util/system

* changing the visibility private for oppia_clock_impl and re-arranging the targets

* Fix Load statement is out of its lexicographical order.

* Update utility/src/main/java/org/oppia/android/util/system/BUILD.bazel

Co-authored-by: Ben Henning <[email protected]>

* changed visibility for the targets

Co-authored-by: Ben Henning <[email protected]>
techjd added a commit to techjd/oppia-android that referenced this pull request Mar 9, 2021
@techjd
Revert "Fix oppia#2657: Added BUILD.bazel in util/system (oppia#2795)"
8e459f8 
This reverts commit e55c476.
techjd added a commit to techjd/oppia-android that referenced this pull request Mar 9, 2021
@techjd
Revert "Fix oppia#2657: Added BUILD.bazel in util/system (oppia#2795)"
29e93d5 
This reverts commit e55c476.
techjd pushed a commit to techjd/oppia-android that referenced this pull request Mar 9, 2021
@FareesHussain @BenHenning @techjd
Fix oppia#2657: Added BUILD.bazel in util/system (oppia#2795)
26079a8 
* Added BUILD.bazel in util/system

* changing the visibility private for oppia_clock_impl and re-arranging the targets

* Fix Load statement is out of its lexicographical order.

* Update utility/src/main/java/org/oppia/android/util/system/BUILD.bazel

Co-authored-by: Ben Henning <[email protected]>

* changed visibility for the targets

Co-authored-by: Ben Henning <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@fsharpasharp fsharpasharp fsharpasharp approved these changes

@BenHenning BenHenning BenHenning approved these changes

Assignees

@BenHenning BenHenning

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Create a BUILD.bazel file in utility/src/main/java/org/oppia/android/util/system
3 participants
@FareesHussain @BenHenning @fsharpasharp