Fix #161: Exploration player contentcard supports rich-text part. #275
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tests to verify correctness. Also, added a method to facilitate notifying of DataProvider changes on the UI thread.
…dered initialization.
… it up to the data controller, and start adding tests.
Conflicts: domain/build.gradle domain/src/main/java/org/oppia/domain/exploration/ExplorationDataController.kt Also, migrate the data controller to the retriever.
AnswerClassificationController, and attempted to make ExplorationProgressController thread-safe. The thread-safety led to significant interface changes in the progress controller, and led to discovering some issues with the mediator live data approach to interop coroutines and LiveData. This locking mechanism will need to change since the optimal solution requires resolving #90.
with the current MediatorLiveData implementation (see #90 for more context). Fix existing progress controller tests and add a few more. All current progress controller tests are passing.
…ation support for the second test exploration (about_oppia).
…-controller' into introduce-load-exploration-part-1
…yer-content-interaction
Separated this in its own PR.
rt4914
approved these changes
Nov 4, 2019
app/src/main/java/org/oppia/app/testing/ContentCardTestActivityPresenter.kt
Outdated
Show resolved
Hide resolved
app/src/sharedTest/java/org/oppia/app/player/state/StateFragmentTest.kt
Outdated
Show resolved
Hide resolved
|
@veena14cs Once these final changes are done. Re-assign it to me. |
Changes are done, but I am not able to run test case. its giving below error |
nikitamarysolomanpvt
approved these changes
Nov 4, 2019
app/src/main/java/org/oppia/app/player/state/itemviewmodel/ContentViewModel.kt
Outdated
Show resolved
Hide resolved
This error was thrown because of Android-studio update. |
BenHenning
approved these changes
Nov 5, 2019
rt4914
approved these changes
Nov 5, 2019
|
I am merging this PR on develop considering that we need this ASAP and this has already been approved. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Explanation
This PR is duplicate of #245.
This PR is mainly to focus on exploration content card it contains implementation of html parser which parses HTML content.
Change Activity to
ContentCardTestActivityin manifest to run the testcases.