Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix #2504: Address nit for HomeActivityTest to use verifyHomeRecyclerViewHasGridColumnCount() helper #2586

Merged
merged 5 commits into from
Feb 3, 2021
Merged

Fix #2504: Address nit for HomeActivityTest to use verifyHomeRecyclerViewHasGridColumnCount() helper #2586

Changes from all commits
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
354ace5
Use the `verifyHomeRecyclerViewHasGridColumnCount` helper in one appl…
yurilev Jan 29, 2021
a6f75da
Fix typo.
yurilev Jan 29, 2021
20d1373
Remove incorrect/confusing comment.
yurilev Jan 29, 2021
a08d6cb
Merge remote-tracking branch 'upstream/develop' into fix-2504-column-…
yurilev Jan 30, 2021
37a7998
Empty commit to retrigger CI tests.
yurilev Feb 1, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 2 additions & 5 deletions app/src/sharedTest/java/org/oppia/android/app/home/HomeActivityTest.kt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -636,10 +636,7 @@ class HomeActivityTest {
launch<HomeActivity>(createHomeActivityIntent(internalProfileId)).use {
testCoroutineDispatchers.runCurrent()
scrollToPosition(position = 3)
onView(withId(R.id.home_recycler_view)).check(
// The "All Topics" section currently should display the four test topics in two rows.
hasGridColumnCount(2)
)
verifyHomeRecyclerViewHasGridColumnCount(columnCount = 2)
}
}

Expand Down Expand Up @@ -675,7 +672,7 @@ class HomeActivityTest {

@Config(qualifiers = "land")
@Test
fun testHomeActivity_noTopicsStarted_mobileLandspaceDisplaysTopicsIn3Columns() {
fun testHomeActivity_noTopicsStarted_mobileLandscapeDisplaysTopicsIn3Columns() {
// Only new users will have no progress for any topics.
profileTestHelper.logIntoNewUser()
launch<HomeActivity>(createHomeActivityIntent(internalProfileId)).use {
Expand Down