Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Partially fixed #168: Introduced fragment components for profile choosing and adding #254

Merged
merged 6 commits into from
Oct 22, 2019
Merged

Partially fixed #168: Introduced fragment components for profile choosing and adding #254

merged 6 commits into from
Oct 22, 2019

Conversation

jamesxu0
Copy link
Contributor

@jamesxu0 jamesxu0 commented Oct 21, 2019 •
edited
Loading

Explanation

Partially fixing #168 : Introduced fragment components for profile choosing and adding. Introduced ProfileChooserFragment, AdminAuthFragment, and AddProfileFragment.

Checklist

  • The PR title starts with "Fix #bugnum: ", followed by a short, clear summary of the changes. (If this PR fixes part of an issue, prefix the title with "Fix part of #bugnum: ...".)
  • The PR explanation includes the words "Fixes #bugnum: ..." (or "Fixes part of #bugnum" if the PR only partially fixes an issue).
  • The PR follows the style guide.
  • The PR does not contain any unnecessary auto-generated code from Android Studio.
  • The PR is made from a branch that's not called "develop".
  • The PR is assigned to an appropriate reviewer.

@jamesxu0 jamesxu0 requested a review from BenHenning October 21, 2019 23:50
BenHenning
BenHenning approved these changes Oct 22, 2019
View reviewed changes
Copy link
Member

@BenHenning BenHenning left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Shouldn't this correspond to #168?

Other than that, this looks like a good introduction. Thanks @jamesxu0!

app/src/main/java/org/oppia/app/profile/AddProfileFragment.kt Outdated Show resolved Hide resolved
@BenHenning BenHenning assigned rt4914 and unassigned BenHenning Oct 22, 2019
@rt4914
Copy link
Contributor

rt4914 commented Oct 22, 2019

Shouldn't this correspond to #168?

Other than that, this looks like a good introduction. Thanks @jamesxu0!

+1 and also though it is fine for this PR but we generally do not use any Capital letter in branch name.

rt4914
rt4914 approved these changes Oct 22, 2019
View reviewed changes
Copy link
Contributor

@rt4914 rt4914 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Some nit changes for best practices.

app/src/main/java/org/oppia/app/profile/ProfileActivity.kt Show resolved Hide resolved
app/src/main/java/org/oppia/app/profile/ProfileActivity.kt Outdated Show resolved Hide resolved
app/src/main/java/org/oppia/app/profile/ProfileActivityPresenter.kt Outdated Show resolved Hide resolved
app/src/main/java/org/oppia/app/profile/ProfileChooserFragment.kt Outdated Show resolved Hide resolved
app/src/main/java/org/oppia/app/profile/ProfileChooserFragmentPresenter.kt Outdated Show resolved Hide resolved
app/src/main/java/org/oppia/app/profile/AdminAuthFragment.kt Outdated Show resolved Hide resolved
app/src/main/java/org/oppia/app/profile/AdminAuthFragmentPresenter.kt Outdated Show resolved Hide resolved
app/src/main/java/org/oppia/app/profile/ProfileChooserFragment.kt Outdated Show resolved Hide resolved
app/src/main/java/org/oppia/app/profile/ProfileChooserFragment.kt Outdated Show resolved Hide resolved
app/src/main/java/org/oppia/app/profile/ProfileChooserViewModel.kt Outdated Show resolved Hide resolved
@rt4914 rt4914 assigned jamesxu0 and unassigned rt4914 Oct 22, 2019
@jamesxu0 jamesxu0 changed the title Partially fixed #16: Introduced fragment components for profile choosing and adding Partially fixed #168: Introduced fragment components for profile choosing and adding Oct 22, 2019
@jamesxu0 jamesxu0 merged commit e167176 into develop Oct 22, 2019
@jamesxu0 jamesxu0 deleted the Introduce-profile-fragments branch October 22, 2019 17:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@BenHenning BenHenning BenHenning approved these changes

@rt4914 rt4914 rt4914 approved these changes

Assignees

@jamesxu0 jamesxu0

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@jamesxu0 @rt4914 @BenHenning