Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix #2491: Required Reformatting for administrator_controls_account_actions_view.xml #2534

Merged
merged 2 commits into from
Jan 25, 2021
Merged

Fix #2491: Required Reformatting for administrator_controls_account_actions_view.xml #2534

merged 2 commits into from
Jan 25, 2021

Conversation

Manikant25
Copy link
Contributor

@Manikant25 Manikant25 commented Jan 22, 2021 •
edited
Loading

Explanation

Fixes #2491 , Reformated

  • layout/administrator_controls_account_actions_view.xml
  • layout-land/administrator_controls_account_actions_view.xml
  • layout-sw600dp/administrator_controls_account_actions_view.xml

Checklist

  • The PR title starts with "Fix #bugnum: ", followed by a short, clear summary of the changes. (If this PR fixes part of an issue, prefix the title with "Fix part of #bugnum: ...".)
  • The PR explanation includes the words "Fixes #bugnum: ..." (or "Fixes part of #bugnum" if the PR only partially fixes an issue).
  • The PR follows the style guide.
  • The PR does not contain any unnecessary auto-generated code from Android Studio.
  • The PR is made from a branch that's not called "develop".
  • The PR is made from a branch that is up-to-date with "develop".
  • The PR's branch is based on "develop" and not on any other branch.
  • The PR is assigned to an appropriate reviewer in both the Assignees and the Reviewers sections.

@Manikant25 Manikant25 requested a review from rt4914 as a code owner January 22, 2021 06:06
@FareesHussain
Copy link
Contributor

@Manikant25 can you please recheck this file for reformatting
layout/administrator_controls_account_actions_view.xml

@Manikant25
Copy link
Contributor Author

Okay I check

@Manikant25
Copy link
Contributor Author

@FareesHussain I checked again when I applied for reformating, it says code is already formated

@FareesHussain
Copy link
Contributor

@FareesHussain I checked again when I applied for reformating, it says code is already formated

Can you update your branch and recheck it? for me, it is not reformatted yet

FareesHussain
FareesHussain suggested changes Jan 22, 2021
View reviewed changes
Copy link
Contributor

@FareesHussain FareesHussain left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@Manikant25 You've already made changes for
layout/administrator_controls_account_actions_view.xml

please update
layout-land/administrator_controls_account_actions_view.xml as well

@rt4914 rt4914 self-assigned this Jan 22, 2021
rt4914
rt4914 approved these changes Jan 23, 2021
View reviewed changes
Copy link
Contributor

@rt4914 rt4914 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks.

rt4914
rt4914 suggested changes Jan 23, 2021
View reviewed changes
Copy link
Contributor

@rt4914 rt4914 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Blocking as per this comment: #2534 (review)

@rt4914 rt4914 assigned Manikant25 and unassigned rt4914 Jan 23, 2021
@rt4914
Copy link
Contributor

rt4914 commented Jan 23, 2021

@Manikant25 PTAL

FareesHussain
FareesHussain approved these changes Jan 23, 2021
View reviewed changes
Copy link
Contributor

@FareesHussain FareesHussain left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks

rt4914
rt4914 approved these changes Jan 25, 2021
View reviewed changes
Copy link
Contributor

@rt4914 rt4914 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks.

@rt4914 rt4914 merged commit 4f0a60e into oppia:develop Jan 25, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@FareesHussain FareesHussain FareesHussain approved these changes

@rt4914 rt4914 rt4914 approved these changes

Assignees

@rt4914 rt4914

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Required Reformatting for administrator_controls_account_actions_view.xml
3 participants
@Manikant25 @FareesHussain @rt4914