-
Notifications
You must be signed in to change notification settings - Fork 528
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fixes part of #2325: Changes in Cellular dialog[a11y] #2519
Fixes part of #2325: Changes in Cellular dialog[a11y] #2519
Conversation
Fixes Issue 2 of oppia#2325 by increasing the clickable checkbox minimum height to be 28dp
@Arjupta In PRs related to a11y, always post following things:
|
Update title to |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Overall good. Just need to do the changes mentioned above and remove from draft.
@rt4914 I have done required changes but as you can see that there is a slight variation in the height of dialog because of the changes. This is not actually breaking the UI but still a bit different from the previous one |
@Arjupta That's not an issue because for all AlertDialog we are not trying to copy the UI to pixel perfect instead we reply on Android Native UI to make sure it looks good. So don't worry about this nit change. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, thanks.
Also update your branch with latest develop. @Arjupta |
done |
Explanation
Fixes Issue 2 of #2325 by increasing the clickable checkbox minimum height to be 48dp
Checklist