Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix #161: Exploration player contentcard supports rich-text part [Blocked: #205] #245
Fix #161: Exploration player contentcard supports rich-text part [Blocked: #205] #245
Changes from 16 commits
89a0da9
a5b6bef
79103a9
df2bfa1
210b7ef
955bd17
6646147
2dec064
e3b3c41
7cdcd16
1a8e43f
ad22bd2
1bb75a9
d3e3ae6
15ca36f
aa2e2c7
90ee2b0
d186a1a
c28e84b
68a0961
92791d6
7eed350
2dd5203
399a5cc
eb95575
103a822
a0fc0d0
df93486
f6663ae
028224f
bada6ad
01821d5
12f6975
2bd32c9
e084804
2eb4fde
cb90be5
File filter
Filter by extension
Conversations
Jump to
There are no files selected for viewing
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Add a comment and also mention in descroiption that why this file is in this PR even though the file already exists in
develop
.There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Added comment. This file is not directly from develop its from merge-fix. Once merge-fix is updated from develop this file will be removed.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@veena14cs Remove this comment from here, apologies I was not clear in earlier comment.
I meant at comment on Github,I mentioned that in "Files Changed" and also, mention that in PR description and not in this file. Because we do not want this comment in develop code.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Okay, removed it from code.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Why do we need this class? Isn't it already in
develop
? (https://github.com/oppia/oppia-android/blob/develop/app/src/sharedTest/java/org/oppia/app/recyclerview/RecyclerViewMatcher.kt).Please remove (or merge
develop
into your base branch to bring this up-to-date).There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Recyclerview Matcher file is added in this PR for testcase, It is already present in develop. Once #205 is approved and update to develop this file will be removed.