-
Notifications
You must be signed in to change notification settings - Fork 533
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix part of #136: Topic overview low fi part 2 - Topic Download/Delete [ON HOLD] #236
Fix part of #136: Topic overview low fi part 2 - Topic Download/Delete [ON HOLD] #236
Conversation
@veena14cs @nikitamarysolomanpvt This PR does not contain any test-cases but is ready in terms of functionality. You can have the first review. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good.
@BenHenning This PR is ready for your review. |
Thanks @rt4914. Apologies for the noise, but we're actually deprioritizing topic download/deletion flows for the prototype. Since we may not finish the infrastructure work for this (#169) in the prototype time frame, I'd rather not have the UI in place. Let's put this on hold for now (and keep the PR open) with the intention of completing it post prototype. Let me know if you'd like to discuss this further. |
Okay no issues. This makes sense. |
Explanation
This PR is based on PR #233 and implements Topic Download and Delete functionality.
Mock: https://xd.adobe.com/spec/e2239cf4-9cde-4c08-5296-25316c1f0a14-9412/screen/b98da363-bac6-4f7d-b1d2-ee0f9aa048c4/Topic-w-o-Play-8
For testing purpose make following change in code:
TopicActivity
TopicActivityPresenter
changeTopicFragment
toTopicOverviewFragment
Checklist