Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix #2263: Fixes App crashes in Lessons Tab and Espresso tests in TopicLessonFragmentTest #2264

Merged
merged 5 commits into from
Dec 23, 2020
Merged

Fix #2263: Fixes App crashes in Lessons Tab and Espresso tests in TopicLessonFragmentTest #2264

Changes from 1 commit
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
66b5af4
fixing crashes
FareesHussain Dec 15, 2020
4f75a2c
Resolving requested changes
FareesHussain Dec 19, 2020
ebec891
fix ktlint check
FareesHussain Dec 19, 2020
ec2e949
Added config change for espresso
FareesHussain Dec 20, 2020
f8ecfc6
Adding requested tests
FareesHussain Dec 22, 2020
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 4 additions & 0 deletions app/src/sharedTest/java/org/oppia/android/app/topic/lessons/TopicLessonsFragmentTest.kt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -20,6 +20,7 @@ import androidx.test.espresso.intent.matcher.IntentMatchers.hasExtra
import androidx.test.espresso.matcher.ViewMatchers.hasDescendant
import androidx.test.espresso.matcher.ViewMatchers.isDescendantOfA
import androidx.test.espresso.matcher.ViewMatchers.isDisplayed
import androidx.test.espresso.matcher.ViewMatchers.isRoot
import androidx.test.espresso.matcher.ViewMatchers.withId
import androidx.test.espresso.matcher.ViewMatchers.withText
import androidx.test.ext.junit.runners.AndroidJUnit4
Expand Down Expand Up @@ -49,6 +50,7 @@ import org.oppia.android.app.story.StoryActivity
import org.oppia.android.app.topic.TopicActivity
import org.oppia.android.app.topic.TopicTab
import org.oppia.android.app.utility.EspressoTestsMatchers.withDrawable
import org.oppia.android.app.utility.OrientationChangeAction.Companion.orientationLandscape
import org.oppia.android.domain.classify.InteractionsModule
import org.oppia.android.domain.classify.rules.continueinteraction.ContinueModule
import org.oppia.android.domain.classify.rules.dragAndDropSortInput.DragDropSortInputModule
Expand Down Expand Up @@ -168,6 +170,7 @@ class TopicLessonsFragmentTest {
fun testLessonsPlayFragment_loadRatiosTopic_configurationChange_storyName_isCorrect() {
launch<TopicActivity>(createTopicActivityIntent(internalProfileId, RATIOS_TOPIC_ID)).use {
clickLessonTab()
onView(isRoot()).perform(orientationLandscape())
verifyTextOnStorySummaryListItemAtPosition(itemPosition = 1, stringToMatch = "Ratios: Part 1")
}
}
Expand Down Expand Up @@ -308,6 +311,7 @@ class TopicLessonsFragmentTest {
fun testLessonsPlayFragment_loadRatiosTopic_clickExpandListIconIndex1_configurationChange_chapterListIsVisible() { // ktlint-disable max-line-length
launch<TopicActivity>(createTopicActivityIntent(internalProfileId, RATIOS_TOPIC_ID)).use {
clickLessonTab()
onView(isRoot()).perform(orientationLandscape())
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I added these again cause orientation does'nt change in Espresso
even if using @config

clickStoryItem(position = 1, targetViewId = R.id.chapter_list_drop_down_icon)
scrollToPosition(position = 1)
onView(
Expand Down