Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix part of #210: Fix name and test inconsistencies for FractionInputIsEquivalentToRuleClassifierProviderTest #2221

Merged
merged 8 commits into from
Dec 4, 2020
Merged

Fix part of #210: Fix name and test inconsistencies for FractionInputIsEquivalentToRuleClassifierProviderTest #2221

merged 8 commits into from
Dec 4, 2020

Conversation

jcqli
Copy link
Contributor

@jcqli jcqli commented Dec 3, 2020 •
edited by BenHenning
Loading

Explanation

Fixes part of #210 for FractionInputIsEquivalentToRuleClassifierProviderTests that were previously submitted.
Test case names and the actual test logic were inconsistent -- this change matches the actual test names to the test logic, does not add new test cases.

Checklist

  • The PR title starts with "Fix #bugnum: ", followed by a short, clear summary of the changes. (If this PR fixes part of an issue, prefix the title with "Fix part of #bugnum: ...".)
  • The PR explanation includes the words "Fixes #bugnum: ..." (or "Fixes part of #bugnum" if the PR only partially fixes an issue).
  • The PR follows the style guide.
  • The PR does not contain any unnecessary auto-generated code from Android Studio.
  • The PR is made from a branch that's not called "develop".
  • The PR is made from a branch that is up-to-date with "develop".
  • The PR's branch is based on "develop" and not on any other branch.
  • The PR is assigned to an appropriate reviewer in both the Assignees and the Reviewers sections.

@jcqli jcqli changed the title Fix part of #210: Fix some name and test inconsistencies for FractionInputIsEquivalentToRuleClassifierProvider Fix part of #210: Fix name and test inconsistencies for FractionInputIsEquivalentToRuleClassifierProviderTest Dec 3, 2020
@jcqli
Copy link
Contributor Author

jcqli commented Dec 3, 2020

@BenHenning @vinitamurthi PTAL

BenHenning
BenHenning requested changes Dec 3, 2020
View reviewed changes
Copy link
Member

@BenHenning BenHenning left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @jcqli for cleaning these up! Left a few thoughts for potential additional improvements.

...domain/classify/rules/fractioninput/FractionInputIsEquivalentToRuleClassifierProviderTest.kt Outdated Show resolved Hide resolved
...domain/classify/rules/fractioninput/FractionInputIsEquivalentToRuleClassifierProviderTest.kt Outdated Show resolved Hide resolved
...domain/classify/rules/fractioninput/FractionInputIsEquivalentToRuleClassifierProviderTest.kt Outdated Show resolved Hide resolved
@BenHenning BenHenning assigned jcqli and unassigned BenHenning Dec 3, 2020
@BenHenning BenHenning assigned BenHenning and unassigned jcqli Dec 4, 2020
BenHenning
BenHenning approved these changes Dec 4, 2020
View reviewed changes
Copy link
Member

@BenHenning BenHenning left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @jcqli. This looks good!

@BenHenning BenHenning merged commit 49b3f3c into oppia:develop Dec 4, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@BenHenning BenHenning BenHenning approved these changes

@vinitamurthi vinitamurthi Awaiting requested review from vinitamurthi

Assignees

@vinitamurthi vinitamurthi

@BenHenning BenHenning

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@jcqli @BenHenning @vinitamurthi