Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix #2202: Adding bullet points in FAQ answers #2203

Merged
merged 10 commits into from
Dec 4, 2020

Conversation

FareesHussain
Copy link
Contributor

@FareesHussain FareesHussain commented Dec 1, 2020

Explanation

Fixes #2202

  • Changed all lines with '-' to bullet points

Checklist

  • The PR title starts with "Fix #bugnum: ", followed by a short, clear summary of the changes. (If this PR fixes part of an issue, prefix the title with "Fix part of #bugnum: ...".)
  • The PR explanation includes the words "Fixes #bugnum: ..." (or "Fixes part of #bugnum" if the PR only partially fixes an issue).
  • The PR follows the style guide.
  • The PR does not contain any unnecessary auto-generated code from Android Studio.
  • The PR is made from a branch that's not called "develop".
  • The PR is made from a branch that is up-to-date with "develop".
  • The PR's branch is based on "develop" and not on any other branch.
  • The PR is assigned to an appropriate reviewer in both the Assignees and the Reviewers sections.

Screenshots

How can I delete a profile? Why is the Exploration player not loading? Why is my audio not playing?
Screenshot_1606821079 Screenshot_1606821099 Screenshot_1606821103

@FareesHussain FareesHussain changed the title Fix #2202: Rtl support layouts Fix #2202: Adding bullet points in FAQ answers Dec 1, 2020
@FareesHussain
Copy link
Contributor Author

@anandwana001 please check

Copy link
Contributor

@anandwana001 anandwana001 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM,Thanks @FareesHussain

Defer to @rt4914 for further merge. Also, does the line spacing in. these bullets looks correct to you?
Also, do you think we need a new pr here as there are commits which are from the different branch?

Copy link
Contributor

@rt4914 rt4914 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@FareesHussain Blocking this PR for now because we will need to take approval from @mschanteltc first considering that in her designs she had mentioned - instead of bullets.

Original Designs:

How can I delete a profile? Why is the Exploration player not loading? Why is my audio not playing?
Screenshot_1606821079 Screenshot_1606821099 Screenshot_1606821103

@mschanteltc
Copy link

@rt4914 I actually prefer the bullet point designs more than the - dashes since bullet points draw more attention.

Also would it be possible we can indent all bullet points? Left aligning the bullet points with the body text makes it harder to identify the main points (i.e. "Check your internet connection:"). Indenting bullet points would make them more associated with the description that precedes it.

@rt4914
Copy link
Contributor

rt4914 commented Dec 4, 2020

@rt4914 I actually prefer the bullet point designs more than the - dashes since bullet points draw more attention.

Also would it be possible we can indent all bullet points? Left aligning the bullet points with the body text makes it harder to identify the main points (i.e. "Check your internet connection:"). Indenting bullet points would make them more associated with the description that precedes it.

  1. Sounds good.

  2. I am actually not able to understand the indent part. Does this mean that we should give some start margin for bullets similar to what google doc does?

@mschanteltc

@rt4914
Copy link
Contributor

rt4914 commented Dec 4, 2020

@rt4914 I actually prefer the bullet point designs more than the - dashes since bullet points draw more attention.
Also would it be possible we can indent all bullet points? Left aligning the bullet points with the body text makes it harder to identify the main points (i.e. "Check your internet connection:"). Indenting bullet points would make them more associated with the description that precedes it.

  1. Sounds good.
  2. I am actually not able to understand the indent part. Does this mean that we should give some start margin for bullets similar to what google doc does?

@mschanteltc

Update on this. We are merging this PR as this does not affect what @mschanteltc is suggested related to indentation. For that once @mschanteltc clarifies above question we will file a separate issue.

Copy link
Contributor

@rt4914 rt4914 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks.

@rt4914 rt4914 merged commit cb6d845 into oppia:develop Dec 4, 2020
@mschanteltc
Copy link

@rt4914 I actually prefer the bullet point designs more than the - dashes since bullet points draw more attention.
Also would it be possible we can indent all bullet points? Left aligning the bullet points with the body text makes it harder to identify the main points (i.e. "Check your internet connection:"). Indenting bullet points would make them more associated with the description that precedes it.

  1. Sounds good.
  2. I am actually not able to understand the indent part. Does this mean that we should give some start margin for bullets similar to what google doc does?

@mschanteltc

Update on this. We are merging this PR as this does not affect what @mschanteltc is suggested related to indentation. For that once @mschanteltc clarifies above question we will file a separate issue.

Yes your second note is what I am suggesting. Increase the left margin of the bullet point in the same way that Google Doc does it.

@rt4914
Copy link
Contributor

rt4914 commented Dec 4, 2020

@rt4914 I actually prefer the bullet point designs more than the - dashes since bullet points draw more attention.
Also would it be possible we can indent all bullet points? Left aligning the bullet points with the body text makes it harder to identify the main points (i.e. "Check your internet connection:"). Indenting bullet points would make them more associated with the description that precedes it.

  1. Sounds good.
  2. I am actually not able to understand the indent part. Does this mean that we should give some start margin for bullets similar to what google doc does?

@mschanteltc

Update on this. We are merging this PR as this does not affect what @mschanteltc is suggested related to indentation. For that once @mschanteltc clarifies above question we will file a separate issue.

Yes your second note is what I am suggesting. Increase the left margin of the bullet point in the same way that Google Doc does it.

Thanks. Filed #2228

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Some Answers in FAQ needs bullet points
4 participants