-
Notifications
You must be signed in to change notification settings - Fork 526
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix #2202: Adding bullet points in FAQ answers #2203
Conversation
… rtl-support-layouts
… rtl-support-layouts
… rtl-support-layouts
@anandwana001 please check |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM,Thanks @FareesHussain
Defer to @rt4914 for further merge. Also, does the line spacing in. these bullets looks correct to you?
Also, do you think we need a new pr here as there are commits which are from the different branch?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@FareesHussain Blocking this PR for now because we will need to take approval from @mschanteltc first considering that in her designs she had mentioned -
instead of bullets.
Original Designs:
How can I delete a profile? | Why is the Exploration player not loading? | Why is my audio not playing? |
---|---|---|
@rt4914 I actually prefer the bullet point designs more than the Also would it be possible we can indent all bullet points? Left aligning the bullet points with the body text makes it harder to identify the main points (i.e. "Check your internet connection:"). Indenting bullet points would make them more associated with the description that precedes it. |
|
Update on this. We are merging this PR as this does not affect what @mschanteltc is suggested related to indentation. For that once @mschanteltc clarifies above question we will file a separate issue. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, thanks.
Yes your second note is what I am suggesting. Increase the left margin of the bullet point in the same way that Google Doc does it. |
Thanks. Filed #2228 |
Explanation
Fixes #2202
Checklist
Screenshots