-
Notifications
You must be signed in to change notification settings - Fork 526
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix #2176: Added RTL Support for Profile List Screen (profile_view_profile_list.xml file) #2199
Fix #2176: Added RTL Support for Profile List Screen (profile_view_profile_list.xml file) #2199
Conversation
Added RTL Support in the ongoing_topic_item
@rt4914 , Please have a look. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, Thanks @ForgottenProgramme
Defer to @rt4914 for further merge.
Please follow the checklist
- PR title
- PR description
- Branch naming - https://github.com/oppia/oppia-android/wiki#instructions-for-making-a-code-change, you can follow branch naming from your next pr's
Thankyou, @anandwana001 ! :) I have one doubt:
And @anandwana001 , please tell me what should I change in my PR title and description? |
|
@anandwana001 , thankyou. Got it. |
@ForgottenProgramme Update the PR title to this format: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, Will wait for merge until the PR title is updated.
Done! |
Explanation
Fixes #2176
Added RTL support for Profile List Screen
Checklist
Screenshots: