Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix #2176: Added RTL Support for Profile List Screen (profile_view_profile_list.xml file) #2199

Merged

Conversation

ForgottenProgramme
Copy link
Contributor

@ForgottenProgramme ForgottenProgramme commented Dec 1, 2020

Explanation

Fixes #2176
Added RTL support for Profile List Screen

Checklist

  • The PR title starts with "Fix #bugnum: ", followed by a short, clear summary of the changes. (If this PR fixes part of an issue, prefix the title with "Fix part of #bugnum: ...".)
  • The PR explanation includes the words "Fixes #bugnum: ..." (or "Fixes part of #bugnum" if the PR only partially fixes an issue).
  • The PR follows the style guide.
  • The PR does not contain any unnecessary auto-generated code from Android Studio.
  • The PR is made from a branch that's not called "develop".
  • The PR is made from a branch that is up-to-date with "develop".
  • The PR's branch is based on "develop" and not on any other branch.
  • The PR is assigned to an appropriate reviewer in both the Assignees and the Reviewers sections.

Screenshots:

port_mob

land_mob

port_tab

land_tab

@ForgottenProgramme
Copy link
Contributor Author

@rt4914 , Please have a look.

Copy link
Contributor

@anandwana001 anandwana001 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, Thanks @ForgottenProgramme
Defer to @rt4914 for further merge.

Please follow the checklist

  1. PR title
  2. PR description
  3. Branch naming - https://github.com/oppia/oppia-android/wiki#instructions-for-making-a-code-change, you can follow branch naming from your next pr's

@ForgottenProgramme
Copy link
Contributor Author

  1. Branch naming - https://github.com/oppia/oppia-android/wiki#instructions-for-making-a-code-change, you can follow branch naming from your next pr's

Thankyou, @anandwana001 ! :)

I have one doubt:
Do we create a new branch every time we make a new PR ?

Please follow the checklist

  1. PR title
  2. PR description

And @anandwana001 , please tell me what should I change in my PR title and description?

@anandwana001
Copy link
Contributor

anandwana001 commented Dec 1, 2020

  1. Branch naming - https://github.com/oppia/oppia-android/wiki#instructions-for-making-a-code-change, you can follow branch naming from your next pr's

Thankyou, @anandwana001 ! :)

I have one doubt:
Do we create a new branch every time we make a new PR ?

Please follow the checklist

  1. PR title
  2. PR description

And @anandwana001 , please tell me what should I change in my PR title and description?

  1. Yes, we always need to create a new branch for every new pr, it's like a new work/new pr.
  2. For pr title and description, please check the ##Checklist in the PR description first and the second point. I had unchecked those points.

@ForgottenProgramme
Copy link
Contributor Author

  1. Yes, we always need to create a new branch for every new pr, it's like a new work/new pr.
  2. For pr title and description, please check the ##Checklist in the PR description first and the second point. I had unchecked those points.

@anandwana001 , thankyou. Got it.

@rt4914 rt4914 assigned rt4914 and unassigned ForgottenProgramme Dec 1, 2020
@rt4914
Copy link
Contributor

rt4914 commented Dec 4, 2020

@ForgottenProgramme Update the PR title to this format:
Fix #2176: Added RTL Support for Profile List Screen (profile_view_profile_list.xml file)

Copy link
Contributor

@rt4914 rt4914 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, Will wait for merge until the PR title is updated.

@rt4914 rt4914 assigned ForgottenProgramme and unassigned rt4914 Dec 4, 2020
@ForgottenProgramme ForgottenProgramme changed the title Fix: #2176 , Added RTL Support for Profile List Screen (profile_view_profile_list.xml file) Fix #2176: Added RTL Support for Profile List Screen (profile_view_profile_list.xml file) Dec 4, 2020
@ForgottenProgramme
Copy link
Contributor Author

LGTM, Will wait for merge until the PR title is updated.

Done!

@rt4914 rt4914 merged commit 71935a0 into oppia:develop Dec 4, 2020
@ForgottenProgramme ForgottenProgramme deleted the RTL-support-ForgottenProgramme branch December 4, 2020 09:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[RTL] High-fi Profile List
3 participants