Fix #114: Implement answer classification controller #211
Conversation
tests to verify correctness. Also, added a method to facilitate notifying of DataProvider changes on the UI thread.
…dered initialization.
… it up to the data controller, and start adding tests.
Conflicts: domain/build.gradle domain/src/main/java/org/oppia/domain/exploration/ExplorationDataController.kt Also, migrate the data controller to the retriever.
AnswerClassificationController, and attempted to make ExplorationProgressController thread-safe. The thread-safety led to significant interface changes in the progress controller, and led to discovering some issues with the mediator live data approach to interop coroutines and LiveData. This locking mechanism will need to change since the optimal solution requires resolving #90.
with the current MediatorLiveData implementation (see #90 for more context). Fix existing progress controller tests and add a few more. All current progress controller tests are passing.
…ation support for the second test exploration (about_oppia).
…nt-answer-classification-controller
prototype. This uses a Dagger-powered solution to make it straightforward to add new rule types and interactions in a way that automatically hooks into the classifier. This only adds TextInput support, so existing tests do not pass. Tests and the app do build.
two bound input values.
exploration progress controller tests for numeric input.
comments to point to their corresponding Oppia web versions.
and fix ExplorationProgressController tests (which also included fixing one bug in the TextInput FuzzyEquals and the progress controller's fallback routing logic).
BenHenning
changed the base branch from
develop
to
introduce-exploration-progress-controller
|
Folks: I can split this up, but I'd rather not since it's slightly tricky to do in a way that doesn't cause ExplorationProgressControllerTest to fail. Most of the code is boilerplate, and I actually don't care about you verifying the correctness of the classifiers beyond "does this look like the JavaScript version". Once you skip past those + the Dagger modules, there's not much code left to verify (AnswerClassificationController & ExplorationProgressController + tests are the main chunks of new code). |
|
NB: This will be rebased onto develop, so please review as if it's going into develop (because it will be). |
Conflicts: domain/src/main/java/org/oppia/domain/classify/AnswerClassificationController.kt domain/src/main/java/org/oppia/domain/exploration/ExplorationProgressController.kt domain/src/main/java/org/oppia/domain/exploration/ExplorationRetriever.kt domain/src/test/java/org/oppia/domain/classify/AnswerClassificationControllerTest.kt domain/src/test/java/org/oppia/domain/exploration/ExplorationProgressControllerTest.kt
BenHenning
changed the base branch from
introduce-exploration-progress-controller
to
develop
|
@vinitamurthi / @jamesxu0 if you get a chance, please review. It'd be good to get a few folks looking at this just due to the amount of stuff being added. |
|
Given this is blocking downstream work, I'm going to check this in. I'm pretty confident in it, but @vinitamurthi & @jamesxu0 please do still take a look at this & let me know if you have any concerns. I'll follow up with a fix in a subsequent PR. |
This introduces all of the necessary rule classification support for the prototype, including:
This does not include deep tests for any of these classifiers individually (and some may have bugs), but #210 is tracking adding more thorough tests. The AnswerClassificationController is being well tested, and ExplorationProgressController from the base branch runs through real explorations end-to-end which in turn verifies that some of the classifiers are working.
This PR introduces these classifiers in a generic way so that it's easy to add both additional interactions and rule types in the future. It also does generic answer classification in a type-safe way and such that the base logic for the classification is as simple as possible (e.g. verifying strings directly for TextInput rather than extracting the normalized string and verifying that both the input and answer have the correct type).
This also makes a few adjustments in various protos, and fixes a few small issues that were found in ExplorationProgressController.