-
Notifications
You must be signed in to change notification settings - Fork 526
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix #2040: Reformating files under TextInput Package #2070
Conversation
@Arjupta
|
Pardon me, I will use descriptive branch names for further PRs. @anandwana001 PTAL |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks @Arjupta Left few comments.
Also, put a screenshot in the PR description showing all the test cases are passing.
...oppia/android/domain/classify/rules/textinput/TextInputContainsRuleClassifierProviderTest.kt
Outdated
Show resolved
Hide resolved
...ia/android/domain/classify/rules/textinput/TextInputFuzzyEqualsRuleClassifierProviderTest.kt
Outdated
Show resolved
Hide resolved
@anandwana001 Can you direct me on how to run the test of another module? |
Head over to our wiki page for testing - https://github.com/oppia/oppia-android/wiki/Oppia-Android-Testing |
@anandwana001 Adding the screensnips for individual tests |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, thanks.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks @Arjupta left a comment
...oppia/android/domain/classify/rules/textinput/TextInputContainsRuleClassifierProviderTest.kt
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
nit changes. Else good to go.
...oppia/android/domain/classify/rules/textinput/TextInputContainsRuleClassifierProviderTest.kt
Outdated
Show resolved
Hide resolved
...oppia/android/domain/classify/rules/textinput/TextInputContainsRuleClassifierProviderTest.kt
Outdated
Show resolved
Hide resolved
...oppia/android/domain/classify/rules/textinput/TextInputContainsRuleClassifierProviderTest.kt
Outdated
Show resolved
Hide resolved
...oppia/android/domain/classify/rules/textinput/TextInputContainsRuleClassifierProviderTest.kt
Outdated
Show resolved
Hide resolved
...oppia/android/domain/classify/rules/textinput/TextInputContainsRuleClassifierProviderTest.kt
Outdated
Show resolved
Hide resolved
...ia/android/domain/classify/rules/textinput/TextInputFuzzyEqualsRuleClassifierProviderTest.kt
Outdated
Show resolved
Hide resolved
...ia/android/domain/classify/rules/textinput/TextInputFuzzyEqualsRuleClassifierProviderTest.kt
Outdated
Show resolved
Hide resolved
...ia/android/domain/classify/rules/textinput/TextInputFuzzyEqualsRuleClassifierProviderTest.kt
Outdated
Show resolved
Hide resolved
...ia/android/domain/classify/rules/textinput/TextInputFuzzyEqualsRuleClassifierProviderTest.kt
Outdated
Show resolved
Hide resolved
...id/domain/classify/rules/textinput/TextInputCaseSensitiveEqualsRuleClassifierProviderTest.kt
Outdated
Show resolved
Hide resolved
@Arjupta please comment on comments above for further review. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
nit change. @Arjupta
...pia/android/domain/classify/rules/textinput/TextInputStartsWithRuleClassifierProviderTest.kt
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, Thanks @Arjupta
Just for the future reference, please move the screenshot in the PR description, it should not be in the comment.
Okay 👍 |
@rt4914 deferring to you for further merge. |
@aggarwalpulkit596 Please add points. |
give @Arjupta 5 points |
Explanation
Fixes #2040 : Reformated fies under TextInput Package according to this file
Checklist