-
Notifications
You must be signed in to change notification settings - Fork 526
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix #1810: Renaming the admin profile creates new one #2051
Fix #1810: Renaming the admin profile creates new one #2051
Conversation
Updating my fork
updating my fork
updating branch from develop fork
@chrk2205 Please have a look at lint tests which are failing. Thanks. |
|
Exceeded max line length in |
okay. |
@rt4914 @BenHenning |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Really nice work. One nit suggested.
domain/src/test/java/org/oppia/android/domain/profile/ProfileManagementControllerTest.kt
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, thanks.
Explanation
fixes #1810
to overcome this, I created a function for
addProfile
to check if an admin.Checklist