Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix #1810: Renaming the admin profile creates new one #2051

Merged

Conversation

chrk2205
Copy link
Contributor

Explanation

fixes #1810
to overcome this, I created a function for addProfile to check if an admin.

Checklist

  • The PR title starts with "Fix #bugnum: ", followed by a short, clear summary of the changes. (If this PR fixes part of an issue, prefix the title with "Fix part of #bugnum: ...".)
  • The PR explanation includes the words "Fixes #bugnum: ..." (or "Fixes part of #bugnum" if the PR only partially fixes an issue).
  • The PR follows the style guide.
  • The PR does not contain any unnecessary auto-generated code from Android Studio.
  • The PR is made from a branch that's not called "develop".
  • The PR is made from a branch that is up-to-date with "develop".
  • The PR's branch is based on "develop" and not on any other branch.
  • The PR is assigned to an appropriate reviewer in both the Assignees and the Reviewers sections.

@rt4914 rt4914 self-requested a review October 28, 2020 09:26
@rt4914 rt4914 self-assigned this Oct 28, 2020
@rt4914
Copy link
Contributor

rt4914 commented Oct 28, 2020

@chrk2205 Please have a look at lint tests which are failing. Thanks.

@rt4914
Copy link
Contributor

rt4914 commented Oct 28, 2020

@chrk2205

  1. Please have a look at lint tests which are failing.
  2. I think we should add tests for this functionality in ProfileManagementControllerTest.
  3. Also, the PR title should be :
    Fix #1810: Renaming the admin profile creates new one

@rt4914 rt4914 assigned chrk2205 and unassigned rt4914 Oct 28, 2020
@chrk2205
Copy link
Contributor Author

@chrk2205 Please have a look at lint tests which are failing. Thanks.

Exceeded max line length in
return@storeDataWithCustomChannelAsync Pair(it, ProfileActionStatus.PROFILE_ALREADY_HAS_ADMIN)

@chrk2205 chrk2205 changed the title fixes #1810 Renaming the admin profile creates new one Fix #1810: Renaming the admin profile creates new one Oct 28, 2020
@chrk2205
Copy link
Contributor Author

chrk2205 commented Oct 28, 2020

@chrk2205
2. I think we should add tests for this functionality in ProfileManagementControllerTest.

okay.

Test Case Added
@chrk2205
Copy link
Contributor Author

chrk2205 commented Oct 28, 2020

@rt4914 @BenHenning
testcase Added &
all lint cases passed
PTAL thankyou

Copy link
Contributor

@rt4914 rt4914 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Really nice work. One nit suggested.

nit changes
@chrk2205 chrk2205 requested a review from rt4914 October 28, 2020 18:53
Copy link
Contributor

@rt4914 rt4914 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks.

@rt4914 rt4914 merged commit 4b54071 into oppia:develop Oct 28, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Renaming the admin profile creates a new one
2 participants